Feedback-ID: i131946ab:Fastmail
Message-ID: <77358b4c-6497-e5d3-c13c-57522654af25@enterprisedb.com>
Date: Wed, 29 Jun 2022 14:36:08 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.10.0
Subject: Re: [PoC] Let libpq reject unexpected authentication requests
Content-Language: en-US
To: Jacob Champion <jchampion@timescale.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Cc: Michael Paquier <michael@paquier.xyz>,
 "David G. Johnston" <david.g.johnston@gmail.com>
References: <9e5a8ccddb8355ea9fa4b75a1e3a9edc88a70cd3.camel@vmware.com>
 <YpcbXecOyxf8Zacb@paquier.xyz>
 <CAAWbhmihtCa0=Pg5mtTWTWmZ+onXSgx2QUbomv6NJprTLAiRBQ@mail.gmail.com>
 <CAAWbhmizLpLdCVj=6YaH92v+raLnFi=-tD6fppcRMtObLxV9ow@mail.gmail.com>
 <YqF92PYPhsjXNYWG@paquier.xyz>
 <CAAWbhmgL1M_yNUeS+Ear=UZoZ6G=tCX5rMx2rETNbjVJJtK40A@mail.gmail.com>
 <CAKFQuwabmJHf+68wo0=dd9EE=9H0RbO=S0SJ23Kpnn8peANZoA@mail.gmail.com>
 <CAAWbhmjOVfRr=Pjp3ZjcVLnHoXBXvn=hcjC2JV02cXB71uWjWg@mail.gmail.com>
 <CAAWbhmitLHUBkUUJmsG2CuVfH=OXTzj6pU1C8XYerYBM2TBfbQ@mail.gmail.com>
 <CAAWbhmi4V9zEAvfUSCDFx1pOr3ZWrV9fuxkv_2maRqvyc-m9PQ@mail.gmail.com>
 <CAAWbhmhjuHUfCs4NbB6p_MeuAgqq+et17SN=QR52HRH8zcMfFQ@mail.gmail.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: 
 <CAAWbhmhjuHUfCs4NbB6p_MeuAgqq+et17SN=QR52HRH8zcMfFQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/77358b4c-6497-e5d3-c13c-57522654af25%40enterprisedb.com>
Precedence: bulk

On 27.06.22 23:40, Jacob Champion wrote:
> -HINT:  Valid options in this context are: service, passfile, channel_binding, connect_timeout, dbname, host, hostaddr, port, options, application_name, keepalives, keepalives_idle, keepalives_interval, keepalives_count, tcp_user_timeout, sslmode, sslcompression, sslcert, sslkey, sslrootcert, sslcrl, sslcrldir, sslsni, requirepeer, ssl_min_protocol_version, ssl_max_protocol_version, gssencmode, krbsrvname, gsslib, target_session_attrs, use_remote_estimate, fdw_startup_cost, fdw_tuple_cost, extensions, updatable, truncatable, fetch_size, batch_size, async_capable, parallel_commit, keep_connections
> +HINT:  Valid options in this context are: service, passfile, channel_binding, connect_timeout, dbname, host, hostaddr, port, options, application_name, keepalives, keepalives_idle, keepalives_interval, keepalives_count, tcp_user_timeout, sslmode, sslcompression, sslcert, sslkey, sslcertmode, sslrootcert, sslcrl, sslcrldir, sslsni, requirepeer, require_auth, ssl_min_protocol_version, ssl_max_protocol_version, gssencmode, krbsrvname, gsslib, target_session_attrs, use_remote_estimate, fdw_startup_cost, fdw_tuple_cost, extensions, updatable, truncatable, fetch_size, batch_size, async_capable, parallel_commit, keep_connections

It's not strictly related to your patch, but maybe this hint has 
outlived its usefulness?  I mean, we don't list all available tables 
when you try to reference a table that doesn't exist.  And unordered on 
top of that.