Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1oF2PM-0004yZ-Sw
	for pgsql-hackers@arkaria.postgresql.org; Fri, 22 Jul 2022 23:50:12 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1oF2PJ-0000qW-Df
	for pgsql-hackers@arkaria.postgresql.org; Fri, 22 Jul 2022 23:50:09 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1oF2PI-0000qM-SB
	for pgsql-hackers@lists.postgresql.org; Fri, 22 Jul 2022 23:50:08 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1oF2PG-0000TC-DD
	for pgsql-hackers@postgresql.org; Fri, 22 Jul 2022 23:50:07 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 26MNo23B774727;
	Fri, 22 Jul 2022 19:50:02 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
cc: Andrew Dunstan <andrew@dunslane.net>,
 Justin Pryzby <pryzby@telsasoft.com>,
        pgsql-hackers@postgresql.org, Andres Freund <andres@anarazel.de>
Subject: Re: make -C libpq check fails obscurely if tap tests are disabled
In-reply-to: <754179.1658525051@sss.pgh.pa.us>
References: <20220722201945.wk22sn2evf4enztn@alvherre.pgsql>
 <748838.1658522443@sss.pgh.pa.us> <754179.1658525051@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Fri, 22 Jul 2022 17:24:11 -0400"
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----- =_aaaaaaaaaa0"
Content-ID: <774656.1658533773.0@sss.pgh.pa.us>
Date: Fri, 22 Jul 2022 19:50:02 -0400
Message-ID: <774726.1658533802@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/774726.1658533802%40sss.pgh.pa.us>
Precedence: bulk

------- =_aaaaaaaaaa0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <774656.1658533773.1@sss.pgh.pa.us>

I wrote:
> So it'll work in 3.81 (released 2006) and later, but not 3.80.

Confirmed that things are fine with 3.81.

> TBH my inclination here is to move our goalposts to say "we support
> gmake 3.81 and later".

Barring objections, I'll push the attached patch.  I suppose we
could undo whatever dumbing-down was done in _create_recursive_target,
but is it worth troubling with?

			regards, tom lane


------- =_aaaaaaaaaa0
Content-Type: text/x-diff; name="require-gmake-3.81.patch";
	charset="us-ascii"
Content-ID: <774656.1658533773.2@sss.pgh.pa.us>
Content-Description: require-gmake-3.81.patch
Content-Transfer-Encoding: quoted-printable

diff --git a/doc/src/sgml/installation.sgml b/doc/src/sgml/installation.sg=
ml
index 32e0d3fd9d..70d188e2bc 100644
--- a/doc/src/sgml/installation.sgml
+++ b/doc/src/sgml/installation.sgml
@@ -77,7 +77,7 @@ su - postgres
        <primary>make</primary>
       </indexterm>
 =

-      <acronym>GNU</acronym> <application>make</application> version 3.80=
 or newer is required; other
+      <acronym>GNU</acronym> <application>make</application> version 3.81=
 or newer is required; other
       <application>make</application> programs or older <acronym>GNU</acr=
onym> <application>make</application> versions will <emphasis>not</emphasi=
s> work.
       (<acronym>GNU</acronym> <application>make</application> is sometime=
s installed under
       the name <filename>gmake</filename>.)  To test for <acronym>GNU</ac=
ronym>
diff --git a/src/Makefile.global.in b/src/Makefile.global.in
index bb177a8162..0d766cfd15 100644
--- a/src/Makefile.global.in
+++ b/src/Makefile.global.in
@@ -872,11 +872,11 @@ install-strip:
 # allows parallel make across directories and lets make -k and -q work
 # correctly.
 =

-# We need the $(eval) function and order-only prerequisites, which are
-# available in GNU make 3.80.  That also happens to be the version
-# where the .VARIABLES variable was introduced, so this is a simple check=
.
-ifndef .VARIABLES
-$(error GNU make 3.80 or newer is required.  You are using version $(MAKE=
_VERSION))
+# We need the ability to export target-specific variables, which was
+# added in GNU make 3.81.  That also happens to be the version
+# where the .FEATURES variable was introduced, so this is a simple check.
+ifndef .FEATURES
+$(error GNU make 3.81 or newer is required.  You are using version $(MAKE=
_VERSION))
 endif
 =

 # This function is only for internal use below.  It should be called
@@ -884,7 +884,7 @@ endif
 # given subdirectory.  For the tree-wide all/install/check/installcheck c=
ases,
 # ensure we do our one-time tasks before recursing (see targets above).
 # Note that to avoid a nasty bug in make 3.80,
-# this function has to avoid using any complicated constructs (like
+# this function was written to not use any complicated constructs (like
 # multiple targets on a line) and also not contain any lines that expand
 # to more than about 200 bytes.  This is why we make it apply to just one
 # subdirectory at a time, rather than to a list of subdirectories.

------- =_aaaaaaaaaa0--