Subject: Re: popcount
To: David Fetter <david@fetter.org>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: John Naylor <john.naylor@enterprisedb.com>
References: <20201230105535.GJ13234@fetter.org>
 <5ea2932e-50f5-4a74-9550-5e3291b6652b@manitou-mail.org>
 <20201230164108.GK13234@fetter.org>
 <eb416bd3-9ee2-8a81-8cd4-d61baaf93ec2@enterprisedb.com>
 <20210111161354.GA8721@fetter.org>
 <e48355d3-efaf-e762-fffa-4b2191680292@enterprisedb.com>
 <338981.1610984050@sss.pgh.pa.us>
 <d33d668b-bf70-126d-9ca3-ad5a50488091@enterprisedb.com>
 <CA+Tgmoa18D-8FvtBE3-dJHDTX6A33OeAmRKa6R7+i8-E_o1G-w@mail.gmail.com>
 <20210119163818.GE8721@fetter.org>
 <CAMsGm5dKEDVJRN1qw=mz_mQPKR7=n9H5bVif--doWmePnVQ51Q@mail.gmail.com>
 <CALtqXTdTzdZoUSxNC7jS0TjEHJvdx=R2tN6DyNFbnumdDaoHjw@mail.gmail.com>
 <CAFBsxsF1q6BEa-NPkzQHFZ7D0GGxdM2uWDCYb-v08wPTmO9XOw@mail.gmail.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Message-ID: <775b91fc-80fa-179d-bb20-0bf230e6db40@enterprisedb.com>
Date: Sat, 20 Mar 2021 21:01:25 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0)
 Gecko/20100101 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: 
 <CAFBsxsF1q6BEa-NPkzQHFZ7D0GGxdM2uWDCYb-v08wPTmO9XOw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/775b91fc-80fa-179d-bb20-0bf230e6db40%40enterprisedb.com>
Precedence: bulk

On 18.03.21 13:51, John Naylor wrote:
> Hi David,
> 
> Just a nitpick:
> 
> +SET bytea_output TO hex;
> 
> Since we don't see the string in the output, I don't immediately see the 
> reason to change the output format here?
> 
> Aside from that, this patch works as expected, and is ready for committer.

I have now read the entire internet on what a suitable name for this 
function could be.  I think the emerging winner is BIT_COUNT(), which 
already exists in MySQL, and also in Python (int.bit_count()) and Java 
(Integer.bitCount()).