public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Bruce Momjian <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Peter Geoghegan <[email protected]>
Cc: Matthias van de Meent <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Preventing indirection for IndexPageGetOpaque for known-size page special areas
Date: Mon, 28 Nov 2022 19:48:54 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<CAEze2WiE=5bHDSSKX9RCZKqGLqz4F5OX5pQmUn5CpU88j470zg@mail.gmail.com>
	<CAEze2Wj9c0abW2aRbC8JzOuUdGurO5av6SJ2H83du6tM+Q1rHQ@mail.gmail.com>
	<CA+TgmoZGjCLvDxATQOgthcnYXjRQ-E_hE+QdHoisZCfVhg1VvA@mail.gmail.com>
	<CAEze2Wg0OxFFA96kf0PHNL9mbjYUBwnxhxFrOn-GudNiKq0aLA@mail.gmail.com>
	<CA+TgmoZf6GL4e=b5XKbNHQjXT4M0ewjBC91ZOrxLnhogY9Ha9w@mail.gmail.com>
	<CAH2-WzkqGMbc2bbm2zwoSpy2RpH0KSvhMcyD6qWewPUbBy8gdg@mail.gmail.com>
	<CA+TgmobQtf7hMNLtbPa9KUcsQ3oWquCL2OMzCcKPymTw8i1odg@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>

Michael Paquier <[email protected]> writes:
> I am wondering if it would be worth adding an AssertMacro() like in
> this one, though:
> https://www.postgresql.org/message-id/[email protected]

Kind of doubt it.  It'd bloat debug builds with a lot of redundant
checks, and probably never catch anything.  For catching problems
in production, the right place to do this (and where we already do
do it) is in _bt_checkpage.

If any of the other AMs lack page-read-time sanity checks like
_bt_checkpage, I'd be in favor of adding that.  But I don't
think a whole bunch of additional checks afterwards will buy much.

			regards, tom lane

view thread (23+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Preventing indirection for IndexPageGetOpaque for known-size page special areas
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox