Message-ID: <779eb1ce-c8aa-3dda-1830-5ad9a95089b2@enterprisedb.com>
Date: Fri, 19 May 2023 17:23:56 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: Memory leak from ExecutorState context?
Content-Language: en-US
To: Melanie Plageman <melanieplageman@gmail.com>,
 Jehan-Guillaume de Rorthais <jgdr@dalibo.com>
Cc: pgsql-hackers@lists.postgresql.org,
 Konstantin Knizhnik <knizhnik@garret.ru>,
 Thomas Munro <thomas.munro@gmail.com>
References: 
 <CAAKRu_ZxT9K9FuUCKV6SwZZnC9ExAiELa1oUYyiPk4eGHh12GQ@mail.gmail.com>
 <20230504193006.1b5b9622@karst> <20230508155648.lzddwywo6emote2b@liskov>
 <20230510142419.6185a492@karst>
 <f89c7c65-28f4-82a3-867c-a73e7ab3ccf0@enterprisedb.com>
 <20230516001502.21da48a6@karst>
 <3a18359e-5c78-3039-a0f4-ce1f34559d2e@enterprisedb.com>
 <20230516160051.4267a800@karst> <20230516200052.sbg6z4ghcmsas3wv@liskov>
 <20230517191008.7bee6aa7@karst> <20230517174635.3dsaufqn7y4gbb63@liskov>
 <20230518003529.7b439d00@karst>
 <CAAKRu_buPXM+93id3=yiBW9gCKOAu+DQwU1OHH4tb52jj9-A+A@mail.gmail.com>
From: Tomas Vondra <tomas.vondra@enterprisedb.com>
In-Reply-To: 
 <CAAKRu_buPXM+93id3=yiBW9gCKOAu+DQwU1OHH4tb52jj9-A+A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/779eb1ce-c8aa-3dda-1830-5ad9a95089b2%40enterprisedb.com>
Precedence: bulk

On 5/19/23 00:27, Melanie Plageman wrote:
> On Wed, May 17, 2023 at 6:35 PM Jehan-Guillaume de Rorthais
> <jgdr@dalibo.com> wrote:
>>
>> On Wed, 17 May 2023 13:46:35 -0400
>> Melanie Plageman <melanieplageman@gmail.com> wrote:
>>
>>> On Wed, May 17, 2023 at 07:10:08PM +0200, Jehan-Guillaume de Rorthais wrote:
>>>> On Tue, 16 May 2023 16:00:52 -0400
>>>> Melanie Plageman <melanieplageman@gmail.com> wrote:
>>>>> ...
>>>>> There are some existing indentation issues in these files, but you can
>>>>> leave those or put them in a separate commit.
>>>>
>>>> Reindented in v9.
>>>>
>>>> I put existing indentation issues in a separate commit to keep the actual
>>>> patches clean from distractions.
>>>
>>> It is a matter of opinion, but I tend to prefer the commit with the fix
>>> for the existing indentation issues to be first in the patch set.
>>
>> OK. moved in v10 patch set.
> 
> v10 LGTM.

Thanks!

I've pushed 0002 and 0003, after some general bikeshedding and minor
rewording (a bit audacious, admittedly).

I didn't push 0001, I don't think generally do separate pgindent patches
like this (I only run pgindent on large patches to ensure it doesn't
cause massive breakage, not separately like this, but YMMV).

Anyway, that's it for PG16. Let's see if we can do more in this area for
PG17.

regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company