Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tODyi-004wyh-3E for pgsql-hackers@arkaria.postgresql.org; Thu, 19 Dec 2024 10:42:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tODxj-00B3u1-8c for pgsql-hackers@arkaria.postgresql.org; Thu, 19 Dec 2024 10:40:58 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tODxi-00B3te-Un for pgsql-hackers@lists.postgresql.org; Thu, 19 Dec 2024 10:40:58 +0000 Received: from mail.postgrespro.ru ([93.174.131.139]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tODxf-000ZK3-9g for pgsql-hackers@postgresql.org; Thu, 19 Dec 2024 10:40:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mx2023; t=1734604855; bh=3m9/bGaSRExnrsfXFbQlYPDlQpSXdYd3fctjUwbXOkY=; h=Message-ID:Date:User-Agent:Subject:To:Cc:References:From: In-Reply-To:From; b=pTCYHGuOBx9f6TNRlICNcLx4SUVIys1rf7NlgMZzNEilEIHez03oru26sNYyOtyvl capDyhkNBl4pF8Cop0Bqkr+Sq06y3pt7G4xqbLgUuhsP47vUXN9KP+LvAO5XhojhoS qKMtVn95YC31fhSWri3XK+sayBWosD3sVOmYtvFUSqzXhFpXw2wZxwujyBAMVVy2Yk r+gE3ICaUXHUDrlZvi+VYTq10FSCosrdY8LCOdJGNHIe/EjnRPy9X1JI1HSqAs/Ka/ 2qzwfZiKOjZCnPgHptm7Mm37U3gA2LS1c5thCpZ6wxXqJrvgtM/ydogTENILaEZYpb U3VAlfTRglmgQ== Received: from [10.4.12.74] (unknown [93.174.131.141]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: a.rybakina@postgrespro.ru) by mail.postgrespro.ru (Postfix/587) with ESMTPSA id D847B6019B; Thu, 19 Dec 2024 13:40:54 +0300 (MSK) Message-ID: <77e6e723-0d3e-4235-8386-03d143916125@postgrespro.ru> Date: Thu, 19 Dec 2024 13:40:54 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Vacuum statistics To: Ilia Evdokimov Cc: Jim Nasby , Andrei Zubkov , Masahiko Sawada , Melanie Plageman , jian he , pgsql-hackers , a.lepikhov@postgrespro.ru, Alexander Korotkov References: <9b10c6d3-52c4-4eef-b67c-c33442667729@postgrespro.ru> <9485d892-fd04-4e3a-ac24-7dd767cb7333@postgrespro.ru> <0B6CBF4C-CC2A-4200-9126-CE3A390D938B@upgrade.com> <6732acf8ce0f31025b535ae1a64568750924a887.camel@moonset.ru> <5AA8FFD5-6DE2-4A31-8E00-AE98F738F5D1@upgrade.com> <85b963fe-5977-43aa-9241-75b862abcc69@postgrespro.ru> <9C7A167C-DCDE-4A17-9ABE-6276723FEC50@upgrade.com> <2d493cf9-9ba7-4cc1-a3f2-67afd7c163ee@postgrespro.ru> Content-Language: en-US From: Alena Rybakina In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-KSMG-AntiPhishing: NotDetected, bases: 2024/12/19 09:58:00 X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.1.0.7854, bases: 2024/12/19 06:47:00 #26889573 X-KSMG-AntiVirus-Status: NotDetected, skipped X-KSMG-LinksScanning: not scanned, disabled by settings X-KSMG-Message-Action: skipped X-KSMG-Rule-ID: 1 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi! On 02.12.2024 17:46, Ilia Evdokimov wrote: > In my opinion, the patches are semantically correct. However, not all > dead code has been removed - I'm referring to > pgstat_update_snapshot(). Also, the tests need to be fixed. > > I fixed it [0]. Thank you! [0] https://www.postgresql.org/message-id/86f76aa5-1ab5-4e2e-9b15-405051852a2a%40postgrespro.ru -- Regards, Alena Rybakina Postgres Professional