Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cw7PB-0004s7-1i for pgsql-hackers@arkaria.postgresql.org; Thu, 06 Apr 2017 13:24:53 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cw7PA-0004sp-BF for pgsql-hackers@arkaria.postgresql.org; Thu, 06 Apr 2017 13:24:52 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cw7P8-0004ql-Ko for pgsql-hackers@postgresql.org; Thu, 06 Apr 2017 13:24:50 +0000 Received: from mail.postgrespro.ru ([93.174.131.138]) by makus.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cw7P6-00075C-4T for pgsql-hackers@postgresql.org; Thu, 06 Apr 2017 13:24:49 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.postgrespro.ru (Postfix) with ESMTP id 4FC9C21C2731; Thu, 6 Apr 2017 16:24:46 +0300 (MSK) X-Virus-Scanned: Debian amavisd-new at postgrespro.ru Subject: Re: [PATCH] Generic type subscripting DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mail; t=1491485085; bh=Hb7PC4fknJ04MJIs3TAFcut77AR6rxeAbnbF6rYVnro=; h=To:References:Cc:From:Date:In-Reply-To; b=FluJYQVKaNvvU7XUetD6PVYFomWCKK4nCkxZUPaiU3TpvuFju+RMmL5ttYIHZob4j QKCXpqMkzum1hilDdJr7c3e4sMV0ZLcDe41wp+u9f/5kEIX5AIQ2nS8TfEi4SXjHMy Ip8LHHVRUxPY+/eFslakZ+Q407j+SBW05cP1I4c0= To: Dmitry Dolgov <9erthalion6@gmail.com> References: <20423.1489533013@sss.pgh.pa.us> <393cd0ae-5b84-849e-fc73-7077470a009e@pgmasters.net> <65df4a65-a9d8-3531-5baf-edb237771f0e@pgmasters.net> <22355.1490369372@sss.pgh.pa.us> <449f42b9-f338-9e45-cb33-3e15c7b547ad@postgrespro.ru> Cc: Tom Lane , David Steele , peter.eisentraut@2ndquadrant.com, PostgreSQL-development From: Arthur Zakirov Message-ID: <77f6449a-cc91-fee2-697f-5eacebfca0d7@postgrespro.ru> Date: Thu, 6 Apr 2017 16:24:33 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Pg-Spam-Score: -2.0 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On 05.04.2017 16:06, Arthur Zakirov wrote: > > I'd like to focus on "refevalfunc" and "refnestedfunc" fields as I did > earlier. I think using Oid type for them is a bad approach. "..._fetch" > and "..._assign" functions in catalog is unnecessary movement to me. > User of subscript of his type may think the same. But he won't see the > code and won't know why he needs these functions. > > And so "..._fetch" and "..._assign" functions in catalog is a bad design > to me. But, of course, it is just my opinion. This approach is the main > think which we should resolve first, because after commiting the patch > it will be hard to fix it. > I've read olders messages and thread. I see now that this approach was made with other hackers. I've just been confused when I've been implementing subscript for ltree. Sorry if I confused you. Any opinions about the patch? -- Arthur Zakirov Postgres Professional: http://www.postgrespro.com Russian Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers