From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
cc: Michael Paquier <michael.paquier@gmail.com>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Windows warnings from VS 2017
In-reply-to: <7cabcef8-c2eb-f7d1-e4a2-63b93115b75c@2ndQuadrant.com>
References: <f6488a36-4702-6d50-9fb4-fee10bb49497@2ndQuadrant.com>
 <CAB7nPqSS+FZkQ2s3d7O2Z-Ae3kcGcNq-XqTMm7Q19dR9TYng-A@mail.gmail.com>
 <7cabcef8-c2eb-f7d1-e4a2-63b93115b75c@2ndQuadrant.com>
Comments: In-reply-to Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
	message dated "Wed, 20 Sep 2017 18:49:10 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <7799.1505950322.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 20 Sep 2017 19:32:02 -0400
Message-ID: <7800.1505950322@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
> On 09/20/2017 06:13 PM, Michael Paquier wrote:
>> Those are around for some time, see here:
>> https://www.postgresql.org/message-id/CAB7nPqTkW=3Db_1JVvYWd_G0WrKOT+4uF=
QjGGrv8osQbUZzXGXdA@mail.gmail.com
>> But there has been no actual agreement about how to fix them..

> Oh. Missed that.

> My solution was going to be slightly different. I was going to enclose
> the #ifdef'd code in a bare block and move the rte declaration inside
> that block.

Of the various solutions proposed in the previous thread, I think the
most salable alternative is probably ilmari's: get rid of the variable
and write the assert like

   Assert(planner_rt_fetch(rel->relid, root)->rtekind =3D=3D RTE_SUBQUERY);

That's a pretty minimal change and it doesn't add any cycles to the
non-Assert case.

			regards, tom lane


--=20
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers