Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tDzyr-004Vqn-Ek for pgsql-hackers@arkaria.postgresql.org; Thu, 21 Nov 2024 05:43:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tDzyp-00CUoY-2j for pgsql-hackers@arkaria.postgresql.org; Thu, 21 Nov 2024 05:43:51 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tDzyo-00CUoI-O6 for pgsql-hackers@lists.postgresql.org; Thu, 21 Nov 2024 05:43:50 +0000 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1tDzyl-0033Th-Lc for pgsql-hackers@postgresql.org; Thu, 21 Nov 2024 05:43:49 +0000 Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-5cfa9979cd1so844939a12.1 for ; Wed, 20 Nov 2024 21:43:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cybertec.at; s=cybertec.at; t=1732167826; x=1732772626; darn=postgresql.org; h=message-id:date:content-id:mime-version:comments:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=miD+SEuWZmbpQ2797rBf10oHPTsMh74rgPFAKMU17C4=; b=XW2b0myVEa0nPkAUzeCMQxdESJXY8yR2DmEB4hlRhFpuI5MXeBNRVRzkDaTh5Cig1A 7p8BroQTghaj0x4J0HYe95qIeU4MB69HX2c/XVEFMRhNtLmuQMPATszlRiMfNUP4zbB/ AvOUOwsb7ZLgozWQloAvZECNyp0s+s8LbIsVA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732167826; x=1732772626; h=message-id:date:content-id:mime-version:comments:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=miD+SEuWZmbpQ2797rBf10oHPTsMh74rgPFAKMU17C4=; b=wnR7zA6GIHdmoOCCKIcW3uLR5tuHWTyFaldX9LWQTgWsUfk5O65t2DAyPIDDVAf99a +sIZjDg4JmmqfJQ2yNn21mr/0Po/8SxqspOg6ab3/i7x6XrqGQ4kXNHXO7Z73L8LvlNW 70eB9TAiPtHuLt3BN8yEGof/ypT8nH2pGk2QdaZqfZ83KQXft0kKC+6Kz4iVinrIv6fV 8SNP7GpeQpaARvdQJ84r4K9iGPJn6JLPXNYsVKdiwKuoQ6jcLzx2V6w1JxChAHUseuJD 7cWQzTd7nlI8SYQzYhncGaNrHJZNxnUkMBsnAdLI8lDJKxo4ypQPzbyfOvwaFRTZlQ4U jEpw== X-Forwarded-Encrypted: i=1; AJvYcCWlcyq9V5nkiwAhgAux1rrNgE2dDehwhkLRKNs4ryDDOJmgMCa0IxLAXXsw6qVtt7AJb8b+1G5dcrBGSxNZ@postgresql.org X-Gm-Message-State: AOJu0YzTya9cMGOpEI3sgi2P8WI7wYjAwo1wuUj30isZtkc6KOZV5r3C gZU0mYFx6HjK7XU57Tz6QduCbd7B7ST/VKop31lzOlmEAfpMrvUudLBjCZpmBBg= X-Google-Smtp-Source: AGHT+IGN8HmyUY2/mG7TrfT6RwOCa70gUxIuE1lPu9FVrEfmnF/iOScCpe/AE9Q5osTYGXOAk3dRMg== X-Received: by 2002:a05:6402:5254:b0:5cf:c198:e510 with SMTP id 4fb4d7f45d1cf-5d007c2f805mr1721669a12.1.1732167826630; Wed, 20 Nov 2024 21:43:46 -0800 (PST) Received: from antos (109-81-174-36.rct.o2.cz. [109.81.174.36]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5cff454e7d9sm1481408a12.76.2024.11.20.21.43.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Nov 2024 21:43:46 -0800 (PST) From: Antonin Houska To: Alvaro Herrera cc: Alexander Kukushkin , Sutou Kouhei , smithpb2250@gmail.com, torikoshia@oss.nttdata.com, horikyota.ntt@gmail.com, michael@paquier.xyz, pgsql-hackers@postgresql.org, bungina@gmail.com, pgsql-hackers@lists.postgresql.org Subject: Re: pg_rewind WAL segments deletion pitfall In-reply-to: <202411151222.7qbg5ujnrnxt@alvherre.pgsql> References: <202411151222.7qbg5ujnrnxt@alvherre.pgsql> Comments: In-reply-to Alvaro Herrera message dated "Fri, 15 Nov 2024 13:22:21 +0100." X-Mailer: MH-E 8.6+git; nmh 1.8; GNU Emacs 28.3 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <7820.1732167825.1@antos> Date: Thu, 21 Nov 2024 06:43:45 +0100 Message-ID: <7822.1732167825@antos> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Alvaro Herrera wrote: > Oh wow, thanks for noticing that. I had already rewritten the commit > message to some extent, but "master" had remained. Now I pushed the > patch to branches 14+, having replaced it as you suggested. When doing some unrelated work I noticed that in the new test 010_keep_recycled_wals.pl the server fails to reload the configuration file. The line it complains about is archive_command = '/usr/bin/perl -e 'exit(1)'' The test still succeeds for some reason. -- Antonin Houska Web: https://www.cybertec-postgresql.com