Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wd8PP-003uei-2A for pgsql-hackers@arkaria.postgresql.org; Fri, 26 Jun 2026 15:23:59 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wd8PO-00BiNl-1b for pgsql-hackers@arkaria.postgresql.org; Fri, 26 Jun 2026 15:23:58 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wd8PO-00BiNd-0Z for pgsql-hackers@lists.postgresql.org; Fri, 26 Jun 2026 15:23:58 +0000 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wd8PL-00000000NHo-2VaU for pgsql-hackers@lists.postgresql.org; Fri, 26 Jun 2026 15:23:57 +0000 Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-46e335379cbso691212f8f.0 for ; Fri, 26 Jun 2026 08:23:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cybertec.at; s=google; t=1782487434; x=1783092234; darn=lists.postgresql.org; h=message-id:date:content-id:mime-version:comments:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=kF8lVg5I25SA09Y8jKGiAPThhoNBHLtMvI/Hr09en7k=; b=IYqu0g9xvl0bEwQskR29w1t7sc2Aws/fKTHYvQ+8Os7Q5zE24SEML/+dfm5mg4K0YT /iqS+wLkrYQ/x9Rngvo8S6+N/HenPqCKv4tFw/kCCdcxNvjPEl/aCbjfSFfvFH7gMc+s SMLJITciIJC2iKDCcpxEfrphQBThgkl8M/8OxNRdBLoxIrUd5Iyeg34xOl1N71e+Tug2 6TSmsNNOnYQChoG6AHxMkDDf1juiZD7d/sDxUwIO6MRaFTCxP2CUHnEvalAnET9pUFfG CCGmsp1Toirg6dZzo/ArelNXlPg4JUdk8yyxwchzLzaW9wJGGz5QWbUi1HQ9UamFtLB2 9EWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782487434; x=1783092234; h=message-id:date:content-id:mime-version:comments:references :in-reply-to:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=kF8lVg5I25SA09Y8jKGiAPThhoNBHLtMvI/Hr09en7k=; b=stExPv1CAJStqfXdKmxMpQxB8zgYUJzUPmQNJX6Ih4K5pIvFldvYHw+kO1A9uSfb/z ltj4kx6iAGvLA+xZrsbdyv5qDGAnizDDeX2a5BxnxdbfCRlwfpch2kzgxy6wgEyHKkrH BuzB7/1JqNSN1l0Nl3TaNExdZ7Y4eYTZqTm13yMS3McG+ejf7I6aKxbhECVL66742MsR g28ubNm9GSWicn8YG2TVRfdf9mYBSa8FPCgYs0bm8pdn+66Lt8eHByQTbPDt0F/tuKnL J/w4QvY7E4/sK3GQ0rV12sGVKzf1QnebFTiUTSMB8kn20+Sehsv9cAf+mEz0nOBE3iOA Ug+w== X-Gm-Message-State: AOJu0YyBHZBeI3/hhx5sY+o7ntDu+p2mSBhgQ93DYEe6vzHbyMSSrbBl gHQtWrieiGBDjtCL1/EJ1ZNVuqge1DE1lMx2i70HA7i7ijnHBHpvIxf8uoDNezEnPUcZrrVzJyj pRav9ook= X-Gm-Gg: AfdE7cn6N2Oi3uoPZWtWYphc6uQkDQTxohXNnOfwgp7nOSPnImORLQSXMi39M15GUuk xsqJp4SmGOjdkRJpQbpIDMpFwkZj3EJn9FGUiC8jR3yo3w0Sb3lgyU1t2g+Helv++ihBUXu/ATC ndbideq5LC9tmSGQIISgxh7+do4NUl9NGyxXZ/oI470TCclDZwqnaAy3rTW6OQmuEIyQS169QBN s4Zucrg7ms/gr6FhKr40N9TUC2rrocXNmw86FJ6pNpU3kwp0yj1Dngu6ic3KvHV8MI4+5s+C1Qd eZGjS1eFAf8lvE8htD1NxdVygXbQ+dXdHvDsAj1NOHn/CrxqxCzPrSRAP/OpAa3IBipJyTWWbPG bvMykZu6rVSmuypDq6dcTEIQJmCFnajBJTWRopIRPyddc+nMQX/iOcDxS+fO7g7mcz3IFoC21YZ WzUGGquCCnS61QnnWAQHY+DC66/Q== X-Received: by 2002:a05:6000:4688:b0:46d:d5f9:d655 with SMTP id ffacd0b85a97d-46dd5f9da1cmr9203542f8f.11.1782487433856; Fri, 26 Jun 2026 08:23:53 -0700 (PDT) Received: from localhost (109-81-168-148.rct.o2.cz. [109.81.168.148]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-46c2279b734sm27163196f8f.30.2026.06.26.08.23.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2026 08:23:53 -0700 (PDT) From: Antonin Houska To: Adam Lee cc: pgsql-hackers@lists.postgresql.org, alvherre@kurilemu.de Subject: Re: CLUSTER progress: wrong index_rebuild_count for tables with TOAST In-reply-to: References: Comments: In-reply-to Adam Lee message dated "Fri, 26 Jun 2026 14:45:57 +0800." X-Mailer: MH-E 8.6+git; nmh 1.8; GNU Emacs 28.3 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <78276.1782487433.1@localhost> Date: Fri, 26 Jun 2026 17:23:53 +0200 Message-ID: <78277.1782487433@localhost> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Adam Lee wrote: > The reason is that make_new_heap() creates the new TOAST table, and its > TOAST index, before the heap is scanned. Building that index reports > CREATE INDEX progress. CREATE INDEX and the cluster command use the same > progress field for different things, so the cluster command then shows a > CREATE INDEX value as its index_rebuild_count. I'd prefer enhanced progress monitoring that I proposed earlier [1]. The patch needs more work, I'll try to submit it for the next development cycle. [1] https://www.postgresql.org/message-id/30939.1777888333%40localhost -- Antonin Houska Web: https://www.cybertec-postgresql.com