Subject: Re: improvements in Unicode tables generation code
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: pgsql-hackers <pgsql-hackers@postgresql.org>
References: <22016aa9-ca59-15c7-01df-f292cb558c4d@enterprisedb.com>
 <f77d3a96-f2bf-662a-4a98-7ed7a9dc45fa@iki.fi>
 <294cd3ee-7988-9ce2-87e2-5acaac8db01c@enterprisedb.com>
 <18e34084-aab1-1b4c-edd1-c4f9fb04f714@enterprisedb.com>
 <e6baa40f-a40f-564f-9b45-9ad63bf01f2d@enterprisedb.com>
Message-ID: <7834d9de-8f42-9c07-b387-d681e4aa2a03@enterprisedb.com>
Date: Mon, 4 Oct 2021 20:36:32 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <e6baa40f-a40f-564f-9b45-9ad63bf01f2d@enterprisedb.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/7834d9de-8f42-9c07-b387-d681e4aa2a03%40enterprisedb.com>
Precedence: bulk


On 28.09.21 10:25, Peter Eisentraut wrote:
> 
> On 20.07.21 13:57, Peter Eisentraut wrote:
>>>> Perhaps we should change the script or Makefile so that it doesn't 
>>>> create all the maps in one go?
>>>
>>> I agree, either comment it better or just write one file at a time. 
>>> I'll take another look at that.
>>
>> Here is a patch that does it one file (pair) at a time.  The other 
>> rules besides UCS_to_most.pl actually had the same problem, since they 
>> produce two output files, so running in parallel called each script 
>> twice.  In this patch, all of that is heavily refactored and works 
>> correctly now. Note that UCS_to_most.pl already accepted a 
>> command-line argument to specify which encoding to work with.
> 
> Here is an updated patch with a thinko fix that made the previous patch 
> not actually work.

I have committed this one and closed the CF entry.