Content-Type: multipart/alternative;
 boundary="------------TW6cUOisIe7OMIna37HbcUh9"
Message-ID: <78394e29-a900-4af4-b5ce-d6eb2d263fad@postgrespro.ru>
Date: Wed, 21 Aug 2024 01:37:16 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Vacuum statistics
To: jian he <jian.universality@gmail.com>
Cc: Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>,
 Andrei Zubkov <zubkov@moonset.ru>, Alena Rybakina
 <lena.ribackina@yandex.ru>, pgsql-hackers <pgsql-hackers@postgresql.org>,
 a.lepikhov@postgrespro.ru
References: <bee34abe-fe87-49b3-8523-8ae19e641ccf@yandex.ru>
 <ff99283d-f9d4-4b37-b4fa-3a433fb408a4@tantorlabs.com>
 <e1f5b560691a4fe693625d529e19e13959210568.camel@moonset.ru>
 <53c47c2d-72a5-44f2-900c-9973b2af1808@tantorlabs.com>
 <c82e7776-7841-42a0-9247-878584174750@tantorlabs.com>
 <4a902cea-54fb-41b5-b208-b84731a5f577@postgrespro.ru>
 <CACJufxHb_YGCp=pVH6DZcpk9yML+SueffPeaRbX2LzXZVahd_w@mail.gmail.com>
 <CACJufxE6yAP+jUm4_GyKp7gUCkzbuJ9HGB-rR=92_hcLLZ9KTg@mail.gmail.com>
Content-Language: en-US
From: Alena Rybakina <a.rybakina@postgrespro.ru>
In-Reply-To: <CACJufxE6yAP+jUm4_GyKp7gUCkzbuJ9HGB-rR=92_hcLLZ9KTg@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/78394e29-a900-4af4-b5ce-d6eb2d263fad%40postgrespro.ru>
Precedence: bulk

This is a multi-part message in MIME format.
--------------TW6cUOisIe7OMIna37HbcUh9
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

We check it there: "tabentry->vacuum_ext.type != type". Or were you 
talking about something else?

On 19.08.2024 12:32, jian he wrote:
> in pg_stats_vacuum
>      if (type == PGSTAT_EXTVAC_INDEX || type == PGSTAT_EXTVAC_HEAP)
>      {
>          Oid                    relid = PG_GETARG_OID(1);
>
>          /* Load table statistics for specified database. */
>          if (OidIsValid(relid))
>          {
>              tabentry = fetch_dbstat_tabentry(dbid, relid);
>              if (tabentry == NULL || tabentry->vacuum_ext.type != type)
>                  /* Table don't exists or isn't an heap relation. */
>                  PG_RETURN_NULL();
>
>              tuplestore_put_for_relation(relid, rsinfo, tabentry);
>          }
>          else
>          {
>         }
>
>
> So for functions pg_stat_vacuum_indexes and pg_stat_vacuum_tables,
> it seems you didn't check "relid" 's relkind,
> you may need to use get_rel_relkind.

-- 
Regards,
Alena Rybakina
Postgres Professional:http://www.postgrespro.com
The Russian Postgres Company

--------------TW6cUOisIe7OMIna37HbcUh9
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 7bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p>We check it there: "<span style="white-space: pre-wrap">tabentry-&gt;vacuum_ext.type != type". Or were you talking about something else?</span></p>
    <p></p>
    <div class="moz-cite-prefix">On 19.08.2024 12:32, jian he wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:CACJufxE6yAP+jUm4_GyKp7gUCkzbuJ9HGB-rR=92_hcLLZ9KTg@mail.gmail.com">
      <pre class="moz-quote-pre" wrap="">in pg_stats_vacuum
    if (type == PGSTAT_EXTVAC_INDEX || type == PGSTAT_EXTVAC_HEAP)
    {
        Oid                    relid = PG_GETARG_OID(1);

        /* Load table statistics for specified database. */
        if (OidIsValid(relid))
        {
            tabentry = fetch_dbstat_tabentry(dbid, relid);
            if (tabentry == NULL || tabentry-&gt;vacuum_ext.type != type)
                /* Table don't exists or isn't an heap relation. */
                PG_RETURN_NULL();

            tuplestore_put_for_relation(relid, rsinfo, tabentry);
        }
        else
        {
       }


So for functions pg_stat_vacuum_indexes and pg_stat_vacuum_tables,
it seems you didn't check "relid" 's relkind,
you may need to use get_rel_relkind.
</pre>
    </blockquote>
    <pre class="moz-signature" cols="72">-- 
Regards,
Alena Rybakina
Postgres Professional: <a class="moz-txt-link-freetext" href="http://www.postgrespro.com">http://www.postgrespro.com</a>
The Russian Postgres Company</pre>
  </body>
</html>

--------------TW6cUOisIe7OMIna37HbcUh9--