public inbox for [email protected]  

help / color / mirror / Atom feed

From: Heikki Linnakangas <[email protected]>
To: Andres Freund <[email protected]>
To: vignesh C <[email protected]>
Cc: [email protected]
Cc: Thomas Munro <[email protected]>
Cc: Melanie Plageman <[email protected]>
Cc: Yura Sokolov <[email protected]>
Cc: Robert Haas <[email protected]>
Subject: Re: refactoring relation extension and BufferAlloc(), faster COPY
Date: Tue, 21 Feb 2023 17:40:31 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<CALDaNm3prG-F9DS2G8od9QyrE5HefMvmk5oqvEs64n+tPbkd8g@mail.gmail.com>
	<[email protected]>

> v2-0006-bufmgr-Support-multiple-in-progress-IOs-by-using-.patch

This looks straightforward. My only concern is that it changes the order 
that things happen at abort. Currently, AbortBufferIO() is called very 
early in AbortTransaction(), and this patch moves it much later. I don't 
see any immediate problems from that, but it feels scary.


> @@ -2689,7 +2685,6 @@ InitBufferPoolAccess(void)
>  static void
>  AtProcExit_Buffers(int code, Datum arg)
>  {
> -	AbortBufferIO();
>  	UnlockBuffers();
>  
>  	CheckForBufferLeaks();

Hmm, do we call AbortTransaction() and ResourceOwnerRelease() on 
elog(FATAL)? Do we need to worry about that?

- Heikki

view thread (3+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: refactoring relation extension and BufferAlloc(), faster COPY
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox