Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1ea2YG-00060Q-7k
	for pgsql-hackers@arkaria.postgresql.org; Fri, 12 Jan 2018 16:51:32 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1ea2YF-0002nz-1n
	for pgsql-hackers@arkaria.postgresql.org; Fri, 12 Jan 2018 16:51:31 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <peter.eisentraut@2ndquadrant.com>)
	id 1ea2YE-0002no-Em
	for pgsql-hackers@lists.postgresql.org; Fri, 12 Jan 2018 16:51:30 +0000
Received: from out3-smtp.messagingengine.com ([66.111.4.27])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <peter.eisentraut@2ndquadrant.com>)
	id 1ea2YB-00089U-2X
	for pgsql-hackers@postgresql.org; Fri, 12 Jan 2018 16:51:28 +0000
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47])
	by mailout.nyi.internal (Postfix) with ESMTP id CD8ED20A8C;
	Fri, 12 Jan 2018 11:51:25 -0500 (EST)
Received: from frontend1 ([10.202.2.160])
  by compute7.internal (MEProxy); Fri, 12 Jan 2018 11:51:25 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:content-transfer-encoding:content-type
	:date:from:in-reply-to:message-id:mime-version:references
	:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=prpqwa
	3ukR8S1mSOmB7uvBhkQWIjmHoB4OLNrrVjvng=; b=fH55K77/xY7BPjR8rxAGGl
	4KEbXSjkFlgAWovMhvrRsPXSlOgAoiqf0qDQlfmxaa+k3fxLcOJf7Ij6LR27godJ
	c6o64cODXAUqH2LO7L0TsmhvNItypu8yDbQ7N8zI3bomRWP8o5pq+sHt1JTr5yBP
	f98XBwgYrcBJ5iJODyQdxFmNCTES8m5k9TUh2uoW1saW4kZlu8XQ7fDtJg+uGMk2
	IRnsZQ/a7Oct7RjeAvi5GMR9cCRehB/pfpbsx84FJCOpNgovCieN0/W/izzz6DOp
	6UQIiLQrZgYuexcj7iNUOBgL/KEvKqgOVxxhUHMLkNo4XWOk0kQ/qMYo2udMPUoA
	==
X-ME-Sender: <xms:jedYWjLnlzXKNtF-5FXCz0szE8oEwKjRr5XE3dhwNGMiz3NiXPs-6g>
Received: from april.local (c-73-13-66-39.hsd1.pa.comcast.net [73.13.66.39])
	by mail.messagingengine.com (Postfix) with ESMTPA id 649DE7E3D4;
	Fri, 12 Jan 2018 11:51:25 -0500 (EST)
Subject: Re: [HACKERS] Proposal: Local indexes for partitioned table
To: Alvaro Herrera <alvherre@alvh.no-ip.org>,
 David Rowley <david.rowley@2ndquadrant.com>
References: <20180111185207.lrde2jlvvhsbyntd@alvherre.pgsql>
Cc: Robert Haas <robertmhaas@gmail.com>,
 Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>,
 Jesper Pedersen <jesper.pedersen@redhat.com>,
 Simon Riggs <simon@2ndquadrant.com>,
 Pg Hackers <pgsql-hackers@postgresql.org>,
 Maksim Milyutin <milyutinma@gmail.com>,
 Jaime Casanova <jaime.casanova@2ndquadrant.com>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <7861b08a-4c59-8440-4fa9-7771de22c927@2ndquadrant.com>
Date: Fri, 12 Jan 2018 11:51:24 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0)
 Gecko/20100101 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <20180111185207.lrde2jlvvhsbyntd@alvherre.pgsql>
Content-Type: text/plain; charset=windows-1252
Content-Language: en-US
Content-Transfer-Encoding: 7bit
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

On 1/11/18 13:52, Alvaro Herrera wrote:
> The delta patch turned out to have at least one stupid bug, and a few
> non-stupid bugs.  Here's an updated version that should behave
> correctly, and addresses all reported problems.

It seems that CompareIndexInfo() still doesn't compare indexes' operator
classes and collations.

Also, some new test cases for pg_dump would be nice.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services