Content-Type: multipart/alternative;
 boundary="------------xz3YH1noITJIPEbFGp4EwFZT"
Message-ID: <786bceca-84c4-4a83-9c30-3ce49d81b274@dunslane.net>
Date: Tue, 14 Apr 2026 18:52:04 -0400
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: pg_get__*_ddl consolidation
To: SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>,
 Jeff Davis <pgsql@j-davis.com>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>,
 Japin Li <japinli@hotmail.com>, Zsolt Parragi <zsolt.parragi@percona.com>,
 Euler Taveira <euler@eulerto.com>, =?UTF-8?Q?=C3=81lvaro_Herrera?=
 <alvherre@kurilemu.de>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <202603201311.yhtqmvektawm@alvherre.pgsql>
 <bf49721a-a56f-4bdc-ac48-5d4dc1d01805@dunslane.net>
 <8ec9b67d-939e-4b22-8d56-a5129f92d32d@app.fastmail.com>
 <CAN4CZFNYM5jNA_gLu9miAXg_7c8Z2zf-ePc+0rzidAV3CBs=cw@mail.gmail.com>
 <555cdee4-c024-4872-9d96-82ef4216239c@dunslane.net>
 <SY7PR01MB10921A6E1E08A48F3426FE529B651A@SY7PR01MB10921.ausprd01.prod.outlook.com>
 <CAKFQuwYcppypeGBwa7ZbDAfoUXSv+kLhJuAXsdwBmKrvy8wDFw@mail.gmail.com>
 <a533fb1b-0f2c-4fc9-ab3b-6fb5ddac1800@dunslane.net>
 <a1c4dd3e-6694-4b7b-8432-f3b584735ff3@dunslane.net>
 <4efc426cde8eed9734af3a4552c3be29188f3661.camel@j-davis.com>
 <CAHg+QDdWtv9PKtPZEokwGCNtbv4MVnfYw5wMZrsEj4xizSNe5Q@mail.gmail.com>
From: Andrew Dunstan <andrew@dunslane.net>
Content-Language: en-US
Autocrypt: addr=andrew@dunslane.net; keydata=
 xsBNBE7KWFkBCAClridxur2AIc7eW2AR7izbfp3EnNefie2HbLF0izW5Ik5UjX2HBXBx4syI
 gY6b0ugohXrr274+baoAlvSbq6cAoQuEVrk5IZFzt20b1Xkx65FwGSEj526yiKLocqkJceSq
 Xr9xcA5SGY+FZv441chh5SU92v4q6z+6LPpoHOh97ptAVXZYNTtU0LevyvD5lja0TzbvJm6C
 eFXitJfnm1pLEr0DGJCR/iUOl/N62Kh4855zZC7NHIjQHPOvV5Stz/l5ilDhvGVk+xkXFPys
 SjZoUr1rXhYLpiyi5sR0X9FHXT0KnGuz1F5ERO7ZTLSSQ6fJwPj6gOk9K+vvoKvoeql5ABEB
 AAHNJEFuZHJldyBEdW5zdGFuIDxhbmRyZXdAZHVuc2xhbmUubmV0PsLAlwQTAQgAQQIbAwIX
 gAIZAQULCQgHAwUVCgkICwUWAgMBAAIeBRYhBOQ+WEYd/Hy/RGkVpZn6f8tZ/DuBBQJoGNGd
 BQkdEO8nAAoJEJn6f8tZ/DuBq74H/jkTR4Zi3stbw+xC7v2u3QozssK7MYPL2AsVfh7OealS
 h182fiWXpfvmmAB7WUHbhk9GC2RAOnHI/2d2jgKaMLAHsGYOT0YopTVIwRY43fCw/mK67yxc
 wmDcX+zyKfLaivNbf5A7QPLNwda98bEAMSJ8Sn652Uc6cA8t3uKGsVzbRBQOoYzjgvBCfSrE
 9ql3PDNg0l4BfAqabd2f70ZUm9VAMEPrgv/v2xI7M2XiL4g5BVmqLCOwxLM8RMCotCuoweUr
 VO43DeBCIDwLxotMJKvGWDjBzQYlU1NPUAtNcz/gN9ITUe1VUGjyvGj4u1lxBOcQQUw7l1+T
 5moZ4iZxXzvOwE0ETspYWQEIANGc4zQULOxhbqO2dyD51YhqCNRmm9oKWaqf+wmW4tpDe/VV
 cxAnNizd4LWCHfzpb5cHAtGkOPePMfzWVf6nvdF7d3eglbtf59+zG7O7llV0xSSoFiieQBsr
 GvqDInXYX/4mRRXMtyhM353/tixC9RWLs1oofyYmCPPXXY7h9R7en3B8BoVrRFcdzlIY/NFN
 hFGW/9dkEiGjgna2Rk6e15kln4ZvFBWUg23p93w/pqXcxY6+k/8TEk+C4R+M6w7o2PLGOjdZ
 +kPiUcw5H85zf/yZJwQXzisXaNduwWB6Vads9YC9dj6kPR1c4VGRqAaYL++LAEOqrlvm2Tvq
 QqZRtnEAEQEAAcLAfAQYAQgAJgIbDBYhBOQ+WEYd/Hy/RGkVpZn6f8tZ/DuBBQJoGNI2BQkd
 EODdAAoJEJn6f8tZ/DuBfw0IAKTsfD40teP/pp+bsLLMSxPXUYrrprTj7WFB5v61p6dkpSr/
 qXmMlyahdxQFaPmfVgVirB1Vk/kHiWNnnGjfUV9nB2Zg9LI0Xb9/ts3LsUiRWXzG3tkMY6XL
 vsVOxW4XFRND9l2q+WW93aZ1DZl+fqWfYgMvsusFRhmGFOKTRfKPta2Pkv+AhA24N4+PrR5p
 bU4k2MO8PAGiK8eaYKGFG1bHKuAvoDoF7WXJ3FHxuWqLnKEt4dfOLm5pAe3zq1Lt6q8azT9i
 QWGpSAK5vQUWQHBHpiDjdPeqKZ6HiAXIIKfSmb+jrvXBqoP+D6/K7rUjG2aXiRtTIAXms9sm
 VRu7cmw=
In-Reply-To: 
 <CAHg+QDdWtv9PKtPZEokwGCNtbv4MVnfYw5wMZrsEj4xizSNe5Q@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/786bceca-84c4-4a83-9c30-3ce49d81b274%40dunslane.net>
Precedence: bulk

This is a multi-part message in MIME format.
--------------xz3YH1noITJIPEbFGp4EwFZT
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit


On 2026-04-13 Mo 3:41 PM, SATYANARAYANA NARLAPURAM wrote:
> Hi,
>
> On Fri, Apr 10, 2026 at 1:03 PM Jeff Davis <pgsql@j-davis.com> wrote:
>
>     On Sun, 2026-04-05 at 11:06 -0400, Andrew Dunstan wrote:
>     > Pushed. I have moved the remaining get_*_ddl items to PG20-1
>
>     The line:
>
>       role_settings = DatumGetArrayTypeP(datum);
>
>     should be DatumGetArrayTypePCopy(), because it's being pfree()d later.
>     The existing code will sometimes make a copy and sometimes not, e.g.:
>
>       -- settings are contrived to make the datum inline
>       CREATE USER u1;
>       ALTER ROLE u1 SET search_path = 'public, pg_catalog, pg_temp';
>       ALTER ROLE u1 SET work_mem='64MB';
>       ALTER ROLE u1 SET statement_timeout='30s';
>       ALTER ROLE u1 SET lock_timeout='10s';
>       ALTER ROLE u1 SET idle_in_transaction_session_timeout = '60s';
>       SELECT pg_get_role_ddl('u1');
>       ERROR:  pfree called with invalid pointer 0x7986dd0c7cc8 (header
>     0x0000400600000000)
>
>
> Yes, it appears to be a bug. Attached a patch to fix this. Tested with 
> the
> attached patch and don't see server crashing after that.
>
>

Thanks, pushed.


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

--------------xz3YH1noITJIPEbFGp4EwFZT
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p><br>
    </p>
    <div class="moz-cite-prefix">On 2026-04-13 Mo 3:41 PM, SATYANARAYANA
      NARLAPURAM wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:CAHg+QDdWtv9PKtPZEokwGCNtbv4MVnfYw5wMZrsEj4xizSNe5Q@mail.gmail.com">
      <meta http-equiv="content-type" content="text/html; charset=UTF-8">
      <div dir="ltr">
        <div dir="ltr">Hi,</div>
        <br>
        <div class="gmail_quote gmail_quote_container">
          <div dir="ltr" class="gmail_attr">On Fri, Apr 10, 2026 at
            1:03 PM Jeff Davis &lt;<a href="mailto:pgsql@j-davis.com"
              moz-do-not-send="true" class="moz-txt-link-freetext">pgsql@j-davis.com</a>&gt;
            wrote:<br>
          </div>
          <blockquote class="gmail_quote"
style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On
            Sun, 2026-04-05 at 11:06 -0400, Andrew Dunstan wrote:<br>
            &gt; Pushed. I have moved the remaining get_*_ddl items to
            PG20-1<br>
            <br>
            The line:<br>
            <br>
              role_settings = DatumGetArrayTypeP(datum);<br>
            <br>
            should be DatumGetArrayTypePCopy(), because it's being
            pfree()d later.<br>
            The existing code will sometimes make a copy and sometimes
            not, e.g.:<br>
            <br>
              -- settings are contrived to make the datum inline<br>
              CREATE USER u1;<br>
              ALTER ROLE u1 SET search_path = 'public, pg_catalog,
            pg_temp';<br>
              ALTER ROLE u1 SET work_mem='64MB';<br>
              ALTER ROLE u1 SET statement_timeout='30s';<br>
              ALTER ROLE u1 SET lock_timeout='10s';<br>
              ALTER ROLE u1 SET idle_in_transaction_session_timeout =
            '60s';<br>
              SELECT pg_get_role_ddl('u1');<br>
              ERROR:  pfree called with invalid pointer 0x7986dd0c7cc8
            (header<br>
            0x0000400600000000)<br>
          </blockquote>
          <div><br>
          </div>
          <div>Yes, it appears to be a bug. Attached a patch to fix
            this. Tested with the </div>
          <div>attached patch and don't see server crashing after that.</div>
          <div><br>
          </div>
          <br>
        </div>
      </div>
    </blockquote>
    <p><br>
    </p>
    <p>Thanks, pushed.</p>
    <p><br>
    </p>
    <p>cheers</p>
    <p><br>
    </p>
    <p>andrew<br>
    </p>
    <pre class="moz-signature"
    signature-switch-id="d0437855-2267-4610-80b3-83167ec45b0b" cols="72">--
Andrew Dunstan
EDB: <a class="moz-txt-link-freetext" href="https://www.enterprisedb.com">https://www.enterprisedb.com</a>
</pre>
  </body>
</html>

--------------xz3YH1noITJIPEbFGp4EwFZT--