From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
cc: Robert Haas <robertmhaas@gmail.com>,
        Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: postgres_fdw hint messages
In-reply-to: <20220901223128.GA932597@nathanxps13>
References: <b1f9f399-3a1a-b554-283f-4ae7f34608e2@enterprisedb.com>
 <CA+TgmoY+BuSZm-Fbxx5zC6SuML=2F9YvaYuzVAJ=XyE65BnchQ@mail.gmail.com>
 <1929340.1661531738@sss.pgh.pa.us> <20220901223128.GA932597@nathanxps13>
Comments: In-reply-to Nathan Bossart <nathandbossart@gmail.com>
	message dated "Thu, 01 Sep 2022 15:31:28 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <789101.1662073729.1@sss.pgh.pa.us>
Date: Thu, 01 Sep 2022 19:08:49 -0400
Message-ID: <789102.1662073729@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/789102.1662073729%40sss.pgh.pa.us>
Precedence: bulk

Nathan Bossart <nathandbossart@gmail.com> writes:
> On Fri, Aug 26, 2022 at 12:35:38PM -0400, Tom Lane wrote:
>> I vote for just dropping all these hints for now, while leaving the
>> door open for anyone who wants to write closest-match-offering code.

> Here is a quickly-hacked-together proof-of-concept for using Levenshtein
> distances to determine which option to include in the hint.  Would
> something like this suffice?  If so, I will work on polishing it up a bit.

Seems reasonable to me, but

(1) there probably needs to be some threshold of closeness, so we don't
offer "foobar" when the user wrote "huh"

(2) there are several places doing this now, and there will no doubt
be more later, so we need to try to abstract the logic so it can be
shared.

			regards, tom lane