public inbox for [email protected]
help / color / mirror / Atom feedFrom: Peter Eisentraut <[email protected]>
To: Melanie Plageman <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Pg Hackers <[email protected]>
Subject: Re: heapgettup refactoring
Date: Wed, 18 Jan 2023 12:04:15 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAAKRu_Ydy7p0_bdm=sTmoGyWKd7Wznbo_=5BzUDJLrZnzBUf1Q@mail.gmail.com>
References: <CAAKRu_YSOnhKsDyFcqJsKtBSrd32DP-jjXmv7hL0BPD-z0TGXQ@mail.gmail.com>
<[email protected]>
<CAAKRu_ZJg_N7zHtWP+JoSY_hrce4+GKioL137Y2c2En-kuXQ7g@mail.gmail.com>
<[email protected]>
<CAAKRu_bWPFT8ZX5pTw0nm_rpBrivSjB3wMntqnHNDwJAV1LdsA@mail.gmail.com>
<[email protected]>
<CAAKRu_ZjbE6v4S7+R7q=RBSBj7dV5u4Y2v5MNFE5oVm1m-9D=A@mail.gmail.com>
<[email protected]>
<CAAKRu_Ydy7p0_bdm=sTmoGyWKd7Wznbo_=5BzUDJLrZnzBUf1Q@mail.gmail.com>
On 10.01.23 21:31, Melanie Plageman wrote:
> On Thu, Jan 5, 2023 at 8:52 AM Peter Eisentraut
> <[email protected]> wrote:
>>
>> Ok, let's look through these patches starting from the top then.
>>
>> v4-0001-Add-no-movement-scan-helper.patch
>>
>> This makes sense overall; there is clearly some duplicate code that can
>> be unified.
>>
>> It appears that during your rebasing you have effectively reverted your
>> earlier changes that have been committed as
>> 8e1db29cdbbd218ab6ba53eea56624553c3bef8c. You should undo that.
>
> Thanks. I think I have addressed this.
> I've attached a rebased v5.
In your v2 patch, you remove these assertions:
- /* check that rs_cindex is in sync */
- Assert(scan->rs_cindex < scan->rs_ntuples);
- Assert(lineoff == scan->rs_vistuples[scan->rs_cindex]);
Is that intentional?
I don't see any explanation, or some other equivalent code appearing
elsewhere to replace this.
view thread (3+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: heapgettup refactoring
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox