MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Wed, 22 Apr 2020 18:01:23 +0200
From: Erik Rijkers <er@xs4all.nl>
To: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Kuntal Ghosh <kuntalghosh.2007@gmail.com>, Tomas Vondra
 <tomas.vondra@2ndquadrant.com>, Amit Kapila <amit.kapila16@gmail.com>,
 Michael Paquier <michael@paquier.xyz>, Peter Eisentraut
 <peter.eisentraut@2ndquadrant.com>, PostgreSQL Hackers
 <pgsql-hackers@postgresql.org>
Subject: Re: PATCH: logical_work_mem and logical streaming of large
 in-progress transactions
In-Reply-To: 
 <CAFiTN-tE7FNneDfPURWn_d5902WsrbWi_fZoXNjTx+5Fp+OxXw@mail.gmail.com>
References: 
 <CAFiTN-sn0Bd4Q72Cn9t8-mZp1sxWRv2SmUoeR_7J05SqNTR--g@mail.gmail.com>
 <CAA4eK1KyrP6m53FQV5v0gysEnaTHPdc2xYT0KeNN+fhOcedRwA@mail.gmail.com>
 <CAFiTN-uBd3p50s=kfEiSbg93_Fnf_VU+haS4FqBZAm7PmbX69g@mail.gmail.com>
 <CAA4eK1LkLU5frY4kZGO38d8m6R504H+GbfkwsQLAp7sQ-4oqbw@mail.gmail.com>
 <20200329005905.ooxq25qyjwn2mvxz@development>
 <CAA4eK1LvUDNaCJUZEh5BhV31U6OnNWP=OCUmyZM2k4JGx5CXvQ@mail.gmail.com>
 <20200329153105.mdryxzz562tg65pk@development>
 <CAA4eK1JHxMaeQhvfpaBpUCLoeg3=RbbQQ_h0O0WwOU2kssRFsg@mail.gmail.com>
 <20200330152758.fgp62lwb2ug7cl2a@development>
 <CAA4eK1JMdBkYQF-fjSesb713Fib_v+ihFO-ZdDWpio8CQ7Yr_A@mail.gmail.com>
 <20200408005905.misvqmjk5c7wd5vr@development>
 <CAFiTN-uF4O+Uh_dQX1Um1xJYSKCBUrEB2o-etumUch8F3cEhGA@mail.gmail.com>
 <CAGz5QCJZx_V96e2SrJ9RnuNHk=kbb4uKFsXaymP_Wykma1h5_g@mail.gmail.com>
 <CAFiTN-tWk1mztXSEyfm=kHbJsRUOkXrGs4frk0qWpwKDyuD57A@mail.gmail.com>
 <CAGz5QC+DMNxD8wJyxBtJR7c2krJTa1m_vF6XDz--EVfcgF+qzg@mail.gmail.com>
 <CAFiTN-tLpNYVU7++teYq5gCYn8doOBawLB2pFSCLHV_c0OqsnQ@mail.gmail.com>
 <CAGz5QCLJK0QxV3jBcnEWd+cjz9en22=adQNFvmqpkCmR37wvZg@mail.gmail.com>
 <CAFiTN-vy3_KA-+kTff1=UvKasp0r1BDScDuJv5hN2SEw1PHn_A@mail.gmail.com>
 <f7f89dd6fb80780c2855b43a8d096ba2@xs4all.nl>
 <CAFiTN-tz+jjGHk4dkW=v==fJQZidobB7vp=_yhrT_ij0OLkiBA@mail.gmail.com>
 <36881eec90df541999a4e0a4b2eec60d@xs4all.nl>
 <bcc76806992e913a6862e64d633a166a@xs4all.nl>
 <09e0bcc4add23f539098eabc49fdee99@xs4all.nl>
 <6b70f0c449891856bf38290cc95e616f@xs4all.nl>
 <CAFiTN-ugQ90mZ7UgvUjfgURa3H3YqPi2tnhx6MArmA1WuTgFww@mail.gmail.com>
 <CAFiTN-tE7FNneDfPURWn_d5902WsrbWi_fZoXNjTx+5Fp+OxXw@mail.gmail.com>
Message-ID: <78a9704661bb37a8df252d4f9478bdab@xs4all.nl>
User-Agent: XS4ALL Webmail
Precedence: bulk

On 2020-04-22 16:49, Dilip Kumar wrote:
> On Tue, Apr 21, 2020 at 5:30 PM Dilip Kumar <dilipbalaut@gmail.com> 
> wrote:
>> 
>> >
>> >     (by the way: this build's regression tests  'ddl', 'toast', and
>> > 'spill' fail)
>> 
>> Yeah, this is a. known issue, actually, while streaming the
>> transaction the output message is changed.  I have a plan to work on
>> this part.
> 
> I have fixed this part.  Basically, now, I have created a separate
> function to get the streaming changes
> 'pg_logical_slot_get_streaming_changes'.  So the default function
> pg_logical_slot_get_changes will work as it is and test decoding test
> cases will not fail.

The 'ddl' one is apparently not quite fixed  - I get this in (cd 
contrib; make check)' (in both assert-enabled and non-assert-enabled 
build)

grep -A7 -B7 make.check_contrib.out:

contrib/make.check_contrib.out-============== initializing database 
system           ==============
contrib/make.check_contrib.out-============== starting postmaster        
             ==============
contrib/make.check_contrib.out-running on port 64464 with PID 9175
contrib/make.check_contrib.out-============== creating database 
"contrib_regression" ==============
contrib/make.check_contrib.out-CREATE DATABASE
contrib/make.check_contrib.out-ALTER DATABASE
contrib/make.check_contrib.out-============== running regression test 
queries        ==============
contrib/make.check_contrib.out:test ddl                          ... 
FAILED      840 ms
contrib/make.check_contrib.out-test xact                         ... ok  
          24 ms
contrib/make.check_contrib.out-test rewrite                      ... ok  
         187 ms
contrib/make.check_contrib.out-test toast                        ... ok  
         851 ms
contrib/make.check_contrib.out-test permissions                  ... ok  
          26 ms
contrib/make.check_contrib.out-test decoding_in_xact             ... ok  
          31 ms
contrib/make.check_contrib.out-test decoding_into_rel            ... ok  
          25 ms
contrib/make.check_contrib.out-test binary                       ... ok  
          12 ms

Otherwise patches apply and build OK so will go run some tests...