Message-ID: <78b4383b-1e25-aacd-7c41-ecdeb8a3292f@enterprisedb.com>
Date: Fri, 25 Mar 2022 10:01:09 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [RFC] building postgres with meson -v8
Content-Language: en-US
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org
References: <20211012083721.hvixq4pnh2pixr3j@alap3.anarazel.de>
 <20220308025629.3xh2yo4sau74oafo@alap3.anarazel.de>
 <721828a7-3043-6803-a85b-da63538db3cc@enterprisedb.com>
 <20220309164420.rr5lws22asrd5mfm@alap3.anarazel.de>
 <20220322022208.44py5lk7twdfuqb5@alap3.anarazel.de>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <20220322022208.44py5lk7twdfuqb5@alap3.anarazel.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/78b4383b-1e25-aacd-7c41-ecdeb8a3292f%40enterprisedb.com>
Precedence: bulk


On 22.03.22 03:22, Andres Freund wrote:
> Attached is v8. It's just a rebase to resolve conflicts with recent changes.

I have committed the DLSUFFIX refactoring, and also a stripped-down 
version of the patch that makes update-unicode work with vpath.  This 
takes care of patches 0007 and 0009.

Patch 0006 (visibility) has its own CF entry.

The only other thing IMO that might be worth addressing in PG15 is the 
snowball scripts refactoring (0002 and 0003), but that doesn't seem 
quite ready yet.  (At least, it would need to be integrated into the 
distprep target, since it adds a dependency on perl.)  Maybe it's not 
worth it right now.

With that, I suggest moving this patch set to CF 2022-07.

A general comment on the remaining prereq patches:  We appear to be 
accumulating a mix of conventions for how "generate" scripts specify 
their output file.  Some have it built-in, some use the last argument, 
some use an option, which might be -o or --output.  Maybe we can gently 
work toward more commonality there.