Subject: Re: automating pg_config.h.win32 maintenance
To: Michael Paquier <michael@paquier.xyz>
References: <1441b834-f434-e0bf-46ed-9c4d5c29c2d4@2ndquadrant.com>
 <594b0e2a-6343-039a-1bac-a3ec7e74f2bf@iki.fi>
 <20191213134416.GB103520@paquier.xyz> <21839.1576245392@sss.pgh.pa.us>
 <2ccaf97f-5bdc-cc9c-5441-706469642776@2ndquadrant.com>
 <20191217063038.GM2344@paquier.xyz>
 <ebe2ccfe-ab5b-f7e2-242d-988daf594346@2ndquadrant.com>
 <20191219035924.GE4202@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Heikki Linnakangas <hlinnaka@iki.fi>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <78e64ab4-ff4a-0613-660c-d6429ad8d621@2ndquadrant.com>
Date: Thu, 19 Dec 2019 08:31:05 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20191219035924.GE4202@paquier.xyz>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2019-12-19 04:59, Michael Paquier wrote:
> On Tue, Dec 17, 2019 at 11:56:17AM +0100, Peter Eisentraut wrote:
>> Yeah, good idea.  Attached patch is refactored so all three header files
>> managed by AC_CONFIG_HEADERS are processed the same way.
> 
> Looks good.  I just have one comment.
> 
> +   # XXX
> +   open(my $f, '>>', 'src/include/pg_config.h')
> +     || confess "Could not write to src/include/pg_config.h\n";
> +   print $f "\n";
> +   print $f "#define VAL_CONFIGURE \""
> +     . $self->GetFakeConfigure() . "\"\n";
> +   close($f);
> 
> This part needs a comment.  Like it is the equivalent of what
> src/common/'s Makefile does or something like that?

This was meant to be addressed by 
<https://www.postgresql.org/message-id/flat/6e457870-cef5-5f1d-b57c-fc89cfb8a788%402ndquadrant.com>, 
but that discussion has not concluded yet.  Perhaps it makes more sense 
in this context.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services