From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        Greg Sabino Mullane <htamfids@gmail.com>,
        pgsql-hackers@lists.postgresql.org,
        Magnus Hagander <magnus@hagander.net>
Subject: Re: Tarball builds in the new world order
In-reply-to: <202404281916.cpngjkjnosj2@alvherre.pgsql>
References: <202404281916.cpngjkjnosj2@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@alvh.no-ip.org>
	message dated "Sun, 28 Apr 2024 21:16:48 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <790491.1714333450.1@sss.pgh.pa.us>
Date: Sun, 28 Apr 2024 15:44:10 -0400
Message-ID: <790492.1714333450@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/790492.1714333450%40sss.pgh.pa.us>
Precedence: bulk

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Why is it that the .gitrevision file is only created here, instead of
> being added to the tarball that "git archive" produces?  Adding an
> argument like
> 	--add-virtual-file $(distdir)/.gitrevision:$(GIT_REFSPEC)
> to the git archive call should suffice.

I think we don't want to do that.  In the first place, it's redundant
because "git archive" includes the commit hash in the tar header,
and in the second place it gets away from the concept that the tarball
contains exactly what is in our git tree.

Now admittedly, if anyone's built tooling that relies on the presence
of the .gitrevision file, they might prefer that we keep on including
it.  But I'm not sure anyone has, and in any case I think switching
to the git-approved way of incorporating the hash is the best thing
in the long run.

What I'm thinking of doing, as soon as we've sorted the tarball
creation process, is to make a test tarball available to the
packagers group so that anyone interested can start working on
updating their packaging process for the new approach.  Hopefully,
if anyone's especially unhappy about omitting .gitrevision, they'll
speak up.

			regards, tom lane