Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1osyZN-0004Ni-9S for pgsql-hackers@arkaria.postgresql.org; Thu, 10 Nov 2022 03:49:37 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1osyZL-0007QF-W2 for pgsql-hackers@arkaria.postgresql.org; Thu, 10 Nov 2022 03:49:35 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1osyZL-0007Q6-MK for pgsql-hackers@lists.postgresql.org; Thu, 10 Nov 2022 03:49:35 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1osyZJ-00069Q-Be for pgsql-hackers@postgresql.org; Thu, 10 Nov 2022 03:49:35 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 2AA3nUmJ079301; Wed, 9 Nov 2022 22:49:30 -0500 From: Tom Lane To: "Regina Obe" cc: pgsql-hackers@postgresql.org Subject: Re: Ability to reference other extensions by schema in extension scripts In-reply-to: <003001d8f4ae$402282c0$c0678840$@pcorp.us> References: <003001d8f4ae$402282c0$c0678840$@pcorp.us> Comments: In-reply-to "Regina Obe" message dated "Wed, 09 Nov 2022 21:43:43 -0500" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <79299.1668052170.1@sss.pgh.pa.us> Date: Wed, 09 Nov 2022 22:49:30 -0500 Message-ID: <79300.1668052170@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk "Regina Obe" writes: > My proposal is this. If you think it's a good enough idea I can work up a > patch for this. > Extensions currently are allowed to specify a requires in the control file. > I propose to use this information, to allow replacement of phrases > @extschema_nameofextension@ as a variable, where nameofextension has to be > one of the extensions listed in the requires. I have a distinct sense of deja vu here. I think this idea, or something isomorphic to it, was previously discussed with some other syntax details. I'm too lazy to go searching the archives right now, but I suggest that you try to find that discussion and see if the discussed syntax seems better or worse than what you mention. I think it might've been along the line of @extschema:nameofextension@, which seems like it might be superior because colon isn't a valid identifier character so there's less risk of ambiguity. regards, tom lane