From: Tom Lane <tgl@sss.pgh.pa.us>
To: Erik Wienhold <ewie@ewie.name>
cc: Marcos Pegoraro <marcos@f10.com.br>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Add column name to error description
In-reply-to: <afxezpvlwknoz2w66frakeg2feua76zqvgszrjrmpkhs7ynqir@x5y2tdomabdx>
References: <CAB-JLwanky28gjAMdnMh1CjyO1b2zLdr6UOA1-oY9G7PVL9KKQ@mail.gmail.com> <afxezpvlwknoz2w66frakeg2feua76zqvgszrjrmpkhs7ynqir@x5y2tdomabdx>
Comments: In-reply-to Erik Wienhold <ewie@ewie.name>
	message dated "Sun, 31 Mar 2024 20:57:57 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <794291.1711912501.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sun, 31 Mar 2024 15:15:01 -0400
Message-ID: <794292.1711912501@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/794292.1711912501%40sss.pgh.pa.us>
Precedence: bulk

Erik Wienhold <ewie@ewie.name> writes:
> On 2024-03-31 15:22 +0200, Marcos Pegoraro wrote:
>> This is my first patch, so sorry if I miss something.

> Please make sure that tests are passing by running make check:

check-world, in fact.

> The format "%d-%s" is not ideal.  I suggesst "%d (%s)".

I didn't like that either, for two reasons: if we have a column name
it ought to be the prominent label, but we might not have one if the
TupleDesc came from some anonymous source (possibly that case explains
the test crash?  Although I think the attname would be an empty string
rather than missing entirely in such cases).  I think it'd be worth
providing two distinct message strings:

"Returned type %s does not match expected type %s in column \"%s\" (positi=
on %d)."
"Returned type %s does not match expected type %s in column position %d."

I'd suggest dropping the column number entirely in the first case,
were it not that the attnames might well not be unique if we're
dealing with an anonymous record type such as a SELECT result.

			regards, tom lane