Feedback-ID: ie0a040ee:Fastmail
Message-ID: <794e9968-c48f-4ec3-a5f9-a7e8faca8979@eisentraut.org>
Date: Fri, 7 Nov 2025 17:28:13 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: AIX support
To: Srirama Kucherlapati <sriram.rk@in.ibm.com>,
 Andres Freund <andres@anarazel.de>,
 AIX PG user <postgres-ibm-aix@wwpdl.vnet.ibm.com>
Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
References: 
 <CY5PR11MB63928CC05906F27FB10D74D0FD322@CY5PR11MB6392.namprd11.prod.outlook.com>
 <ko5nio3iyt7fonvwqqgs6gddzyzlad7qm5v6zo72h753jmitwy@llz3bghejzig>
 <175863756865.1038.1316404745203068811.pgcf@coridan.postgresql.org>
 <3xsqvatpnbb7wd3vdxdygzh6s2bbxn3ulmarli67x5u7hekvei@3it2vxprjglu>
 <SJ4PPFB817783263D506AAE4C480F5B2866DB1DA@SJ4PPFB81778326.namprd15.prod.outlook.com>
 <SJ4PPFB8177832600E5AAE4214587DC3F7BDBE8A@SJ4PPFB81778326.namprd15.prod.outlook.com>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: 
 <SJ4PPFB8177832600E5AAE4214587DC3F7BDBE8A@SJ4PPFB81778326.namprd15.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/794e9968-c48f-4ec3-a5f9-a7e8faca8979%40eisentraut.org>
Precedence: bulk

On 15.10.25 17:58, Srirama Kucherlapati wrote:
> Hi Andres and team,
> 
> Please find attached the patch addressing Meson build changes for AIX.
> 
> We tried to build using below meson
> 
> ## meson -v
> 
> 1.6.1
> 
> For the following files, the shared_module() function requires 
> specifying the
> 
> appropriate symbol import file, which is provided via the aix_link_args
> 
> variable:
> 
> src/backend/jit/llvm/meson.build
> 
> src/backend/replication/libpqwalreceiver/meson.build
> 
> src/backend/replication/pgoutput/meson.build
> 
> src/backend/snowball/meson.build
> 
> src/backend/utils/mb/conversion_procs/meson.build
> 
> Additionally, with the latest version of Meson, when building static 
> libraries,
> 
> the library file name must be suffixed with “_static” in the following 
> files:
> 
> src/interfaces/ecpg/compatlib/meson.build
> 
> src/interfaces/ecpg/ecpglib/meson.build
> 
> src/interfaces/ecpg/pgtypeslib/meson.build
> 
> src/interfaces/libpq/meson.build

It is not going to be acceptable to sprinkle this much AIX-specific code 
around.  Those changes to the meson.build files were not needed before 
AIX support was removed.  You should find a way to do it without these 
changes.

The changes in src/include/port/aix.h in your patch don't make sense. 
This indicates that you are doing something wrong in your local builds. 
Please fix that.