From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Thomas Munro <thomas.munro@gmail.com>,
        Andrew Dunstan <andrew.dunstan@2ndquadrant.com>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Teach pg_upgrade test to honor NO_TEMP_INSTALL
In-reply-to: <20190522182027.fzytm3tciqefgz43@alap3.anarazel.de>
References: <5506b8fa-7dad-8483-053c-7ca7ef04f01a@2ndQuadrant.com>
 <20190521015840.cztw2qxthh7xuutk@alap3.anarazel.de>
 <aaee2cc8-d722-990c-b848-413ba9913703@2ndQuadrant.com>
 <20190521191918.z7kwnrlj45mk2k67@alap3.anarazel.de>
 <20190521194129.2kl2mldesrr65gmb@alap3.anarazel.de>
 <CA+hUKGKY=p7ZeZmAiC0zK72moLyYC=HaF-Fg36s+tNEAJD6R+g@mail.gmail.com>
 <7333.1558537134@sss.pgh.pa.us>
 <20190522175150.c26f4jkqytahajdg@alap3.anarazel.de>
 <7200.1558548407@sss.pgh.pa.us>
 <20190522182027.fzytm3tciqefgz43@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Wed, 22 May 2019 11:20:27 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <7964.1558549671.1@sss.pgh.pa.us>
Date: Wed, 22 May 2019 14:27:51 -0400
Message-ID: <7965.1558549671@sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2019-05-22 14:06:47 -0400, Tom Lane wrote:
>> Not sure about that last bit.  pg_upgrade has the issue of possibly
>> wanting to deal with 2 installations, unlike the rest of the tree,
>> so I'm not sure that fixing its problem means there's something we
>> need to change everywhere else.

> I'm not quite following? We need to move it into global scope to fix the
> issue at hand (namely that we currently need to make install first, just
> to get psql).  And at which scope could it be in master, other than
> global?

Maybe I misunderstood you --- I thought you were talking about something
like defining EXTRA_REGRESS_OPTS in Makefile.global.  If you mean
running this unconditionally within test.sh, I've got no objection
to that.

> I do think we will have to move it to the global scope in the back
> branches too, because NO_TEMP_INSTALL does indeed fail without a global
> install first (rather than using the temp install, as intended):

Agreed, we should fix it in all branches, because it seems like it's
probably testing the wrong thing, ie using the later branch's psql
to run the earlier branch's regression tests.

			regards, tom lane