Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hklDG-0000DH-2b for pgsql-hackers@arkaria.postgresql.org; Tue, 09 Jul 2019 08:10:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hklDE-0003Kc-Ut for pgsql-hackers@arkaria.postgresql.org; Tue, 09 Jul 2019 08:10:56 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hklDE-0003E4-8E for pgsql-hackers@lists.postgresql.org; Tue, 09 Jul 2019 08:10:56 +0000 Received: from cyclops.postgrespro.ru ([93.174.131.138] helo=mail.postgrespro.ru) by makus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hklDB-0002Vj-Bp for pgsql-hackers@lists.postgresql.org; Tue, 09 Jul 2019 08:10:55 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.postgrespro.ru (Postfix) with ESMTP id 9F14521C2337; Tue, 9 Jul 2019 11:10:50 +0300 (MSK) X-Virus-Scanned: Debian amavisd-new at postgrespro.ru X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=x tagged_above=-99 required=4 WHITELISTED tests=[] autolearn=unavailable Received: from [192.168.27.237] (gw.postgrespro.ru [93.174.131.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mail.postgrespro.ru (Postfix) with ESMTPSA id 64AE321C1FBF; Tue, 9 Jul 2019 11:10:50 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mail; t=1562659850; bh=9oHwegXPKnf6eIe2MGTvGkreuBafaTDt8/iLR0dX8gw=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=nZTJYH3W3iKbjVIuYGsG0+vjUW3Bv4YiLqaaYdpCKNhWDs5P1WV1IoMQxLLxL89Bx 7Vqe8AoQQP3wCimSlxgiRxna1ob/RSlcSQKxcY56sdyTC844B83HW5jZK7CoGrn17/ qPdhzFVXEPxLCIhIjidVh+MvbNMTGfKakPrpqXUk= Subject: Re: Extra quote_all_identifiers in _dumpOptions To: Bruce Momjian Cc: PostgreSQL Hackers References: <20190708233207.ovbrtkjnwhcznwpc@momjian.us> From: Arthur Zakirov Message-ID: <7967be19-322c-ec5e-ac93-61a3c3092cce@postgrespro.ru> Date: Tue, 9 Jul 2019 11:10:49 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20190708233207.ovbrtkjnwhcznwpc@momjian.us> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 09.07.2019 02:32, Bruce Momjian wrote: >> diff --git a/src/bin/pg_dump/pg_backup.h b/src/bin/pg_dump/pg_backup.h >> index db30b54a92..8c0cedcd98 100644 >> --- a/src/bin/pg_dump/pg_backup.h >> +++ b/src/bin/pg_dump/pg_backup.h >> @@ -153,7 +153,6 @@ typedef struct _dumpOptions >> int no_synchronized_snapshots; >> int no_unlogged_table_data; >> int serializable_deferrable; >> - int quote_all_identifiers; >> int disable_triggers; >> int outputNoTablespaces; >> int use_setsessauth; > > Wow, good catch. I thought C compilers would have reported this issue, > but obviously not. Patch applied to head. Thanks. Thank you, Bruce! -- Arthur Zakirov Postgres Professional: http://www.postgrespro.com Russian Postgres Company