Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lLsQF-0004uB-DY for pgsql-hackers@arkaria.postgresql.org; Mon, 15 Mar 2021 18:58:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lLsQE-0005GB-BB for pgsql-hackers@arkaria.postgresql.org; Mon, 15 Mar 2021 18:58:34 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lLsQE-0005Fo-1P for pgsql-hackers@lists.postgresql.org; Mon, 15 Mar 2021 18:58:34 +0000 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lLsQB-0001YK-2s for pgsql-hackers@lists.postgresql.org; Mon, 15 Mar 2021 18:58:32 +0000 Received: by mail-pg1-x536.google.com with SMTP id q5so8356088pgk.5 for ; Mon, 15 Mar 2021 11:58:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=J6cFqJo1dLj3XgWRGX9XchpmWz2IaO/9X9YgC3tm1Tg=; b=Qe0gmRe2v9oJKWjsH/j8OYjpdfG4IAuQ92soOymmOpM+P1oQyAH8c+rnA2z3uzTHUY Znn49o7CrTagJ6gWfGFBi55KH7K3HfGPQ9eOix6qJzRSRWrKJN+wOjYl5p4V1ZCq3sOm o2AdAz3dnrgrgNdqsu4KGZo7/pkziueoUenF7ptgK1VvNhuEO/qethzfP49+u+QAkSCE F3pnRAowJQy60Sq/f+PxnoqCo44PT96GkVqZ3YTPfY/bhz+1/HwqdeqhApe1bvWC8CHs XsuwGrhFELPHI3GEiX1kX/2z6BG1F0+MG6NhlBuvwyCd5s0OGt5uYYS3m+2+iINqxFX+ EJeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=J6cFqJo1dLj3XgWRGX9XchpmWz2IaO/9X9YgC3tm1Tg=; b=oHMTd/D8tWAj2WT5mTxLEu5mEPtYocNH+Eq0Ut6u1ktNlMD91ATvqJk2NAvHmwyceV LXnYSSL1fMfpJ9sZMA6OTrztjWfnzwLv2Jc8lUyMe/LHNxEk8s5zn04nAY6hVnQQdRPv baQfEG5Zw0SNYP9pdAd0AGto6TIMZYUDj+Eu+svs55+xv1N08ep8O44VJbkvLYsBi4yK L1QO5LfSCtyy6RwtL2oundbqXBed7D+jB33g8T4pY93RP4XpGbn/WoiD1vLBabsg3Oeb KZKdeG6vxW2tHgXDHSlQZZLnYSvY7JYouy250G1OIYXXcbHErnC1sImG9Ga8yTJ2dgqg etXw== X-Gm-Message-State: AOAM530/9CDXt6XSkQDiq2WqnRkdXGy7BTh2griBYtsyePiUS66pdf5h r3jovCNJIAvpbAE30DfN4SRWrTGhmP1y+kh2KXF478t72z7PMIS2M2f/SU5x8zCoyZYxeDSfBLo RWB+URU2b2cN++2jj0GCUx5P6Nl49TpNoao4Gd7R6DxF2z7K9BwqcRjgM8irxaMs5s1+yd1/diV yCeP4mOPtAs0nwHJ7CTISzMW4Zsj14M/DbbAEUIcWX9HMiFgIX9bcO X-Google-Smtp-Source: ABdhPJwHzOPAB0JbtT9vJrtfagqdCY1UMTs2xKjfsb8RyoXNnYFbqJd4PCgeTpog9Z8qjF4azeQWNg== X-Received: by 2002:a62:874c:0:b029:1f6:4478:a629 with SMTP id i73-20020a62874c0000b02901f64478a629mr11244623pfe.36.1615834709595; Mon, 15 Mar 2021 11:58:29 -0700 (PDT) Received: from laptop280-ma-us.hitronhub.home (24-113-193-150.wavecable.com. [24.113.193.150]) by smtp.gmail.com with ESMTPSA id v134sm14439250pfc.182.2021.03.15.11.58.28 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Mar 2021 11:58:29 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\)) Subject: Re: REINDEX backend filtering From: Mark Dilger In-Reply-To: Date: Mon, 15 Mar 2021 11:58:28 -0700 Cc: Michael Paquier , Magnus Hagander , PostgreSQL Hackers Content-Transfer-Encoding: quoted-printable Message-Id: <79A045F4-17DF-4975-ABF4-9F40171E740D@enterprisedb.com> References: <20210315003551.enuwfghdh7qhfnb2@nol> <20210315033320.4273frstqn7w6kh7@nol> <0E0B73C0-EBC0-490A-9347-66A66E3338AE@enterprisedb.com> <20210315165213.tgxwtjtnlnr2q3f5@nol> <074D5DFD-4D47-4A84-93A5-C2DC8935E6E9@enterprisedb.com> <20210315173401.yqgxgmbspiyfrbks@nol> <9AC710C9-7006-43EC-93F6-7A7ABFE09E80@enterprisedb.com> <20210315175044.txxhycqg7iaa66qy@nol> <20210315181037.nlw7ghqqtngqdm2r@nol> To: Julien Rouhaud X-Mailer: Apple Mail (2.3608.120.23.2.1) X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On Mar 15, 2021, at 11:32 AM, Mark Dilger = wrote: >=20 > If you had a real, not fake, collation provider which actually = provided a collation with an actual version number, stopped the server, = changed the behavior of the collation as well as its version number, = started the server, and ran REINDEX (OUTDATED), I think that would be a = more real-world test. I'm not demanding that you write such a test. = I'm just saying that it is strange that we don't have coverage for this = anywhere, and was asking if you think there is such coverage, because, = you know, maybe I just didn't see where that test was lurking. I should add some context regarding why I mentioned this issue at all. Not long ago, if an upgrade of icu or libc broke your collations, you = were sad. But postgres didn't claim to be competent to deal with this = problem, so it was just a missing feature. Now, with REINDEX = (OUTDATED), we're really implying, if not outright saying, that postgres = knows how to deal with collation upgrades. I feel uncomfortable that = v14 will make such a claim with not a single regression test confirming = such a claim. I'm happy to discover that such a test is lurking = somewhere and I just didn't see it. =E2=80=94 Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company