Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.600.62\))
Subject: Re: Avoid incomplete copy string (src/backend/access/transam/xlog.c)
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: <CAEudQArkgfqHOCwJ=SNvOHC_esELM=71hwE0YmzELpZ_Bbu9bQ@mail.gmail.com>
Date: Mon, 1 Jul 2024 11:20:19 +0200
Cc: Yugo NAGATA <nagata@sraoss.co.jp>,
 Richard Guo <guofenglinux@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <7AD0FC93-18BB-44B1-894E-92B688124CD3@yesql.se>
References: <CAEudQApAsbLsQ+gGiw-hT+JwGhgogFa_=5NUkgFO6kOPxyNidQ@mail.gmail.com>
 <CAMbWs4-f4D425C73p0WPBYb2qpiGZyJGvivxS15rEz_igR8vMQ@mail.gmail.com>
 <CAEudQArgZA3pnrAtG15wDUcW_hLLPv69otLBaiTak9nLZr7MOg@mail.gmail.com.sranhm>
 <20240627130108.7a4b4217b31472cd22161918@sranhm.sraoss.co.jp>
 <CAEudQAqkDPpQDOnAg_21w5_Sz8Z7jomPHsP-nqajo_=WoUKCzw@mail.gmail.com>
 <CAEudQArkgfqHOCwJ=SNvOHC_esELM=71hwE0YmzELpZ_Bbu9bQ@mail.gmail.com>
To: Ranier Vilela <ranier.vf@gmail.com>
Archived-At: <https://www.postgresql.org/message-id/7AD0FC93-18BB-44B1-894E-92B688124CD3%40yesql.se>
Precedence: bulk

> On 27 Jun 2024, at 13:50, Ranier Vilela <ranier.vf@gmail.com> wrote:

> Now with file patch really attached.

-	if (strlen(backupidstr) > MAXPGPATH)
+	if (strlcpy(state->name, backupidstr, sizeof(state->name)) >=3D =
sizeof(state->name))
 		ereport(ERROR,

Stylistic nit perhaps, I would keep the strlen check here and just =
replace the
memcpy with strlcpy.  Using strlen in the error message check makes the =
code
more readable.


-	char		name[MAXPGPATH + 1];
+	char		name[MAXPGPATH];/* backup label name */

With the introduced use of strlcpy, why do we need to change this field?

--
Daniel Gustafsson