Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\))
Subject: Re: Add missing stats_reset column to pg_stat_database_conflicts view
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: 
 <CAHGQGwHaHnRrz9hqpDdn984mqToJDdkjMRVvEXXgFwCnXJb89Q@mail.gmail.com>
Date: Thu, 12 Mar 2026 14:04:39 +0800
Cc: shihao zhong <zhong950419@gmail.com>,
 Sami Imseih <samimseih@gmail.com>,
 Kirill Reshke <reshkekirill@gmail.com>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <7C8AB453-8353-4D79-AA97-62177D631A18@gmail.com>
References: 
 <CAGRkXqS98OebEWjax99_LVAECsxCB8i=BfsdAL34i-5QHfwyOQ@mail.gmail.com>
 <CAA5RZ0vSjCEAuKXhxacnp0ftrYkf9QRcyPK-AvTi_otFVDWphA@mail.gmail.com>
 <CAHGQGwEeGUQtj7TOznM2_O2uV-g6iOa1UBBTBfyugJ-nSoS89Q@mail.gmail.com>
 <CALdSSPi4apueVqgnJEZqpy6O0HSEPUiUzf=vTLPPijsQLob2Eg@mail.gmail.com>
 <CAGRkXqQ0qBHTcD=UZ7_GTLsgn+W-=1c8suMJ3yWZb2eP4m0fBg@mail.gmail.com>
 <CAA5RZ0ta3y==2AStFyo-SYyJ2ztd3ZiurN1HQR9gzDTKVtgUDg@mail.gmail.com>
 <CAGRkXqRVDuhXNCvQ=j-+5KCu+Gcar_h5OeHTaMaVKF-FLV2YvQ@mail.gmail.com>
 <CAHGQGwHaHnRrz9hqpDdn984mqToJDdkjMRVvEXXgFwCnXJb89Q@mail.gmail.com>
To: Fujii Masao <masao.fujii@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/7C8AB453-8353-4D79-AA97-62177D631A18%40gmail.com>
Precedence: bulk


> On Mar 12, 2026, at 12:50, Fujii Masao <masao.fujii@gmail.com> wrote:
>=20
> On Wed, Mar 11, 2026 at 11:10=E2=80=AFPM shihao zhong =
<zhong950419@gmail.com> wrote:
>> Thanks for pointing that out. I've added new tests and used git
>> format-patch to generate a new patch.
>=20
> Thanks for updating the patch!
>=20
> +-- Test that the stats_reset column in pg_stat_database_conflicts is
> correctly maintained
> +SELECT pg_stat_reset();
> +SELECT stats_reset IS NOT NULL AS has_stats_reset
> +  FROM pg_stat_database_conflicts WHERE datname =3D =
current_database();
>=20
> Since stats.sql already includes tests verifying that reset works for
> pg_stat_database, it might be better to add the test for
> pg_stat_database_conflicts alongside those, rather than at the end of
> stats.sql. Thought? The attached updated patch does that.
>=20
> I also fixed some indentation issues in the docs in the patch.
>=20
> Regards,
>=20
> --=20
> Fujii Masao
> <v4-0001-Add-stats_reset-column-to-pg_stat_database_confli.patch>

V4 overall LGTM. A couple of nitpicks:

1 - stats.sql
```
+WHERE D.datname =3D (SELECT current_database()) AND D.datname =3D =
DC.datname \gset

+WHERE D.datname =3D (SELECT current_database()) AND D.datname =3D =
DC.datname;
```

(SELECT current_database()) can be just current_database(). I tried to =
fix this in my local, and the fix works for me.

2 - stats.sql
```
+-- Since stats_reset in pg_stat_database and pg_stat_database_conflicts =
starts
+-- out as NULL, reset it once first so we have something to compare it =
to
```

I think =E2=80=9Cstarts=E2=80=9D should be =E2=80=9Cstart=E2=80=9D, =
because there are two stats_reset fields from two tables in this =
context.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/