Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\))
Subject: Re: doc: Clarify that empty COMMENT string removes the comment
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: 
 <CAHGQGwFEpaPXwsLbvMzq8yzLHMMggDRXYg5jJzGAu1QuATx_rA@mail.gmail.com>
Date: Tue, 3 Mar 2026 15:34:35 +0800
Cc: "David G. Johnston" <david.g.johnston@gmail.com>,
 Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 zhang_qiang81@163.com
Content-Transfer-Encoding: quoted-printable
Message-Id: <7EEFEBA0-755F-40F5-8529-1610B256BFA6@gmail.com>
References: <26476097-B1C1-4BA8-AA92-0AD0B8EC7190@gmail.com>
 <CAExHW5vqMWdZ0wh7hFvGascGmpS7sYDTb26Bw2sGY3R4fOz3sw@mail.gmail.com>
 <CAKFQuwbT4RpRtEmygJyLqnjs7tgtZ4mHRX9-MJxQ3ZBu+2b+UQ@mail.gmail.com>
 <9E0B8DED-4A75-4E93-B731-62A4E7F92B2C@gmail.com>
 <CAKFQuwb3-nGGOTR9vwQSr2GBgdaAxipM+iuTdXB00JKGkndKyw@mail.gmail.com>
 <6DE4E50D-C195-4731-BF1C-C1134B69FA99@gmail.com>
 <CAKFQuwbdScCczkpNevikNOGC=XVT6Lch_z1TOtAA_csELOL8hw@mail.gmail.com>
 <3A66BB3E-8230-45D7-ACF0-122B725957BF@gmail.com>
 <CAHGQGwFSxdXh-LsSTj+EE6VhJm6XjpgiH42kUsUDxgXViFn-Cg@mail.gmail.com>
 <F88CAD6A-7CD2-445D-AE79-76F3F827B296@gmail.com>
 <CAHGQGwFEpaPXwsLbvMzq8yzLHMMggDRXYg5jJzGAu1QuATx_rA@mail.gmail.com>
To: Fujii Masao <masao.fujii@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/7EEFEBA0-755F-40F5-8529-1610B256BFA6%40gmail.com>
Precedence: bulk


> On Mar 3, 2026, at 13:51, Fujii Masao <masao.fujii@gmail.com> wrote:
>=20
> On Tue, Mar 3, 2026 at 12:17=E2=80=AFPM Chao Li =
<li.evan.chao@gmail.com> wrote:
>>=20
>>=20
>>=20
>>> On Mar 3, 2026, at 08:28, Fujii Masao <masao.fujii@gmail.com> wrote:
>>>=20
>>> On Tue, Mar 3, 2026 at 8:42=E2=80=AFAM Chao Li =
<li.evan.chao@gmail.com> wrote:
>>>>=20
>>>>=20
>>>>=20
>>>>> On Feb 28, 2026, at 09:21, David G. Johnston =
<david.g.johnston@gmail.com> wrote:
>>>>>=20
>>>>> On Fri, Feb 27, 2026 at 5:12=E2=80=AFPM Chao Li =
<li.evan.chao@gmail.com> wrote:
>>>>>=20
>>>>> PFA v3.
>>>=20
>>> Thanks for updating the patch! LGTM
>>>=20
>>> One more comment: the handling of empty-string comments exists in =
both
>>> CreateComments() and CreateSharedComments(). For better test =
coverage,
>>> how about adding also the regression test to check that COMMENT with
>>> empty-string works as expected for shared objects such as roles?
>>>=20
>>=20
>> Sure. CreateSharedComments() handles database, tablespace and role, =
so as you suggested, I added tests for role in v4.
>>=20
>>> From: zhangqiang <zhang_qiang81@163.com>
>>>=20
>>> Hi hackers,I have verified that using an empty string does indeed =
delete comments. I agree this patch content enables users to better =
understand how the database program handles empty strings when using the =
COMMENT ON command in documentation, thereby improving the user =
experience.I think it's a good patch.
>>>=20
>>=20
>> Thanks for your review. Sounds good.
>>=20
>> PFA v4:
>> * Add tests that use NULL and =E2=80=98=E2=80=99 to remove comments =
from a role object.
>=20
> Thanks for updating the patch! I've pushed it.
>=20
> Regards,
>=20
>=20
> --=20
> Fujii Masao

Hi Fujii-san, thank you very much for pushing.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/