From: Chao Li <li.evan.chao@gmail.com>
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\))
Subject: Re: Cleanup shadows variable warnings, round 1
Date: Fri, 28 Nov 2025 21:39:33 +0800
References: 
 <CAEoWx2kQ2x5gMaj8tHLJ3=jfC+p5YXHkJyHrDTiQw2nn2FJTmQ@mail.gmail.com>
To: Postgres hackers <pgsql-hackers@lists.postgresql.org>
In-Reply-To: 
 <CAEoWx2kQ2x5gMaj8tHLJ3=jfC+p5YXHkJyHrDTiQw2nn2FJTmQ@mail.gmail.com>
Message-Id: <7F33AD9D-619D-4846-937A-F0EF982332A4@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/7F33AD9D-619D-4846-937A-F0EF982332A4%40gmail.com>
Precedence: bulk


> On Nov 28, 2025, at 16:16, Chao Li <li.evan.chao@gmail.com> wrote:
>=20
> Hi Hackers,
>=20
> While reviewing [1], it makes me recall an experience where I had a =
patch ready locally, but CommitFest CI failed with a shadows-variable =
warning. Now I understand that -Wall doesn't by default enable -Wshadows =
with some compilers like clang.
>=20
> I did a clean build with manually enabling -Wshadow and surprisingly =
found there are a lot of such warnings in the current code base, roughly =
~200 occurrences.
>=20
> As there are too many, I plan to fix them all in 3-4 rounds. For round =
1 patch, I'd see any objection, then decide if to proceed more rounds.
>=20
> [1] =
https://postgr.es/m/CAHut+PsF8R0Bt4J3c92+T2F0mun0rRfK=3D-GH+iBv2s-O8ahJJw@=
mail.gmail.com
>=20

CF entry added: https://commitfest.postgresql.org/patch/6262/

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/