Message-ID: <7a005e90-debb-c485-62b4-dbb49d63e5a7@enterprisedb.com>
Date: Tue, 14 Dec 2021 23:13:43 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: Synchronizing slots from primary to standby
Content-Language: en-US
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
References: <514f6f2f-6833-4539-39f1-96cd1e011f23@enterprisedb.com>
 <CAD21AoCRd2=JG1tcz_U=nj5FDbDrPSKL7uE9tAL7so6-QHVy1A@mail.gmail.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: 
 <CAD21AoCRd2=JG1tcz_U=nj5FDbDrPSKL7uE9tAL7so6-QHVy1A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/7a005e90-debb-c485-62b4-dbb49d63e5a7%40enterprisedb.com>
Precedence: bulk

On 24.11.21 07:11, Masahiko Sawada wrote:
> I haven’t looked at the patch deeply but regarding 007_sync_rep.pl,
> the tests seem to fail since the tests rely on the order of the wal
> sender array on the shared memory. Since a background worker for
> synchronizing replication slots periodically connects to the walsender
> on the primary and disconnects, it breaks the assumption of the order.
> Regarding 010_logical_decoding_timelines.pl, I guess that the patch
> breaks the test because the background worker for synchronizing slots
> on the replica periodically advances the replica's slot. I think we
> need to have a way to disable the slot synchronization or to specify
> the slot name to sync with the primary. I'm not sure we already
> discussed this topic but I think we need it at least for testing
> purposes.

This has been addressed by patch v2 that adds such a setting.