Feedback-ID: i131946ab:Fastmail
Message-ID: <7a662264-6e04-7bb7-a4aa-1ac03ae3436c@enterprisedb.com>
Date: Thu, 9 Mar 2023 15:18:07 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.8.0
Subject: Re: meson: Non-feature feature options
Content-Language: en-US
To: Nazir Bilal Yavuz <byavuz81@gmail.com>,
 Daniel Gustafsson <daniel@yesql.se>
Cc: Andres Freund <andres@anarazel.de>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>
References: <ad65ffd1-a9a7-fda1-59c6-f7dc763c3051@enterprisedb.com>
 <20230208162310.scllwgr5qp3m5tme@awork3.anarazel.de>
 <c649abc4-8ede-dba2-1a28-e6ee3cf35006@gmail.com>
 <000d58dd-6164-f695-fe12-38ac7e37543b@gmail.com>
 <1d1eb740-e2d6-dd92-ba35-985af38b30d5@enterprisedb.com>
 <20230220194249.lkirdwhosjq6zdkc@awork3.anarazel.de>
 <CAN55FZ2Bz5P_sd2+1KBwWa9v4vDByM2UX7rKfzQs7yj6buojsg@mail.gmail.com>
 <4e1fcc8d-77cf-082c-5dd8-9ab09bb7a05f@enterprisedb.com>
 <CAN55FZ3JkWJRgBOvaB0VDYg1F+v3QMg4vwVae1gpQ+mnsYc-3g@mail.gmail.com>
 <b695b531-eb98-87f1-45c8-13f2ed3973a8@enterprisedb.com>
 <CAN55FZ1UFQfKifUV=oAf+WseCxD0Kq3g_AvWEEety9VneMvzvw@mail.gmail.com>
 <0fff0827-c1f5-d29c-2ee3-dc8c871176bf@enterprisedb.com>
 <CAN55FZ1=-jb38PujfcMWjAH8vDTYoxrgvz_oha_p+q0quMtzCw@mail.gmail.com>
 <9df9067d-5651-2d3e-e838-9e5d273f5524@enterprisedb.com>
 <5250E85B-4A97-4DA1-8900-7DCDE925441A@yesql.se>
 <CAN55FZ3GLXkWHpVwwU=OpLxid2vjSSsvrpW8MRPMWzC3JRvD5w@mail.gmail.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <CAN55FZ3GLXkWHpVwwU=OpLxid2vjSSsvrpW8MRPMWzC3JRvD5w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/7a662264-6e04-7bb7-a4aa-1ac03ae3436c%40enterprisedb.com>
Precedence: bulk

On 09.03.23 15:12, Nazir Bilal Yavuz wrote:
> Hi,
> 
> On Thu, 9 Mar 2023 at 16:54, Daniel Gustafsson <daniel@yesql.se> wrote:
>>
>>> On 9 Mar 2023, at 14:45, Peter Eisentraut <peter.eisentraut@enterprisedb.com> wrote:
>>
>>> How about we just hardcode "openssl" here instead?  We could build that array dynamically, of course, but maybe we leave that until we actually have a need?
>>
>> At least for 16 keeping it hardcoded is an entirely safe bet so +1 for leaving
>> additional complexity for when needed.
> 
> We already have the 'ssl_library' variable. Can't we use that instead
> of hardcoding 'openssl'? e.g:
> 
> summary(
>    {
>      'ssl': ssl.found() ? [ssl, '(@0@)'.format(ssl_library)] : ssl,
>    },
>    section: 'External libraries',
>    list_sep: ', ',
> )
> 
> And it will output:
> ssl                    : YES 3.0.8, (openssl)
> 
> I don't think that using 'ssl_library' will increase the complexity.

Then we might as well use ssl_library as the key, like:

{
    ...
    'selinux': selinux,
    ssl_library: ssl,
    'systemd': systemd,
    ...
}