Content-Type: multipart/alternative;
 boundary="------------qXexLa3F9tU6KJnZTPOsJsIT"
Message-ID: <7ac0e5c5-86ca-4301-af5e-b107e4ff0a58@tantorlabs.com>
Date: Thu, 15 Aug 2024 12:50:58 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Vacuum statistics
To: Alena Rybakina <a.rybakina@postgrespro.ru>,
 Andrei Zubkov <zubkov@moonset.ru>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>, a.lepikhov@postgrespro.ru
References: <bee34abe-fe87-49b3-8523-8ae19e641ccf@yandex.ru>
 <ff99283d-f9d4-4b37-b4fa-3a433fb408a4@tantorlabs.com>
 <e1f5b560691a4fe693625d529e19e13959210568.camel@moonset.ru>
 <53c47c2d-72a5-44f2-900c-9973b2af1808@tantorlabs.com>
 <c82e7776-7841-42a0-9247-878584174750@tantorlabs.com>
 <4a902cea-54fb-41b5-b208-b84731a5f577@postgrespro.ru>
Content-Language: en-US
From: Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>
In-Reply-To: <4a902cea-54fb-41b5-b208-b84731a5f577@postgrespro.ru>
Archived-At: <https://www.postgresql.org/message-id/7ac0e5c5-86ca-4301-af5e-b107e4ff0a58%40tantorlabs.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------qXexLa3F9tU6KJnZTPOsJsIT
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 15.8.24 11:49, Alena Rybakina wrote:
>>
>> I have some suggestions:
>>
>>  1. pgstatfuncs.c in functions tuplestore_put_for_database() and
>>     tuplestore_put_for_relation you can remove 'nulls' array if
>>     you're sure that columns cannot be NULL.
>>
> We need to use this for tuplestore_putvalues function. With this 
> function, we fill the table with the values of the statistics.

Ah, right! I'm sorry.


>> 1.
>>
>>
>>
>>  2. These functions are almost the same and I would think of writing
>>     one function depending of type 'ExtVacReportType'
>>
> I'm not sure that I fully understand what you mean. Can you explain it 
> more clearly, please?


Ah, I didn't notice that the size of all three tables is different. 
Therefore, it won't be possible to write one function instead of two to 
avoid code duplication. My mistake.


--------------qXexLa3F9tU6KJnZTPOsJsIT
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 7bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p><br>
    </p>
    <div class="moz-cite-prefix">On 15.8.24 11:49, Alena Rybakina wrote:</div>
    <blockquote type="cite"
      cite="mid:4a902cea-54fb-41b5-b208-b84731a5f577@postgrespro.ru">
      <blockquote type="cite"
        cite="mid:53c47c2d-72a5-44f2-900c-9973b2af1808@tantorlabs.com">
        <p>I have some suggestions:</p>
        <ol>
          <li>pgstatfuncs.c in functions tuplestore_put_for_database()
            and tuplestore_put_for_relation you can remove 'nulls' array
            if you're sure that columns cannot be NULL. <br>
          </li>
        </ol>
      </blockquote>
      We need to use this for tuplestore_putvalues function. With this
      function, we fill the table with the values of the statistics.<br>
    </blockquote>
    <p>Ah, right! I'm sorry.<br>
    </p>
    <p><br>
    </p>
    <blockquote type="cite"
      cite="mid:4a902cea-54fb-41b5-b208-b84731a5f577@postgrespro.ru">
      <blockquote type="cite"
        cite="mid:53c47c2d-72a5-44f2-900c-9973b2af1808@tantorlabs.com">
        <ol>
          <li> <br>
          </li>
          <li>These functions are almost the same and I would think of
            writing one function depending of type 'ExtVacReportType'</li>
        </ol>
      </blockquote>
      I'm not sure that I fully understand what you mean. Can you
      explain it more clearly, please?<br>
    </blockquote>
    <p><br>
    </p>
    <p>Ah, I didn't notice that the size of all three tables is
      different. Therefore, it won't be possible to write one function
      instead of two to avoid code duplication. My mistake.</p>
    <p><br>
      <br>
    </p>
  </body>
</html>

--------------qXexLa3F9tU6KJnZTPOsJsIT--