User-Agent: Cyrus-JMAP/3.5.0-alpha0-4410-g5528bb82a8-fm-20211130.003-g5528bb82
Mime-Version: 1.0
Message-Id: <7ad38afd-eb5b-47b7-8d1c-49a7b2637367@www.fastmail.com>
In-Reply-To: 
 <CAA4eK1+=d-fbH9MXoVbxHu0qchYE0mC1zQH6RCHG2UQ0YH_5Lw@mail.gmail.com>
References: 
 <CAHut+PvSHjUsrrgVeE43hN8AZVPa8VqQ=GH1LYJFSubp2W_dhA@mail.gmail.com>
 <CAHut+PtRdXzPpm3qv3cEYWWfVUkGT84EopEHxwt95eo_cG_3eQ@mail.gmail.com>
 <OS0PR01MB571625D4A5CC1DAB4045B2BB94919@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <CAHut+Pu1AMDUwBNKeevLKOO2=M6ZBXpddi-s7fhqBpMxMWUQpA@mail.gmail.com>
 <CAFPTHDZgxAbLA98HZkN-JNHoHXSBGtK4eAGQrXam5JQY6Zx7wg@mail.gmail.com>
 <OS0PR01MB61132C0E4FFEE73D34AE9823FB999@OS0PR01MB6113.jpnprd01.prod.outlook.com>
 <CAJcOf-d0=Pnv8qpBaN5WM5wtmhT3EJ64crWtfPBtiwtK8iUEwg@mail.gmail.com>
 <CAHut+Pv-D4rQseRO_OzfEz2dQsTKEnKjBCET9Z-iJppyT1XNMQ@mail.gmail.com>
 <CALDaNm2bq-Zab3i5pvuA3UTxHvo3BqPwmgXbyznpw5vz4=fxpA@mail.gmail.com>
 <OS0PR01MB57162EB465A0E6BCFDF9B3F394609@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <CAA4eK1KZ+N=vfgqeUuZfRLRC+WyNBFvU9Ei7kF-7OPXnTX2WrA@mail.gmail.com>
 <OS0PR01MB5716F2C3904CB807050010A394619@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <CAA4eK1KVUs2s3PTcTTRj3qdmUzEDG7PQ5Xq_b1J7zMsi2OvE5w@mail.gmail.com>
 <OS0PR01MB57168FD9932E3F42406EB13B94629@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <CAJcOf-dz0srExG0NPPgXh5X8eL2uxk7C=cZoGTbf8cNqoRUY6w@mail.gmail.com>
 <CAA4eK1+8UqT5b3Ha42Wt07668yxs9KkKvV5r==vT9KfRUGCs-g@mail.gmail.com>
 <ca8d270d-f930-4d15-9f24-60f95b364173@www.fastmail.com>
 <CAA4eK1+hVXfOSScbf5LUB=5is=wYaC6NBhLxuvetbWQnZRnsVQ@mail.gmail.com>
 <CAFiTN-sfE6RSumGXxkpd1RVkcG14TdMiavWGXm_78mf=F_8+VQ@mail.gmail.com>
 <CAA4eK1+=d-fbH9MXoVbxHu0qchYE0mC1zQH6RCHG2UQ0YH_5Lw@mail.gmail.com>
Date: Tue, 30 Nov 2021 22:25:08 -0300
From: "Euler Taveira" <euler@eulerto.com>
To: "Amit Kapila" <amit.kapila16@gmail.com>,
 "Dilip Kumar" <dilipbalaut@gmail.com>
Cc: "Greg Nancarrow" <gregn4422@gmail.com>,
 "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>,
 "vignesh C" <vignesh21@gmail.com>, "Peter Smith" <smithpb2250@gmail.com>,
 "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>,
 "Ajin Cherian" <itsajin@gmail.com>, "Rahila Syed" <rahilasyed90@gmail.com>,
 "Peter Eisentraut" <peter.eisentraut@enterprisedb.com>,
 =?UTF-8?Q?=C3=96nder_Kalac=C4=B1?= <onderkalaci@gmail.com>,
 japin <japinli@hotmail.com>, "Michael Paquier" <michael@paquier.xyz>,
 "David Steele" <david@pgmasters.net>, "Craig Ringer" <craig@2ndquadrant.com>,
 "Amit Langote" <amitlangote09@gmail.com>,
 "PostgreSQL Hackers" <pgsql-hackers@lists.postgresql.org>
Subject: Re: row filtering for logical replication
Content-Type: multipart/alternative;
 boundary=7e10052d9253410e8c63a2e37b9f0fa5
Archived-At: 
 <https://www.postgresql.org/message-id/7ad38afd-eb5b-47b7-8d1c-49a7b2637367%40www.fastmail.com>
Precedence: bulk

--7e10052d9253410e8c63a2e37b9f0fa5
Content-Type: text/plain

On Tue, Nov 30, 2021, at 7:25 AM, Amit Kapila wrote:
> On Tue, Nov 30, 2021 at 11:37 AM Dilip Kumar <dilipbalaut@gmail.com> wrote:
> >
> > What about the initial table sync? during that, we are going to
> > combine all the filters or we are going to apply only the insert
> > filters?
> >
> 
> AFAIK, currently, initial table sync doesn't respect publication
> actions so it should combine all the filters. What do you think?
I agree. If you think that it might need a row to apply DML commands (UPDATE,
DELETE) in the future or that due to a row filter that row should be available
in the subscriber (INSERT-only case), it makes sense to send all rows that
satisfies any row filter.

The current code already works this way. All row filter are combined into a
WHERE clause using OR. If any of the publications don't have a row filter,
there is no WHERE clause.


--
Euler Taveira
EDB   https://www.enterprisedb.com/

--7e10052d9253410e8c63a2e37b9f0fa5
Content-Type: text/html
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html><html><head><title></title><style type=3D"text/css">p.Mso=
Normal,p.MsoNoSpacing{margin:0}</style></head><body><div>On Tue, Nov 30,=
 2021, at 7:25 AM, Amit Kapila wrote:<br></div><blockquote type=3D"cite"=
 id=3D"qt" style=3D""><div>On Tue, Nov 30, 2021 at 11:37 AM Dilip Kumar =
&lt;<a href=3D"mailto:dilipbalaut@gmail.com">dilipbalaut@gmail.com</a>&g=
t; wrote:<br></div><div>&gt;<br></div><div>&gt; What about the initial t=
able sync? during that, we are going to<br></div><div>&gt; combine all t=
he filters or we are going to apply only the insert<br></div><div>&gt; f=
ilters?<br></div><div>&gt;<br></div><div><br></div><div>AFAIK, currently=
, initial table sync doesn't respect publication<br></div><div>actions s=
o it should combine all the filters. What do you think?<br></div></block=
quote><div>I agree. If you think that it might need a row to apply DML c=
ommands (UPDATE,<br></div><div>DELETE) in the future or that due to a ro=
w filter that row should be available<br></div><div>in the subscriber (I=
NSERT-only case), it makes sense to send all rows that<br></div><div>sat=
isfies any row filter.<br></div><div><br></div><div>The current code alr=
eady works this way. All row filter are combined into a<br></div><div>WH=
ERE clause using OR. If any of the publications don't have a row filter,=
<br></div><div>there is no WHERE clause.<br></div><div><br></div><div><b=
r></div><div id=3D"sig112409080"><div class=3D"signature">--<br></div><d=
iv class=3D"signature">Euler Taveira<br></div><div class=3D"signature">E=
DB&nbsp;&nbsp; <a href=3D"https://www.enterprisedb.com/">https://www.ent=
erprisedb.com/</a><br></div></div><div><br></div></body></html>
--7e10052d9253410e8c63a2e37b9f0fa5--