Feedback-ID: ia2694551:Fastmail
MIME-Version: 1.0
Date: Sun, 06 Apr 2025 06:56:30 +0200
From: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@alvh.no-ip.org>
To: "jian he" <jian.universality@gmail.com>,
 "Rushabh Lathia" <rushabh.lathia@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Message-Id: <7b188cf1-c618-42cc-bd18-27dfcc6e8ea4@app.fastmail.com>
In-Reply-To: 
 <CACJufxF3hJL+Lw5CLp56SLoigMwzfekDRQ5-_RJybMQaXRgT=w@mail.gmail.com>
References: <f3eaea9d-f90f-4c86-9df1-f8b549732f9b@eisentraut.org>
 <202504030807.sj5yexcmrgpq@alvherre.pgsql>
 <CAGPqQf2jXkkcHzicPJD6_PjMCp1cVG-ZNtftp9cvWn6XUve9wA@mail.gmail.com>
 <CACJufxF3hJL+Lw5CLp56SLoigMwzfekDRQ5-_RJybMQaXRgT=w@mail.gmail.com>
Subject: Re: Support NOT VALID / VALIDATE constraint options for named NOT NULL
 constraints
Content-Type: multipart/alternative;
 boundary=ef28c9e77625455983bdd50c954f7338
Archived-At: <https://www.postgresql.org/message-id/7b188cf1-c618-42cc-bd18-27dfcc6e8ea4%40app.fastmail.com>
Precedence: bulk

--ef28c9e77625455983bdd50c954f7338
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

Hi

I've been giving this some final polish which have me time to think it through, and I think Peter is right. We should not be adding the new column, but instead RelationBuildTupleDesc should use its existing scan of pg_constraint to determine validity status of constraints. We may need in addition a further value for attnullability that means unknown, "a constraint exists but we don't know yet if it's valid or invalid" for the times when we scanned pg_attribute but not yet pg_constraint. I think it's not too large a patch on top of that we have.

I'm going on a little excursion now but should be back to work on this in a couple of hours.


--ef28c9e77625455983bdd50c954f7338
Content-Type: text/html
Content-Transfer-Encoding: 7bit

<!DOCTYPE html><html><head><title></title><style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div>Hi<br></div><div><br></div><div>I've been giving this some final polish which have me time to think it through, and I think Peter is right. We should not be adding the new column, but instead RelationBuildTupleDesc should use its existing scan of pg_constraint to determine validity status of constraints. We may need in addition a further value for attnullability that means unknown, "a constraint exists but we don't know yet if it's valid or invalid" for the times when we scanned pg_attribute but not yet pg_constraint. I think it's not too large a patch on top of that we have.</div><div><br></div><div>I'm going on a little excursion now but should be back to work on this in a couple of hours.</div><br><div><br></div></body></html>
--ef28c9e77625455983bdd50c954f7338--