Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rO42b-000xTa-Rf for pgsql-hackers@arkaria.postgresql.org; Thu, 11 Jan 2024 23:00:50 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rO42a-00FmgS-Vm for pgsql-hackers@arkaria.postgresql.org; Thu, 11 Jan 2024 23:00:48 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rO42a-00FmgK-Ik for pgsql-hackers@lists.postgresql.org; Thu, 11 Jan 2024 23:00:48 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rO42X-0015Cu-Kd for pgsql-hackers@lists.postgresql.org; Thu, 11 Jan 2024 23:00:47 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id BD4B45C017D; Thu, 11 Jan 2024 18:00:44 -0500 (EST) Received: from imap49 ([10.202.2.99]) by compute2.internal (MEProxy); Thu, 11 Jan 2024 18:00:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eulerto.com; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1705014044; x=1705100444; bh=bHAkySp3GW Jlnj6ZHZ4lRKL84xTgGWFefPmtiY8p1vk=; b=ZcYlquyD5iYTnoXqJ9aAqa6VrC vnvaNO32/o0tnT2+bVnNJZc+qrHcZJBmLETCWTKCVX2kX1PXqjpZQCMKwe2TAc3G +wOCVl/9OwzwwHm+/ExSPTlcxhw4yGPbMTMcrdwUJxA0s9F4ahg835xjZ96k+/nl g+1eJcDs1ZR2zlMfVfpHHG6rpjOuiwmp29AW7shSgPAu2RVJ0iYgToCVaOeNtByJ pgLR/P4SRvi8lHjUXMWmMEQ3ccL/Xwj9N5zG4SonStMvpniSNFq3u6Yz7Q25g9vn FnxcrYs/lyARdcma6TyTcQvlKLsknLrIXxjwGsq6I74OYoZySuXUES/hQGHw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1705014044; x=1705100444; bh=bHAkySp3GWJlnj6ZHZ4lRKL84xTg GWFefPmtiY8p1vk=; b=YAVCVkS2feZOTGcvbnM0G0Z3HwE6nPGAUHdvDAujsNAL Y+hTFKL+ZT5g8olRLrdtocucgYouI6pnGTe4KecSio4xc8UHhILM6rJsh042dBRJ QiAnSmt7Fqf8/6UU2YDPWBCmF0m1GEyM4XFBkZSjdtIhRtnfe4AQQLy/9nar+d7e SBOHovDwp+CVEb8BppiusD2dska4axUB3KXfYb4As2L6Y1tvC+//+zzS6otb9Cdh CkJHj7QdsKS8ZxAgR9eUADHCPmOgMcH8Ck78C9P2loVMIHqX25M5WjSRKxDmV1DV lxDKM4LIUhJRhg5JLqQrxsvRn6LLuwElMPcV/UWDUg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdeigedgtdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsegrtderreerredtnecuhfhrohhmpedfgfhu lhgvrhcuvfgrvhgvihhrrgdfuceovghulhgvrhesvghulhgvrhhtohdrtghomheqnecugg ftrfgrthhtvghrnhepgfffjedviedvkedviedvteduieekudeivedthffhuddvteegleet ieffkeeghfdvnecuffhomhgrihhnpegvnhhtvghrphhrihhsvggusgdrtghomhenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegvuhhlvghrsegv uhhlvghrthhordgtohhm X-ME-Proxy: Feedback-ID: i0c21471d:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 47F0615A0093; Thu, 11 Jan 2024 18:00:44 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-1374-gc37f3abe3d-fm-20240102.001-gc37f3abe MIME-Version: 1.0 Message-Id: <7b6e75fc-324e-4734-b4ed-232fc6359e70@app.fastmail.com> In-Reply-To: References: <5ac50071-f2ed-4ace-a8fd-b892cffd33eb@www.fastmail.com> <4710d895-689a-4ae6-b8e3-344286dbf970@app.fastmail.com> <96e3b739-d63d-4d35-90a3-7869465b7167@eisentraut.org> <2736443c-58e3-42df-8cc4-8c66106e3da5@app.fastmail.com> Date: Thu, 11 Jan 2024 20:00:18 -0300 From: "Euler Taveira" To: "kuroda.hayato@fujitsu.com" , "pgsql-hackers@lists.postgresql.org" Cc: "Shlok Kyal" , "vignesh C" , "Michael Paquier" , "Peter Eisentraut" , "Andres Freund" , "Ashutosh Bapat" , "Amit Kapila" Subject: Re: speed up a logical replica setup Content-Type: multipart/alternative; boundary=caf2ec5675804505822d77e9051f44f8 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --caf2ec5675804505822d77e9051f44f8 Content-Type: text/plain On Thu, Jan 11, 2024, at 9:18 AM, Hayato Kuroda (Fujitsu) wrote: > > I have been concerned that the patch has not been tested by cfbot due to the > application error. Also, some comments were raised. Therefore, I created a patch > to move forward. > I also tried to address some comments which is not so claimed by others. > They were included in 0003 patch. [I removed the following part in the previous email and couldn't reply to it...] > * 0001 patch > It is almost the same as v3-0001, which was posted by Euler. > An unnecessary change for Mkvcbuild.pm (this file was removed) was ignored. v5 removes the MSVC support. > * 0002 patch > This contains small fixes to keep complier quiet. I applied it. Although, I used a different approach for format specifier. > * 0003 patch > This addresses comments posted to -hackers. For now, this does not contain a doc. > Will add if everyone agrees these idea. I didn't review all items but ... > 1. > An option --port was added to control the port number for physical standby. > Users can specify a port number via the option, or an environment variable PGSUBPORT. > If not specified, a fixed value (50111) would be used. My first reaction as a new user would be: why do I need to specify a port if my --subscriber-conninfo already contains a port? Ugh. I'm wondering if we can do it behind the scenes. Try a range of ports. > 2. > A FATAL error would be raised if --subscriber-conninfo specifies non-local server. Extra protection is always good. However, let's make sure this code path is really useful. I'll think a bit about it. > 3. > Options -o/-O were added to specify options for publications/subscriptions. Flexibility is cool. However, I think the cost benefit of it is not good. You have to parse the options to catch preliminary errors. Things like publish only delete and subscription options that conflicts with the embedded ones are additional sources of failure. > 4. > Made standby to save their output to log file. It was already done in v5. I did in a different way. > 5. > Unnecessary Assert in drop_replication_slot() was removed. Instead, I fixed the code and keep the assert. -- Euler Taveira EDB https://www.enterprisedb.com/ --caf2ec5675804505822d77e9051f44f8 Content-Type: text/html Content-Transfer-Encoding: quoted-printable
On Thu, Jan 11,= 2024, at 9:18 AM, Hayato Kuroda (Fujitsu) wrote:

I have been concer= ned that the patch has not been tested by cfbot due to the
application error. Also, some comments were raised. Therefore, I create= d a patch
to move forward.
I also tried to a= ddress some comments which is not so claimed by others.
Th= ey were included in 0003 patch.

[I removed the following part in the previous email and couldn't reply= to it...]

* 0001 patch
It is almost the same as v3-00= 01, which was posted by Euler.
An unnecessary change for M= kvcbuild.pm (this file was removed) was ignored.
<= div>
v5 removes the MSVC support.

=
* 0002 patch
This contains small fixes to keep complier quiet.

I applied it. Although, I used a different ap= proach for format specifier.

* 0003 patch
This address= es comments posted to -hackers. For now, this does not contain a doc.
Will add if everyone agrees these idea.

I didn't review all items but ...
1.
=
An option --port was added to control the port number for physical = standby.
Users can specify a port number via the option, o= r an environment variable PGSUBPORT.
If not specified, a f= ixed value (50111) would be used.

<= div>My first reaction as a new user would be: why do I need to specify a= port if my
--subscriber-conninfo already contains a port?= Ugh. I'm wondering if we can do
it behind the scenes. Try= a range of ports.

2.
A FATAL error would be raised if -= -subscriber-conninfo specifies non-local server.
<= div>
Extra protection is always good. However, let's make = sure this code path is
really useful. I'll think a bit abo= ut it.

3. 
Options -o/-O were added to specify op= tions for publications/subscriptions.

Flexibility is cool. However, I think the cost benefit of it is = not good. You
have to parse the options to catch prelimina= ry errors. Things like publish only
delete and subscriptio= n options that conflicts with the embedded ones are
additi= onal sources of failure.

4. 
Made standby to save= their output to log file.

It = was already done in v5. I did in a different way.

5. 
=
Unnecessary Assert in drop_replication_slot() was removed.

Instead, I fixed the code and keep the= assert.


--
Euler Tav= eira
EDB   https://www.enterprisedb.com/

--caf2ec5675804505822d77e9051f44f8--