Message-ID: <7b7d46b1-d6f7-eb10-55c9-aa45fce57781@enterprisedb.com>
Date: Thu, 2 Nov 2023 18:49:34 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: Detoasting optionally to make Explain-Analyze less misleading
Content-Language: en-US
To: stepan rutz <stepan.rutz@gmx.de>, Tom Lane <tgl@sss.pgh.pa.us>,
 Matthias van de Meent <boekewurm+postgres@gmail.com>
Cc: pgsql-hackers@postgresql.org
References: <ca0adb0e-fa4e-c37e-1cd7-91170b18cae1@gmx.de>
 <CAEze2WhXYCJ8=ZBTbRTp9rGbvju9LK6UO7hodECKWgU-_a==aw@mail.gmail.com>
 <2802772.1694532399@sss.pgh.pa.us>
 <ce7edfd9-dcc5-2203-5ce5-051ca229b75a@gmx.de>
 <03f952d6-b773-be93-e5d5-8f9ea9c2d461@gmx.de>
From: Tomas Vondra <tomas.vondra@enterprisedb.com>
In-Reply-To: <03f952d6-b773-be93-e5d5-8f9ea9c2d461@gmx.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/7b7d46b1-d6f7-eb10-55c9-aa45fce57781%40enterprisedb.com>
Precedence: bulk

Hi,

On 9/15/23 22:09, stepan rutz wrote:
> Hi,
> 
> please see a revised version yesterday's mail. The patch attached now
> provides the following:
> 
> EXPLAIN(ANALYZE,SERIALIZE)
> 
> and
> 
> EXPLAIN(ANALYZE,SERIALIZEBINARY)
> 

I haven't looked at the patch in detail yet, but this option name looks
a bit strange/inconsistent. Either it should be SERIALIZE_BINARY (to
match other multi-word options), or maybe there should be just SERIALIZE
with a parameter to determine text/binary (like FORMAT, for example).

So we'd do either

    EXPLAIN (SERIALIZE)
    EXPLAIN (SERIALIZE TEXT)

to get serialization to text (which I guess 99% of people will do), or

    EXPLAIN (SERIALIZE BINARY)

to get binary.


regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company