Message-ID: <7b8e2b7a-d7c3-40a2-be61-424d14cf908f@dunslane.net>
Date: Tue, 12 Aug 2025 18:21:01 -0400
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] OAuth: fix performance bug with stuck multiplexer events
To: Jacob Champion <jacob.champion@enterprisedb.com>,
 =?UTF-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>
Cc: Thomas Munro <thomas.munro@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Daniel Gustafsson <daniel@yesql.se>, Peter Eisentraut
 <peter@eisentraut.org>, Tom Lane <tgl@sss.pgh.pa.us>
References: 
 <CAOYmi+nDZxJHaWj9_jRSyf8uMToCADAmOfJEggsKW-kY7aUwHA@mail.gmail.com>
 <CAOYmi+mRhhzGUvrcdickepAnsdaGbqhNcboNe4-YvgtkSzGNbQ@mail.gmail.com>
 <CA+hUKGLyS-GK_rkENaVbFVTa4VJ+reJxWtt+q4gmgNUXhptfYA@mail.gmail.com>
 <CAOYmi+k1q3feeMxfbaJA=+hx+XnOFQA0z2JU+0igA7fTUZTmoA@mail.gmail.com>
 <CA+hUKG+H1gwDh96jn5jB6Q3HyXrSC9x2y=uQJAthT8NLs6GN_Q@mail.gmail.com>
 <CAOYmi+n1xRNCDnwZzigXVk8V=+sr7ZzuGpJ0tAyozX-zQT19Gg@mail.gmail.com>
 <CAOYmi+mvk8Y7btYJhBzOGiNTY3cCpYZKjhA4-TP2Lkb=zOr4oQ@mail.gmail.com>
 <87ldnvgkdq.fsf@wibble.ilmari.org>
 <CAOYmi+=9J0nA7XfUCaEdjUdAb9+L6nLoJCEGRYXZbUtZ_o2k5Q@mail.gmail.com>
 <87fre1h90x.fsf@wibble.ilmari.org>
 <CAOYmi+nUAU+eJx__j6Uhmn3QV2G6NTdbL-_OJA1YQmscmKZiqw@mail.gmail.com>
 <87cy95h5uh.fsf@wibble.ilmari.org>
 <CAOYmi+m6t7r3jvDH-vUmy+GS_ZhstnPViE6Hee8c_M=_ASM9hg@mail.gmail.com>
 <CAOYmi+n6ORcmV10k+dAs+p0b9QJ4bfpk0WuHQaF5ODXxM8Y36A@mail.gmail.com>
From: Andrew Dunstan <andrew@dunslane.net>
Content-Language: en-US
Autocrypt: addr=andrew@dunslane.net; keydata=
 xsBNBE7KWFkBCAClridxur2AIc7eW2AR7izbfp3EnNefie2HbLF0izW5Ik5UjX2HBXBx4syI
 gY6b0ugohXrr274+baoAlvSbq6cAoQuEVrk5IZFzt20b1Xkx65FwGSEj526yiKLocqkJceSq
 Xr9xcA5SGY+FZv441chh5SU92v4q6z+6LPpoHOh97ptAVXZYNTtU0LevyvD5lja0TzbvJm6C
 eFXitJfnm1pLEr0DGJCR/iUOl/N62Kh4855zZC7NHIjQHPOvV5Stz/l5ilDhvGVk+xkXFPys
 SjZoUr1rXhYLpiyi5sR0X9FHXT0KnGuz1F5ERO7ZTLSSQ6fJwPj6gOk9K+vvoKvoeql5ABEB
 AAHNJEFuZHJldyBEdW5zdGFuIDxhbmRyZXdAZHVuc2xhbmUubmV0PsLAlwQTAQgAQQIbAwIX
 gAIZAQULCQgHAwUVCgkICwUWAgMBAAIeBRYhBOQ+WEYd/Hy/RGkVpZn6f8tZ/DuBBQJoGNGd
 BQkdEO8nAAoJEJn6f8tZ/DuBq74H/jkTR4Zi3stbw+xC7v2u3QozssK7MYPL2AsVfh7OealS
 h182fiWXpfvmmAB7WUHbhk9GC2RAOnHI/2d2jgKaMLAHsGYOT0YopTVIwRY43fCw/mK67yxc
 wmDcX+zyKfLaivNbf5A7QPLNwda98bEAMSJ8Sn652Uc6cA8t3uKGsVzbRBQOoYzjgvBCfSrE
 9ql3PDNg0l4BfAqabd2f70ZUm9VAMEPrgv/v2xI7M2XiL4g5BVmqLCOwxLM8RMCotCuoweUr
 VO43DeBCIDwLxotMJKvGWDjBzQYlU1NPUAtNcz/gN9ITUe1VUGjyvGj4u1lxBOcQQUw7l1+T
 5moZ4iZxXzvOwE0ETspYWQEIANGc4zQULOxhbqO2dyD51YhqCNRmm9oKWaqf+wmW4tpDe/VV
 cxAnNizd4LWCHfzpb5cHAtGkOPePMfzWVf6nvdF7d3eglbtf59+zG7O7llV0xSSoFiieQBsr
 GvqDInXYX/4mRRXMtyhM353/tixC9RWLs1oofyYmCPPXXY7h9R7en3B8BoVrRFcdzlIY/NFN
 hFGW/9dkEiGjgna2Rk6e15kln4ZvFBWUg23p93w/pqXcxY6+k/8TEk+C4R+M6w7o2PLGOjdZ
 +kPiUcw5H85zf/yZJwQXzisXaNduwWB6Vads9YC9dj6kPR1c4VGRqAaYL++LAEOqrlvm2Tvq
 QqZRtnEAEQEAAcLAfAQYAQgAJgIbDBYhBOQ+WEYd/Hy/RGkVpZn6f8tZ/DuBBQJoGNI2BQkd
 EODdAAoJEJn6f8tZ/DuBfw0IAKTsfD40teP/pp+bsLLMSxPXUYrrprTj7WFB5v61p6dkpSr/
 qXmMlyahdxQFaPmfVgVirB1Vk/kHiWNnnGjfUV9nB2Zg9LI0Xb9/ts3LsUiRWXzG3tkMY6XL
 vsVOxW4XFRND9l2q+WW93aZ1DZl+fqWfYgMvsusFRhmGFOKTRfKPta2Pkv+AhA24N4+PrR5p
 bU4k2MO8PAGiK8eaYKGFG1bHKuAvoDoF7WXJ3FHxuWqLnKEt4dfOLm5pAe3zq1Lt6q8azT9i
 QWGpSAK5vQUWQHBHpiDjdPeqKZ6HiAXIIKfSmb+jrvXBqoP+D6/K7rUjG2aXiRtTIAXms9sm
 VRu7cmw=
In-Reply-To: 
 <CAOYmi+n6ORcmV10k+dAs+p0b9QJ4bfpk0WuHQaF5ODXxM8Y36A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/7b8e2b7a-d7c3-40a2-be61-424d14cf908f%40dunslane.net>
Precedence: bulk


On 2025-08-12 Tu 6:11 PM, Jacob Champion wrote:
> On Fri, Aug 8, 2025 at 2:31 PM Jacob Champion
> <jacob.champion@enterprisedb.com> wrote:
>> Well, thank you for the explanation. I'll make that change.
> Done in v5.
>
> v5-0001 is planned for backport to 18 once the freeze lifts. It
> ensures that -lm is part of the link line for libpq-oauth, since the
> module uses floor(). I probably wouldn't have ever noticed, except
> that the new test executable, which uses the same link flags,
> complained on Clang [1].
>
> (In that thread, I incorrectly said the problem was with "Meson
> animals". The Meson side is fine, and both alligator and bushmaster
> use Autoconf, so I'm not sure how I ended up with that idea.)
>
> v5-0002 should fix the more general buildfarm failure that caused the
> revert. The farm finds the new t/ subdirectory and starts running Make
> on src/interfaces/libpq-oauth directly, bypassing the skip logic in
> src/interfaces/Makefile. So I've wrapped the "standard" top-level
> targets that build and install things in a conditional. The targets
> that clean things up have been left alone, at Tom's suggestion in [1].
>
> Thanks,
> --Jacob
>
> [1] https://postgr.es/m/CAOYmi%2Bm%3DxY0P_uAzAP_884uF-GhQ3wrineGwc9AEnb6fYxVqVQ%40mail.gmail.com


I don't think that's quite going to work. The buildfarm will now get a 
"target not found"  in the without-curl case, I suspect. I think you'll 
need an alternative definition of the check target.


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com