Message-ID: <7beb722dd016bf54f1c78bfd6d44a684e28da624.camel@moonset.ru>
Subject: Re: Normalization of utility queries in pg_stat_statements
From: Andrei Zubkov <zubkov@moonset.ru>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>, "Drouvot,
	Bertrand" <bertranddrouvot.pg@gmail.com>
Date: Mon, 06 Mar 2023 15:50:55 +0300
In-Reply-To: <ZAFBR1cwIq39ywX+@paquier.xyz>
References: <Y+MRdEq9W9XVa2AB@paquier.xyz> <Y+16K+q9L0yjV3zA@paquier.xyz>
	 <0e067034-e92c-302b-24ed-492bca228e26@gmail.com>
	 <Y+7n+uz6XkzJpB7z@paquier.xyz>
	 <14965f63-6d78-45ff-d029-daafe8eddb40@gmail.com>
	 <Y/Lbt12YUHSU2fYl@paquier.xyz> <Y/LcU/u8CbD+nxYp@paquier.xyz>
	 <Y/7Y9U/y/keAW3qH@paquier.xyz>
	 <1f84685f-1ffd-4937-de63-aaa1513a0b7e@gmail.com>
	 <ZAFBR1cwIq39ywX+@paquier.xyz>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.38.3-1+deb11u1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/7beb722dd016bf54f1c78bfd6d44a684e28da624.camel%40moonset.ru>
Precedence: bulk

Hi Michael!

I'm rebasing a patch "Tracking statements entry timestamp in
pg_stat_statements" for applying after this patch. I've noted that
current tests are not quite independent one from another. There is two
statements in the end of user_activity.sql test:

DROP ROLE regress_stats_user1;
DROP ROLE regress_stats_user2;

Those are done after the last pg_stat_statements_reset call in this
test file and thus, those are included in checks of wal.out file:

                                    query                             
| calls | rows | wal_bytes_generated | wal_records_generated |
wal_records_ge_rows 
-----------------------------------------------------------------------
-------+-------+------+---------------------+-----------------------+--
-------------------
 DELETE FROM pgss_wal_tab WHERE a > $1                                
|     1 |    1 | t                   | t                     | t
 DROP ROLE regress_stats_user1                                        
|     1 |    0 | t                   | t                     | t
 DROP ROLE regress_stats_user2                                        
|     1 |    0 | t                   | t                     | t

Those statements is not related to any WAL tests. It seems a little bit
incorrect to me.

Are we need some changes here?
-- 
Andrei Zubkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company