Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rmLmd-007NCE-KG for pgsql-hackers@arkaria.postgresql.org; Mon, 18 Mar 2024 22:48:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rmLmb-006wFF-Qe for pgsql-hackers@arkaria.postgresql.org; Mon, 18 Mar 2024 22:48:42 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rmLmb-006wF6-DA for pgsql-hackers@lists.postgresql.org; Mon, 18 Mar 2024 22:48:42 +0000 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rmLmY-005GIB-6H for pgsql-hackers@postgresql.org; Mon, 18 Mar 2024 22:48:40 +0000 Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-6e6f6d782e4so2931696b3a.0 for ; Mon, 18 Mar 2024 15:48:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=j-davis-com.20230601.gappssmtp.com; s=20230601; t=1710802116; x=1711406916; darn=postgresql.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=TEhaOLHobvk5Z1qDrwhVXliVSZPHMypQfMii6HuB5gU=; b=WbyaEo0jRxYOD8GPOFzA7SsijJ0pc/UTvvbx89UfyUUUtfsLYSZX2E6AWTMubhNpVv qLAc33yX1rpTzu+AMiwMyZCoadr/RFo3U5en635XxWDcwFmdJd8R0lEAZ2WmWUZOtijE 9CAUUBYPnm9ufxolXo6dsoFMXQu1oB1ihhEIDDSmtuvJZWrVKxcsPcnKJnJk5wVwTmRQ JSibzyjZ3YH/V2RSvuMiEiDt5tLi68DKyMC/yNXepoeKO/SHYVMDGyjWQqVZc4PahCNo Ie8r0WTeamsWRmme5Q2q6BBjjrLZBdWGH+zdKWNUN7NjfKD/gguWLitvfWhhMKPGytn6 dJQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710802116; x=1711406916; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=TEhaOLHobvk5Z1qDrwhVXliVSZPHMypQfMii6HuB5gU=; b=w6N7qmMevwnRjLS0D10//RKc1rlXWYeg1RrIOqWDwdrBs9syitVHAz5FR0xzATD6Sk ALg/nm/DclthY+Shpaafs73rxDei8jOE78ac75j71cDOtTw5IQXVczgdETTqTKyO5D4s cnIDQt2y403PsGJu67URDhWxybFM1RUFWUnb30zf4eRtPkSHrvA2joJNpyv+AcPsyGsu KIiCE3UfALZzCSKIriRwd0QU04bpBk/O/DBVRkRWpMDdEhLEUwYaFEValmfUku6midNl JkFA6OIR1CTc9mk4xVHoLjXZuUaH+EykmLQ7qroVth7vtH4o7I6Nc8+5SPi1+zO8FYT4 VGnQ== X-Forwarded-Encrypted: i=1; AJvYcCWh4rk+lTdddIsKUpnPBWIcUgPsrs+0bYTkvBRxFlcal21HwlVWdOh4Hb/C7j2HeXg8lfijFZzOpdnLVBqvLx51H00w8xolbhLpgWnp X-Gm-Message-State: AOJu0Yzg3G+R+EQoyEuChNEiQX1s3Xqb3BW3p+aCq81LUnVR2GRywOXr Ov81fKjnBhoumh5xGqq7k4L79L7exuh4DecKgjMmQ4Li4ozv/zFpqrnU7i+rXg== X-Google-Smtp-Source: AGHT+IHACl1DOi6Ge1Zjv7Svc/PY6SIX7f2qEH2wAFA/twdA1/0g+w72fZwTGUuwaYCXozymDkXiNw== X-Received: by 2002:a05:6a00:1783:b0:6e6:9a11:ccec with SMTP id s3-20020a056a00178300b006e69a11ccecmr15376997pfg.17.1710802116149; Mon, 18 Mar 2024 15:48:36 -0700 (PDT) Received: from jeff-laptop.lan (c-76-102-242-158.hsd1.ca.comcast.net. [76.102.242.158]) by smtp.gmail.com with ESMTPSA id a24-20020a62d418000000b006e68984419asm8772225pfh.105.2024.03.18.15.48.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Mar 2024 15:48:35 -0700 (PDT) Message-ID: <7c48fd9170b69b5dce952741cdb257e8dce88f64.camel@j-davis.com> Subject: Re: Built-in CTYPE provider From: Jeff Davis To: Tom Lane Cc: Peter Eisentraut , Daniel Verite , Robert Haas , Jeremy Schneider , pgsql-hackers@postgresql.org Date: Mon, 18 Mar 2024 15:48:34 -0700 In-Reply-To: <3703896.1710799495@sss.pgh.pa.us> References: <6f3e94c0-f174-4380-9b69-072f8a838881@manitou-mail.org> <12e4f6a78403b33c303c20e44976f891d879be09.camel@j-davis.com> <612987b5-38fa-44c6-8b78-c0be5a177a70@eisentraut.org> <2692039df6b0cac20c5e488fa0209e8958c5fedb.camel@j-davis.com> <27bb0e52-801d-4f73-a0a4-02cfdd4a9ada@eisentraut.org> <4a69d067374d2f6bfb66f5bfb2ab9a020493d49f.camel@j-davis.com> <3bc653b5d562ae9e2838b11cb696816c328a489a.camel@j-davis.com> <163f4e2190cdf67f67016044e503c5004547e5a9.camel@j-davis.com> <6bdb98e68b2b05aa71f7f934e227738eac84ecee.camel@j-davis.com> <19b34a70-f5cf-4faf-88dc-917db44ed48d@eisentraut.org> <846a7e1fa2024918b58ff7583523a2f3de9a11b4.camel@j-davis.com> <3117d30aa911b408b90420f4f280fa0c3b5851be.camel@j-davis.com> <4135cf11-206d-40ed-96c0-9363c1232379@eisentraut.org> <7451f81ba0cb512222ab759de8ca1cffe44e9acb.camel@j-davis.com> <3422201.1710711993@sss.pgh.pa.us> <3703896.1710799495@sss.pgh.pa.us> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4-0ubuntu2 MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Mon, 2024-03-18 at 18:04 -0400, Tom Lane wrote: > This is causing all CI jobs to fail the "compiler warnings" check. I did run CI before checkin, and it passed: https://cirrus-ci.com/build/5382423490330624 If I open up the windows build, I see the warning: https://cirrus-ci.com/task/5199979044667392 but I didn't happen to check this time. > Probably the best fix is the traditional >=20 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return ;=C2=A0= =C2=A0=C2=A0 /* keep compiler quiet */ >=20 > but I'm not sure what the best default result is in this function. In inverted the check so that I didn't have to choose a default. Regards, Jeff Davis