Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tlDUe-00AB8R-DO for pgsql-hackers@arkaria.postgresql.org; Thu, 20 Feb 2025 20:50:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tlDUc-00DIL5-5G for pgsql-hackers@arkaria.postgresql.org; Thu, 20 Feb 2025 20:49:58 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tlDUb-00DIKw-Ly for pgsql-hackers@lists.postgresql.org; Thu, 20 Feb 2025 20:49:58 +0000 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1tlDUZ-001xlH-0p for pgsql-hackers@lists.postgresql.org; Thu, 20 Feb 2025 20:49:56 +0000 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-4399a1eada3so12169035e9.2 for ; Thu, 20 Feb 2025 12:49:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; t=1740084592; x=1740689392; darn=lists.postgresql.org; h=autocrypt:subject:from:content-language:to:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=6YAuhWkG4uK2Cy2JPq/hRu/xoliBC7V+TmCIyHb9xIQ=; b=cDw5Ngge129qNOkFnAr1JgYkMAoO/QXSyZ6AvOYsIso26AeGUkhlnXccnzEWiRnlU+ 0aNNn1cEIarCNYcOQMMr7EzRib/U6dxvUPgq+geLUi5+DcJX5kxDAgLxqXScPnlIusKB 0ZWUDs4Tt/btrjapHUYoTfzv+kGLwNZPfaL/ZQQewuqkdOX4CfZ03wVMY3v+CObiBNYJ sML9uNx5WSqSCngld1vBRcMatopfmKtozqI9N0BDXgOUiRr9JXygurUUWXtuFAwFqJ3Z 40wzDrZV9bpafXGBnk72qHruRctGDIX0U5QmfNLKQ0UDpB/hg4o+pEoeyL3p2iiU2SZz f4Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740084592; x=1740689392; h=autocrypt:subject:from:content-language:to:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6YAuhWkG4uK2Cy2JPq/hRu/xoliBC7V+TmCIyHb9xIQ=; b=oyO3vnl/Y9p+HQs5QhqTABSJv1kHhLET35Z+ZDMthMd8gBc3QpxtNvo1uoZAJT14HH qxcOU0VRsa0jMaIpsAcvkqqXrbMyk4otKl68ykyUBxTrjELtrcy2yEHeuG+EJzXa+FCG Rn6H11sy7TvipvJ3ntTDpoWVPrhq5A72Xvi6zNwWWULRTvFPKwqkMz2Mh1u8HzefnWGM 5BUGKYJhBQDz2BzAuMQIPaecsjNDF3AOjCTCKszQWnxWrt+Zs+ZAe6bj3eWVZAB9FgIa XVG+OQTtxiklOWIOsDk2rkhijVy51+aCgUpLblFdcBPLYxqW/ID/4l9/6blEK1swJsfR 2deg== X-Gm-Message-State: AOJu0YxYt9k+Zbsj9s+RiGe63GQqztzqS5ChA8YvMYjux44Jp8Vk76ro La0rovfOcLOEpru3zPacvWmZye9uXonsSJH7BqRkJfvXv7fLcONThSu6m9oBhdRppW1CfKEagPM JJ9N/ro8lqmE1JqUl74Fv0dt1MlbSu16WCsGXPEBPqDwB0lnIHFCAQYY+OTY5KRkBX2s6Aigu/o pFaidvgFwWkWrbcGxtH2Nxk87u3U345yP72Sdtrc9CokTWmcxouxTE0jDJs75oVJRHvK08 X-Gm-Gg: ASbGncuPvDZ+7GuP5tboJIiml0sn0Wl5l0CnT9mE5kfWnWKtY+3MDqKgRUCjfhk1BV5 EtVbBKJjUaqLqNShDmKHc2bBI7ttbBGPBL+uM8aHKWcG8KNQbYqECX6iv9YxI5GQ+pJrPM/KQrg dc7X/Y5vCKPYTkl8nQ9yclBm3ADPpLH0qsqmlp9yTAnlDeWNJxqsi5LLeL/bDwnu92sMMTxSxdB PgSrIYKZx6/KTRG16oyMee6xOjtKYo86brVw0E8KYZXU2BlTE1TdwUnlur5P4LjmTRuaYVbvLrn StquV6iR/NfmGGNEVfXI/ACKeOaxK8R1VqXzghPjE2fujbGiD1KJQicUiFtomBa7TXeT0J/X X-Google-Smtp-Source: AGHT+IGbjj7bjj5kzF0Rh4SKalhLtiAtEJfwYc/5hPhVxJL6wkj6HJa1rd2iebKo20MveqMxvBGZLQ== X-Received: by 2002:a5d:6daa:0:b0:38a:87cc:fb42 with SMTP id ffacd0b85a97d-38f6e95d5famr681231f8f.21.1740084592008; Thu, 20 Feb 2025 12:49:52 -0800 (PST) Received: from ?IPV6:2a02:168:6b68:10:5e6f:69ff:fec6:a881? ([2a02:168:6b68:10:5e6f:69ff:fec6:a881]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38f259d5d8bsm21549540f8f.70.2025.02.20.12.49.51 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Feb 2025 12:49:51 -0800 (PST) Content-Type: multipart/mixed; boundary="------------4SVaYj1I0QXSSt9XOU33WNvS" Message-ID: <7c9c2f8d-ff29-48a6-bf1f-53fb278bc1ad@enterprisedb.com> Date: Thu, 20 Feb 2025 21:49:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: PostgreSQL Hackers Content-Language: en-US From: Markus Wanner Subject: Reset the output buffer after sending from WalSndWriteData Autocrypt: addr=markus@bluegap.ch; keydata= xsNNBEyA6xoBIAD2b/0sj830m1pqjX0LXY6ICB/oE4/UMxij07neWCHdGwCNGdXroz9BRucA cjRnVKnt/Xe10PjfgBMo41d20g0vBtGQnRcZzI5r98cfbwkCoND3M2Svh+/NZV9rPjfa5dBo Ihd73e/qBpmAc+YM9qGfhzgSXXg8N5lHCLo0CQxN7WrYhhB+G/mPvLjyQEenGi793R9uT5GA MLB2ZjbJXIRtdB5Nn+OILwELp08mrQrc6UwN60KmsrH1+1OxJUviMmCSjF573egAmhxdYOSQ /3JAgg5rPEAflwLodSUGFd6VQ5AaaOElqJjXTWT23YLN7r6Qq5EbF4VvsMB7ClVvXRr3vzXU dwzdukOsnXSv5Do0KL4gQvgNuBj5z//VMpHXoAQJvZpNgtdd4UFe4hJx4esJX0iGtqytl2xc QV8aZxdfksuTgzkMT+QcdcP5lB3VngxwObqyKl8NwJcDS46clNDc8qfBz5x0cCU0x4MIb179 rf9CZ84bVrTbe1zOqeu5rnb+sqxfzSX2IDaKqZEXEUz5s1+pHo3SuxkXVm/xbqJPUIFtrAgQ /lt/0UEoNyXm3wxokPTrb9C3QJNyIb3IpQhGWcmBFMNVd+Kb74gjS3IQAdjETGdVYwn1BBEk UhMQ07RnFoojFX9hfMyVALCcmuU8mdfJqdO0DfoO9Wo5VZ5CTa8094Kzg7X0oLF1/AMZoB61 uM2h3eBkzoHsSvgJVOGOZzPUD56Q+wjgJt9QMx7CyMRg2JyrLxmxDxB6e1GUyDK1QDMjq7iB nrBI4w4ivMPNC+UH15m0Kb8UmeBpKTcPnLat/2WHVeYcnm9oad9Jp6iEmCPcNsZIOkJcOxLu 1RJ+Xfeb+1owUS7oCDSwzlM6bzG1TIVcEmXFIdwC3r0Rp9U822JDDHUTapKmRSdLpO59cuZT vX9E9k0TU81WtWNsy++MfNC1ed9SrcyTKijnNGz90lb9ewB0IATzyUJpKe2VGAsvj67t9dJB pXjg5iiKlQe0ULneg+63YovSVqQpk9E5CCLzchJ3mKCHQwc1qkXOkPC715sE/2uGtdKD3ne8 rrJvSbz1bMq5G69MJ+QWenDtoFDDiz4LFwEH4uTM3tQtwtEjVnp4UeFErEshM1ZzJG2GP1E4 CWmGRBcKvpQKy5yg4i4LDApWwa6hhLzkwzRpSl+wCGDSJpo4cuDDnVzuT1LRhX0t80mrRZVi a1DY+70tFAGVHweVLWC+LHcQAIxBx3uRdOXPQzzJVM5lIxgd+Slp1aRGqmcxNCIOTofYp9rS SIggvq/JgvibJx9WHTPk46X5SZop2Fnm+lzube/fPF8MK7z830wPl+7atB+WarLayo7pMSMU OaPqmQPMoY4XABEBAAHNIU1hcmt1cyBXYW5uZXIgPG1hcmt1c0BibHVlZ2FwLmNoPsLDnAQT AQgARgIbAwcLCQgKBwQDCBUKCQgLAwIBBRYCAwEAAh4BAheAAhkBFiEE7WdiNgeE4zHiUwPW Alr+layd8xsFAlrhndcFCSEstb0ACgkQAlr+layd8xtjXx/9GhTKwxa1Los78B+3y9kmD5kI N97tpCd/vJG7oFT13EIe4OXXJiYYBClpaWw6nj/bLkmIZHo4Otc8wLGisRWE+s3L5eXHiBt+ RKlXmxamVFKGCQDhxPbUBrAsTlI5WWMkbj8J0pOYf2zfWJVRahSE+5840Hc/TzEW3gYF0oFK ZqblJO3wlgKs5MJzzsSnite9a1B40TJ7YjknHDDv9fUlr9WIoR/XIwaaphibI0tSGMYOSqSB Nu9haQv57eC2RyDz/DP8J3y5RwZJ/lfD1l9AxGCGkwFAX/VyzWjSmDvNz1kSqbs7nn57su4N aRl9TtSN/51B7j9WxIsbuyNPtmd26+KDgSteZT9DDNg3e455CZRRv2zo0LaOwpvLfsRh6F5c jnOaHYR6fBdjk8Zdw8yN1aLm2Ls0HGWzHSttBLLy7Wa75hIwrHYqz7NykMmy5bDJUvKCjmug aE5dJZ5mFsawYTV8PBxhOp+m8584pacBa0wcBrHpQr9+tNZJe8lQGLvxVVsYV+WEDUwc1MCJ tFpjS/tq420F5hLVQRCzypi8iXlohGwnlN+qRWE6NuIXBdYYuLQzed9THeNZgMd8zptGByrl FwJHPBlDMPLcyQPhJMq/4NksL+6F+iKpbclNpq3gq7soHjlqMQwUTK14LUAQcfzRkExuO7go vwtJBf286WY+LU3qG5ErdeNP1OciTKVsC4lH9GevZ0q94OJfFppPIenUK6Co7DLsM4/NKaEI JCn9LV2S1sktVLCtNsIiOjAsRS3PRcHVmSZcWDI6QIfINBj5omBiigtR9r38dCPdce+0aYXB T4RCleeyqlN/nYFQcMzRdZ/q3LbfGmhDrHUE795q4RwU8qvLIR41NwEi4dYyTKWQphA1iVaa D4clk70NrqNZtMacE99iG6k+0PQoTEw2O8BnXTcAXlu3wKaq1QsLTrEhrReqhNRiy4kAMORT dlerMgTmh4nbjBUdrhARARxruPp11Dkq3CiytSWwIbXvmIhffGBSV3mQq4iw/d5CWpzBuOzq 1b87Tnqh36yyUc9l4PkXw6vWgRdwf+0PQRl1VGzuO0j3PY4J/H6RfLMaw8y1VFGqY76c6whw XnV5QxzdBw0gl7ekvTYOz/PzDistB6yzcAqdfUZfwIOmD+ewmDzpkzZgClHzrW9tM6L3dO9o u8DkPdMDt2CgFYz6gdSPpN3KTI4ASY8A+X5u4SHhMksqm/1M7XpwGAULa77hDidI74MtVd0H WVVJjfMcg8SHyOddPDKmwHWCMVLYB5IzdCZ8ZUNplMcbVlEH0K97p/e7IVH4Bwp/aaW0+n2o ZoJZ0vjmvjdUQoCpxtOSWIYDYtDymsgSXMnK4/Xc3joZQ844BGN9KYUSCisGAQQBl1UBBQEB B0BQ7XndauIOu0Owz1dPCUbA3va75F2YNBody5GaoZI5DgMBCAfCw3wEGAEIACYWIQTtZ2I2 B4TjMeJTA9YCWv6VrJ3zGwUCY30phQIbDAUJBaOagAAKCRACWv6VrJ3zG+GxH/9PXFilXAQY CMiplBKCzAZUkHqmWvkFiC+rwQiUrr2GVLcYY3QC0pTb9Lq6sSJjgqrfrvmBgcG8Gy9PdfM6 SUb1gi6T2D6wZnWSc2lwiCIJ1sJYl9MN+c0JbkDTybFJ+17IgjUVocousBh+pN4637f9qVVB b6FIV77sw4HfH9OVGR0iAUHHqLfbA/3thlz7BjB5mbSUfu/G87kUq9IVX5Nk9MNsT4+x+Gmg WqAfcyPwhok2RlSm7UnZjjwiK4so5w1tiKqV6fwNsAntVX0ikT538gSIkB4oQINeQJ6OACVP CaB9YqysAZyEiZZazNaU5a1lXa0AUBL+kwmNOMxB/kArDvwcxZNtzKNpW6B9Xug8sawLgD8n v/FTI4j6CDZnNw9HrZi1eQ6piEI0qqvGGGQ/aXtjyGKlzkE3xZa7FzjkJQIMsitZ7ZLAgFSP +Oj9wLD0mtBEMVWA8Cx/B/DiiEjMUOfg7yRmd3NKVYLfUkQVdQf6fDLXKgiQ0+Fb+c8gWWGF HZq0aBOJZ6QcG0CXZEjDtUbxQZALrinKPrjfZWPsOM2GcYxgeLbp51f8sdMg0nzwB9UfoW1o 5HXhvcqtwehm5Ld5oHLCcJ7aUV04zvSCe0SgRpEfLtOKNVRhG+8skymV4ztjHncV0p+RtJxo J2gJiSWk3VTikdEC0V/oM65wt9VEY7LBi3CLu+jczjYyZrExZXKMfTPjyhmK2pPsW/rQS8Le e+BEOhEqlt200FhBySPzNX0/DMx0KKg6mKK6/G6DNEcSptqbGB4MsgBlKG9mzSsNd1E/nzqM MME/+UM+efSxQdTt1tTFF5cTofbCUmOcIoH/BXS3xl/K2tTUoa23pdpWLvJfM8Y4CzgmwIEi uLyWCtzqVjpqhm9f6jJr6qnSZ6hrscoV1c+rK2ok8e/tda1kPTjd3OCzP7akO+kkS7sEzvp3 XLpJm/FoWyb1j9OGDAvNyBMjZz/WJ2XbFsnt2PdvUW9Kp0oqjatwYh8kaeLZg5PTgCEYtzeo qefA3eEB5RxZgyJgjDa3wXkX9n/CczHpXxUc/qFb4FyC5CrzV+EI6eO46PYHfx478C0XurSW gmPaSsZ/uwJtEaVHjl+tWIUbpzX0gcUAG9o3Tap6bjecgJFTm4SnJaXfp5JcYJNTPPsuVWCB nI5X12lr6Cbc1wKW/uKXe6lHxEHNkflHoYvxwlkWsi3rkzyIRy1F/fwDmD8ZgySD0/AeyFoM ISHwIoDr7mqBMgvuWBrsoibaH+vYmo7aYyGsEmJ10EHFckg1MFnmmul0UN35GjyWzICKQVt5 rXX2QBDETwRSb3B+cb7tmevoHmYn61xM7Z4Aglt2l39NG4mLdrGQzHBRelRo List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------4SVaYj1I0QXSSt9XOU33WNvS Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, I recently stumbled over an issue with an unintentional re-transmission. While this clearly was our fault in the output plugin code, I think the walsender's exposed API could easily be hardened to prevent the bad consequence from this mistake. Does anything speak against the attached one line patch? Best Regards Markus --------------4SVaYj1I0QXSSt9XOU33WNvS Content-Type: text/x-patch; charset=UTF-8; name="0001-Reset-the-output-buffer-after-sending-from-WalSndWri.patch" Content-Disposition: attachment; filename*0="0001-Reset-the-output-buffer-after-sending-from-WalSndWri.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA2NWRkMjRlZDk3NWNjNTEzZTRlMGRlNWUxNzVkZmYxNmI0YjBmNmQ0IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJrdXMgV2FubmVyIDxtYXJrdXMud2FubmVyQGVu dGVycHJpc2VkYi5jb20+CkRhdGU6IFRodSwgMjAgRmViIDIwMjUgMjE6MDE6NDUgKzAxMDAK U3ViamVjdDogW1BBVENIXSBSZXNldCB0aGUgb3V0cHV0IGJ1ZmZlciBhZnRlciBzZW5kaW5n IGZyb20gV2FsU25kV3JpdGVEYXRhCgpXaGlsZSBub3Qgc3RyaWN0bHkgbmVjZXNzYXJ5LCBj bGVhcmluZyB0aGUgYnVmZmVyIHJpZ2h0IGF3YXkgYWZ0ZXIKc2VuZGluZyBwcmV2ZW50cyBh biBhY2NpZGVudGlhbCByZS1kZWxpdmVyeSBpbiBjYXNlIFdhbFNuZFdyaXRlRGF0YQppcyBj YWxsZWQgYWdhaW4uCi0tLQogc3JjL2JhY2tlbmQvcmVwbGljYXRpb24vd2Fsc2VuZGVyLmMg fCAzICsrKwogMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBh L3NyYy9iYWNrZW5kL3JlcGxpY2F0aW9uL3dhbHNlbmRlci5jIGIvc3JjL2JhY2tlbmQvcmVw bGljYXRpb24vd2Fsc2VuZGVyLmMKaW5kZXggNDQ2ZDEwYzFhN2QuLjk2ODg0Y2UxNTJmIDEw MDY0NAotLS0gYS9zcmMvYmFja2VuZC9yZXBsaWNhdGlvbi93YWxzZW5kZXIuYworKysgYi9z cmMvYmFja2VuZC9yZXBsaWNhdGlvbi93YWxzZW5kZXIuYwpAQCAtMTU2Myw2ICsxNTYzLDkg QEAgV2FsU25kV3JpdGVEYXRhKExvZ2ljYWxEZWNvZGluZ0NvbnRleHQgKmN0eCwgWExvZ1Jl Y1B0ciBsc24sIFRyYW5zYWN0aW9uSWQgeGlkLAogCS8qIG91dHB1dCBwcmV2aW91c2x5IGdh dGhlcmVkIGRhdGEgaW4gYSBDb3B5RGF0YSBwYWNrZXQgKi8KIAlwcV9wdXRtZXNzYWdlX25v YmxvY2soJ2QnLCBjdHgtPm91dC0+ZGF0YSwgY3R4LT5vdXQtPmxlbik7CiAKKwkvKiByZXNl dCB0aGUgb3V0cHV0IGJ1ZmZlciB0byBwcmV2ZW50IHJlLXNlbmRpbmcgKi8KKwlyZXNldFN0 cmluZ0luZm8oY3R4LT5vdXQpOworCiAJQ0hFQ0tfRk9SX0lOVEVSUlVQVFMoKTsKIAogCS8q IFRyeSB0byBmbHVzaCBwZW5kaW5nIG91dHB1dCB0byB0aGUgY2xpZW50ICovCi0tIAoyLjM5 LjUKCg== --------------4SVaYj1I0QXSSt9XOU33WNvS--