Content-Type: multipart/mixed; boundary="------------s9ft2o0M0wH0B3xDH2KZZymR"
Message-ID: <7cdf4ecd-8789-4d85-ab59-2b78d4d27b1f@tantorlabs.com>
Date: Fri, 21 Feb 2025 13:04:21 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To: pgsql-hackers <pgsql-hackers@postgresql.org>
From: Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>
Subject: Remove vardata parameters from eqjoinsel_inner
Archived-At: <https://www.postgresql.org/message-id/7cdf4ecd-8789-4d85-ab59-2b78d4d27b1f%40tantorlabs.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------s9ft2o0M0wH0B3xDH2KZZymR
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi hackers,

When calculating selectivity for an inner equijoin, we call 
eqjoinsel_inner, which uses unused parameters vardata1 and vardata2. 
These parameters might have been left behind accidentally when we moved 
getting sslots out of the function. I suggest removing them, as they can 
be added back at any time if needed. I attached patch with fixes.

--
Best regards,
Ilia Evdokimov,
Tantor Labs LLC.

--------------s9ft2o0M0wH0B3xDH2KZZymR
Content-Type: text/x-patch; charset=UTF-8;
 name="v1-0001-Remove-unused-vardata-parameters-in-eqjoinsel_inner.patch"
Content-Disposition: attachment;
 filename*0="v1-0001-Remove-unused-vardata-parameters-in-eqjoinsel_inner.";
 filename*1="patch"
Content-Transfer-Encoding: base64

RnJvbSAxYmY1OGM1NzI1YWI5YTkwNmY1NzExN2EyYzJlMWVlN2YyODdmNWQ1IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBJbGlhIEV2ZG9raW1vdiA8aWx5YS5ldmRva2ltb3ZA
dGFudG9ybGFicy5jb20+CkRhdGU6IEZyaSwgMjEgRmViIDIwMjUgMTI6Mzg6MTMgKzAzMDAK
U3ViamVjdDogW1BBVENIIHYxXSBSZW1vdmUgdW51c2VkIHZhcmRhdGEgcGFyYW1ldGVycyBp
biBlcWpvaW5zZWxfaW5uZXIuCgpUaGUgdmFyZGF0YSBwYXJhbWV0ZXJzIGluIGVxam9pbnNl
bF9pbm5lciBhcmUgdW51c2VkLCBzbyByZW1vdmUgdGhlbS4KVGhpcyBpcyBhIHN0YXRpYyBm
dW5jdGlvbiwgc28gdGhlIHBhcmFtZXRlcnMgY2FuIGVhc2lseSBiZSBhZGRlZCBhZ2FpbiBp
Zgp0aGV5IGFyZSBldmVyIG5lZWRlZC4KLS0tCiBzcmMvYmFja2VuZC91dGlscy9hZHQvc2Vs
ZnVuY3MuYyB8IDMgLS0tCiAxIGZpbGUgY2hhbmdlZCwgMyBkZWxldGlvbnMoLSkKCmRpZmYg
LS1naXQgYS9zcmMvYmFja2VuZC91dGlscy9hZHQvc2VsZnVuY3MuYyBiL3NyYy9iYWNrZW5k
L3V0aWxzL2FkdC9zZWxmdW5jcy5jCmluZGV4IGMyOTE4YzljODMuLjYzYjQwOGJkY2MgMTAw
NjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3V0aWxzL2FkdC9zZWxmdW5jcy5jCisrKyBiL3NyYy9i
YWNrZW5kL3V0aWxzL2FkdC9zZWxmdW5jcy5jCkBAIC0xNTAsNyArMTUwLDYgQEAgZ2V0X2lu
ZGV4X3N0YXRzX2hvb2tfdHlwZSBnZXRfaW5kZXhfc3RhdHNfaG9vayA9IE5VTEw7CiAKIHN0
YXRpYyBkb3VibGUgZXFzZWxfaW50ZXJuYWwoUEdfRlVOQ1RJT05fQVJHUywgYm9vbCBuZWdh
dGUpOwogc3RhdGljIGRvdWJsZSBlcWpvaW5zZWxfaW5uZXIoT2lkIG9wZnVuY29pZCwgT2lk
IGNvbGxhdGlvbiwKLQkJCQkJCQkgIFZhcmlhYmxlU3RhdERhdGEgKnZhcmRhdGExLCBWYXJp
YWJsZVN0YXREYXRhICp2YXJkYXRhMiwKIAkJCQkJCQkgIGRvdWJsZSBuZDEsIGRvdWJsZSBu
ZDIsCiAJCQkJCQkJICBib29sIGlzZGVmYXVsdDEsIGJvb2wgaXNkZWZhdWx0MiwKIAkJCQkJ
CQkgIEF0dFN0YXRzU2xvdCAqc3Nsb3QxLCBBdHRTdGF0c1Nsb3QgKnNzbG90MiwKQEAgLTIz
NDgsNyArMjM0Nyw2IEBAIGVxam9pbnNlbChQR19GVU5DVElPTl9BUkdTKQogCiAJLyogV2Ug
bmVlZCB0byBjb21wdXRlIHRoZSBpbm5lci1qb2luIHNlbGVjdGl2aXR5IGluIGFsbCBjYXNl
cyAqLwogCXNlbGVjX2lubmVyID0gZXFqb2luc2VsX2lubmVyKG9wZnVuY29pZCwgY29sbGF0
aW9uLAotCQkJCQkJCQkgICZ2YXJkYXRhMSwgJnZhcmRhdGEyLAogCQkJCQkJCQkgIG5kMSwg
bmQyLAogCQkJCQkJCQkgIGlzZGVmYXVsdDEsIGlzZGVmYXVsdDIsCiAJCQkJCQkJCSAgJnNz
bG90MSwgJnNzbG90MiwKQEAgLTI0MzYsNyArMjQzNCw2IEBAIGVxam9pbnNlbChQR19GVU5D
VElPTl9BUkdTKQogICovCiBzdGF0aWMgZG91YmxlCiBlcWpvaW5zZWxfaW5uZXIoT2lkIG9w
ZnVuY29pZCwgT2lkIGNvbGxhdGlvbiwKLQkJCQlWYXJpYWJsZVN0YXREYXRhICp2YXJkYXRh
MSwgVmFyaWFibGVTdGF0RGF0YSAqdmFyZGF0YTIsCiAJCQkJZG91YmxlIG5kMSwgZG91Ymxl
IG5kMiwKIAkJCQlib29sIGlzZGVmYXVsdDEsIGJvb2wgaXNkZWZhdWx0MiwKIAkJCQlBdHRT
dGF0c1Nsb3QgKnNzbG90MSwgQXR0U3RhdHNTbG90ICpzc2xvdDIsCi0tIAoyLjM0LjEKCg==


--------------s9ft2o0M0wH0B3xDH2KZZymR--