Message-ID: <7cf1745e-9bc7-b4ac-eac0-e0cf486de584@highgo.ca>
Date: Fri, 21 Apr 2023 12:56:01 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.10.0
Subject: Re: Add missing copyright for pg_upgrade/t/* files
Content-Language: en-US
To: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>,
 'Amit Kapila' <amit.kapila16@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <TYCPR01MB587073D91E372B8EF719931EF5929@TYCPR01MB5870.jpnprd01.prod.outlook.com>
 <CAA4eK1+grdj4Br7sGGs=8JO81k94iPWzuEn3WUmtf6SFQWDW-Q@mail.gmail.com>
 <TYAPR01MB5866C9F80BF0C497D017AD83F5939@TYAPR01MB5866.jpnprd01.prod.outlook.com>
From: David Zhang <david.zhang@highgo.ca>
In-Reply-To: <TYAPR01MB5866C9F80BF0C497D017AD83F5939@TYAPR01MB5866.jpnprd01.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/7cf1745e-9bc7-b4ac-eac0-e0cf486de584%40highgo.ca>
Precedence: bulk


> I checked the commit log.
> About 001_basic.pl, it had been added at 2017 once but been reverted soon [1][2].
> 322bec added the file again at 2022[3], so I chose 2022.
>
> About 002_pg_upgrade.pl, it has been added at the same time[3].
> Definitively it should be 2022.

It is great to make sure each file has the Copyright and I see this 
patch has already been committed.

Just curious, is there a rule to add Copyright to Postgres? For example, 
if I run a command `grep -rn Copyright --include="*.pl" | awk -F ':' 
{'print $2, $1'} | sort -nr` inside postgres/src/bin, It seems most 
Copyright were added to the second line, but these two were added to the 
very beginning (of course, there are three other files following this 
pattern as well).

...

2 pg_archivecleanup/t/010_pg_archivecleanup.pl
2 pg_amcheck/t/005_opclass_damage.pl
2 pg_amcheck/t/004_verify_heapam.pl
2 pg_amcheck/t/003_check.pl
2 pg_amcheck/t/002_nonesuch.pl
2 pg_amcheck/t/001_basic.pl
2 initdb/t/001_initdb.pl
1 pg_verifybackup/t/010_client_untar.pl
1 pg_verifybackup/t/008_untar.pl
1 pg_upgrade/t/002_pg_upgrade.pl
1 pg_upgrade/t/001_basic.pl
1 pg_basebackup/t/011_in_place_tablespace.pl


David