Subject: Remove old comments in dependencies.c and README.dependencies
From: atorikoshi <torikoshi_atsushi_z2@lab.ntt.co.jp>
Message-ID: <7cfb23fc-4493-9c02-5da9-e505fd0115d2@lab.ntt.co.jp>
Date: Mon, 26 Jun 2017 16:29:19 +0900
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="------------E6E892B765818A816B87BF0E"
To: pgsql-hackers@postgresql.org
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

This is a multi-part message in MIME format.
--------------E6E892B765818A816B87BF0E
Content-Type: text/plain; charset=iso-2022-jp; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit

Hi,

I found some comments which are not implemented.

As far as I have examined, these comments refer to min_group_size,
but min_group_size was decided not to adopt and removed[1], so
it seems these comments also should be removed.

[1]  
https://www.postgresql.org/message-id/CAKJS1f_vUck+qbxqsh4m_FNs+D4XA2KPyvvh0zYMjVg-eEHeAQ@mail.gmail.com

>>> 1) DEPENDENCY_MIN_GROUP_SIZE
>>>
>>> I'm not sure we still need the min_group_size, when evaluating
>>> dependencies. It was meant to deal with 'noisy' data, but I think it
>>> after switching to the 'degree' it might actually be a bad idea.
>
>Yeah, I'd wondered about this when I first started testing the patch.
>I failed to get any functional dependencies because my values were too
>unique. Seems I'd gotten a bit used to it, and in the end thought that
>if the values are unique enough then they won't suffer as much from
>the underestimation problem you're trying to solve here.
>
>I've removed that part of the code now.


Attached patch removes the comments about min_group_size.

Regards,

-- 
Atsushi Torikoshi
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

--------------E6E892B765818A816B87BF0E
Content-Type: text/plain; charset=UTF-8;
 name="remove-comment-for_min_group_size.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="remove-comment-for_min_group_size.patch"

ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3N0YXRpc3RpY3MvUkVBRE1FLmRl
cGVuZGVuY2llcyBiL3NyYy9iYWNrZW5kL3N0YXRpc3RpY3MvUkVBRE1FLmRl
cGVuZGVuY2llcwppbmRleCA3MDJkMzRlLi42YzQ0NmJkIDEwMDY0NAotLS0g
YS9zcmMvYmFja2VuZC9zdGF0aXN0aWNzL1JFQURNRS5kZXBlbmRlbmNpZXMK
KysrIGIvc3JjL2JhY2tlbmQvc3RhdGlzdGljcy9SRUFETUUuZGVwZW5kZW5j
aWVzCkBAIC03MSwxMCArNzEsNiBAQCBUbyBjb3VudCB0aGUgcm93cyBjb25z
aXN0ZW50IHdpdGggdGhlIGRlcGVuZGVuY3kgKGEgPT4gYik6CiAgKGMpIElm
IHRoZXJlJ3MgYSBzaW5nbGUgZGlzdGluY3QgdmFsdWUgaW4gJ2InLCB0aGUg
cm93cyBhcmUgY29uc2lzdGVudCB3aXRoCiAgICAgIHRoZSBmdW5jdGlvbmFs
IGRlcGVuZGVuY3ksIG90aGVyd2lzZSB0aGV5IGNvbnRyYWRpY3QgaXQuCiAK
LVRoZSBhbGdvcml0aG0gYWxzbyByZXF1aXJlcyBhIG1pbmltdW0gc2l6ZSBv
ZiB0aGUgZ3JvdXAgdG8gY29uc2lkZXIgaXQKLWNvbnNpc3RlbnQgKGN1cnJl
bnRseSAzIHJvd3MgaW4gdGhlIHNhbXBsZSkuIFNtYWxsIGdyb3VwcyBtYWtl
IGl0IGxlc3MgbGlrZWx5Ci10byBicmVhayB0aGUgY29uc2lzdGVuY3kuCi0K
IAogQ2xhdXNlIHJlZHVjdGlvbiAocGxhbm5lci9vcHRpbWl6ZXIpCiAtLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KZGlmZiAtLWdpdCBh
L3NyYy9iYWNrZW5kL3N0YXRpc3RpY3MvZGVwZW5kZW5jaWVzLmMgYi9zcmMv
YmFja2VuZC9zdGF0aXN0aWNzL2RlcGVuZGVuY2llcy5jCmluZGV4IDg5ZGVj
ZTMuLjJlN2MwYWQgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3N0YXRpc3Rp
Y3MvZGVwZW5kZW5jaWVzLmMKKysrIGIvc3JjL2JhY2tlbmQvc3RhdGlzdGlj
cy9kZXBlbmRlbmNpZXMuYwpAQCAtMjg2LDE0ICsyODYsNiBAQCBkZXBlbmRl
bmN5X2RlZ3JlZShpbnQgbnVtcm93cywgSGVhcFR1cGxlICpyb3dzLCBpbnQg
aywgQXR0ck51bWJlciAqZGVwZW5kZW5jeSwKIAkgKiBmaXJzdCAoay0xKSBj
b2x1bW5zLiBJZiB0aGVyZSdzIGEgc2luZ2xlIHZhbHVlIGluIHRoZSBsYXN0
IGNvbHVtbiwgd2UKIAkgKiBjb3VudCB0aGUgZ3JvdXAgYXMgJ3N1cHBvcnRp
bmcnIHRoZSBmdW5jdGlvbmFsIGRlcGVuZGVuY3kuIE90aGVyd2lzZSB3ZQog
CSAqIGNvdW50IGl0IGFzIGNvbnRyYWRpY3RpbmcuCi0JICoKLQkgKiBXZSBh
bHNvIHJlcXVpcmUgYSBncm91cCB0byBoYXZlIGEgbWluaW11bSBudW1iZXIg
b2Ygcm93cyB0byBiZQotCSAqIGNvbnNpZGVyZWQgdXNlZnVsIGZvciBzdXBw
b3J0aW5nIHRoZSBkZXBlbmRlbmN5LiBDb250cmFkaWN0aW5nIGdyb3Vwcwot
CSAqIG1heSBiZSBvZiBhbnkgc2l6ZSwgdGhvdWdoLgotCSAqCi0JICogWFhY
IFRoZSBtaW5pbXVtIHNpemUgcmVxdWlyZW1lbnQgbWFrZXMgaXQgaW1wb3Nz
aWJsZSB0byBpZGVudGlmeSBjYXNlCi0JICogd2hlbiBib3RoIGNvbHVtbnMg
YXJlIHVuaXF1ZSAob3IgbmVhcmx5IHVuaXF1ZSksIGFuZCB0aGVyZWZvcmUK
LQkgKiB0cml2aWFsbHkgZnVuY3Rpb25hbGx5IGRlcGVuZGVudC4KIAkgKi8K
IAogCS8qIHN0YXJ0IHdpdGggdGhlIGZpcnN0IHJvdyBmb3JtaW5nIGEgZ3Jv
dXAgKi8K

--------------E6E892B765818A816B87BF0E
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

--------------E6E892B765818A816B87BF0E--