pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pg_verify_checksums -r option
2+ messages / 2 participants
[nested] [flat]

* pg_verify_checksums -r option
@ 2018-08-24 16:01  Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
  0 siblings, 1 reply; 2+ messages in thread

From: Peter Eisentraut @ 2018-08-24 16:01 UTC (permalink / raw)
  To: pgsql-hackers

I'm curious about this option:

  -r RELFILENODE         check only relation with specified relfilenode

but there is no facility to specify a database.

Also, referring to the relfilenode of a mapped relation seems a bit
inaccurate.

Maybe reframing this in terms of the file name of the file you want
checked would be better?

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services




^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: pg_verify_checksums -r option
@ 2018-08-27 10:53  Yugo Nagata <nagata@sraoss.co.jp>
  parent: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
  0 siblings, 0 replies; 2+ messages in thread

From: Yugo Nagata @ 2018-08-27 10:53 UTC (permalink / raw)
  To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>; +Cc: pgsql-hackers

On Fri, 24 Aug 2018 18:01:09 +0200
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:

> I'm curious about this option:
> 
>   -r RELFILENODE         check only relation with specified relfilenode
> 
> but there is no facility to specify a database.
> 
> Also, referring to the relfilenode of a mapped relation seems a bit
> inaccurate.
> 
> Maybe reframing this in terms of the file name of the file you want
> checked would be better?

If we specified 1234 to -r option, pg_verify_shceksums checks not only 1234
but also 1234_vm, 1234_fsm, and 1234.1, 1234.2, ... and so on, so I think
it makes senses to allow to specify a relfilenode instead of a file name.

I think it is reasonable to add a option to specify a database, although
I don't know which character is good because both -d and -D are already used....

Regards,
-- 
Yugo Nagata <nagata@sraoss.co.jp>




^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2018-08-27 10:53 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2018-08-24 16:01 pg_verify_checksums -r option Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
2018-08-27 10:53 ` Yugo Nagata <nagata@sraoss.co.jp>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox