Message-ID: <7d6422f0-3d7e-4c48-395a-9a2339b4431d@dunslane.net>
Date: Tue, 29 Mar 2022 17:56:02 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: Extend compatibility of PostgreSQL::Test::Cluster
Content-Language: en-US
From: Andrew Dunstan <andrew@dunslane.net>
To: Michael Paquier <michael@paquier.xyz>
Cc: =?UTF-8?Q?Dagfinn_Ilmari_Manns=c3=a5ker?= <ilmari@ilmari.org>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <a3efd19a-d5c9-fdf2-6094-4cde056a2708@dunslane.net>
 <9cb08168-6e0e-6a37-0505-13dd180451e5@dunslane.net>
 <87lf00oifg.fsf@wibble.ilmari.org>
 <d15f6d95-4a0d-a959-c186-edc636e392b2@dunslane.net>
 <3e9cd86a-712c-28a2-92ae-34f4d6589aec@dunslane.net>
 <Yepk9CGLe5hZaIz1@paquier.xyz>
 <3036c96e-b69a-e46f-94b7-475c319a3ef3@dunslane.net>
In-Reply-To: <3036c96e-b69a-e46f-94b7-475c319a3ef3@dunslane.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/7d6422f0-3d7e-4c48-395a-9a2339b4431d%40dunslane.net>
Precedence: bulk


On 1/21/22 09:59, Andrew Dunstan wrote:
> On 1/21/22 02:47, Michael Paquier wrote:
>> On Tue, Jan 18, 2022 at 06:35:39PM -0500, Andrew Dunstan wrote:
>>> Here's a version that does that and removes some recent bitrot.
>> I have been looking at the full set of features of Cluster.pm and the
>> requirements behind v10 as minimal version supported, and nothing
>> really stands out.
>>
>> +   # old versions of walreceiver just set the application name to
>> +   # `walreceiver'
>>
>> Perhaps this should mention to which older versions this sentence
>> applies?
>
>
> Will do in the next version. FTR it's versions older than 12.
>
>

I'm not sure why this item has been moved to the next CF without any
discussion I could see on the mailing list. It was always my intention
to commit it this time, and I propose to do so tomorrow with the comment
Michael has requested above. The cfbot is still happy with it.


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com