Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oXelZ-0007b2-MD for pgsql-hackers@arkaria.postgresql.org; Mon, 12 Sep 2022 08:26:05 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oXelY-0002wQ-I6 for pgsql-hackers@arkaria.postgresql.org; Mon, 12 Sep 2022 08:26:04 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oXelY-0002wH-8b for pgsql-hackers@lists.postgresql.org; Mon, 12 Sep 2022 08:26:04 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oXelW-0005mH-0e for pgsql-hackers@postgresql.org; Mon, 12 Sep 2022 08:26:03 +0000 Received: from oss.nttdata.com (localhost [127.0.0.1]) by oss.nttdata.com (Postfix) with ESMTPA id 9CA0E6064A; Mon, 12 Sep 2022 17:25:44 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.7 at oss.nttdata.com MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_a4693f7b287c1975331c32a1c2f40bc7" Content-Transfer-Encoding: 7bit Date: Mon, 12 Sep 2022 17:25:44 +0900 From: bt22kawamotok To: Shinya Kato Cc: pgsql-hackers@postgresql.org Subject: Re: [PATCH]Feature improvement for MERGE tab completion In-Reply-To: References: <9f1ad2a87a58cd5e7d64f3993130958d@oss.nttdata.com> <359a46c295eae938d84552c11818ab62@oss.nttdata.com> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <7d7eef0f596e449746766ff4fb7c9061@oss.nttdata.com> X-Sender: bt22kawamotok@oss.nttdata.com List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --=_a4693f7b287c1975331c32a1c2f40bc7 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed > Thanks for updating! > > Compile errors have occurred, so can you fix them? > And I think we can eliminate similar redundancies in MERGE tab > completion and I would like you to fix them. > > For example, > > else if (TailMatches("WHEN", "MATCHED")) > COMPLETE_WITH("THEN", "AND"); > else if (TailMatches("WHEN", "NOT", "MATCHED")) > COMPLETE_WITH("THEN", "AND"); > > above statement can be converted to the statement below. > > else if (TailMatches("WHEN", "MATCHED") || > TailMatches("WHEN", "NOT", "MATCHED")) > COMPLETE_WITH("THEN", "AND"); Sorry for making such a silly mistake. I create new path. Please reviewing. Kotaro Kawamoto --=_a4693f7b287c1975331c32a1c2f40bc7 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=fix_tab_completion_merge_v3.patch Content-Disposition: attachment; filename=fix_tab_completion_merge_v3.patch; size=1593 ZGlmZiAtLWdpdCBhL3NyYy9iaW4vcHNxbC90YWItY29tcGxldGUuYyBiL3NyYy9iaW4vcHNxbC90 YWItY29tcGxldGUuYwppbmRleCA2MmEzOTc3OWI5Li5jMWU0NTVmYWIxIDEwMDY0NAotLS0gYS9z cmMvYmluL3BzcWwvdGFiLWNvbXBsZXRlLmMKKysrIGIvc3JjL2Jpbi9wc3FsL3RhYi1jb21wbGV0 ZS5jCkBAIC00MDY4LDcgKzQwNjgsNyBAQCBwc3FsX2NvbXBsZXRpb24oY29uc3QgY2hhciAqdGV4 dCwgaW50IHN0YXJ0LCBpbnQgZW5kKQogCS8qIHdpdGggW0FTXSBhbGlhcyAqLwogCWVsc2UgaWYg KFRhaWxNYXRjaGVzKCJNRVJHRSIsICJJTlRPIiwgTWF0Y2hBbnksICJBUyIsIE1hdGNoQW55KSkK IAkJQ09NUExFVEVfV0lUSCgiVVNJTkciKTsKLQllbHNlIGlmIChUYWlsTWF0Y2hlcygiTUVSR0Ui LCAiSU5UTyIsIE1hdGNoQW55LCBNYXRjaEFueSkpCisJZWxzZSBpZiAoVGFpbE1hdGNoZXMoIk1F UkdFIiwgIklOVE8iLCBNYXRjaEFueSwgTWF0Y2hBbnkpICYmICFUYWlsTWF0Y2hlcygiQVMiKSkK IAkJQ09NUExFVEVfV0lUSCgiVVNJTkciKTsKIAllbHNlIGlmIChUYWlsTWF0Y2hlcygiTUVSR0Ui LCAiSU5UTyIsIE1hdGNoQW55LCAiQVMiLCBNYXRjaEFueSwgIlVTSU5HIikpCiAJCUNPTVBMRVRF X1dJVEhfU0NIRU1BX1FVRVJZKFF1ZXJ5X2Zvcl9saXN0X29mX3RhYmxlcyk7CkBAIC00MDk1LDEy ICs0MDk1LDE2IEBAIHBzcWxfY29tcGxldGlvbihjb25zdCBjaGFyICp0ZXh0LCBpbnQgc3RhcnQs IGludCBlbmQpCiAJCUNPTVBMRVRFX1dJVEgoIldIRU4gTUFUQ0hFRCIsICJXSEVOIE5PVCBNQVRD SEVEIik7CiAJZWxzZSBpZiAoVGFpbE1hdGNoZXMoIlVTSU5HIiwgTWF0Y2hBbnksIE1hdGNoQW55 LCAiT04iLCBNYXRjaEFueSkpCiAJCUNPTVBMRVRFX1dJVEgoIldIRU4gTUFUQ0hFRCIsICJXSEVO IE5PVCBNQVRDSEVEIik7CisJZWxzZSBpZiAoVGFpbE1hdGNoZXMoIlVTSU5HIiwgTWF0Y2hBbnks ICJPTiIsIE1hdGNoQW55LCAiV0hFTiIpIHx8CisJCQkgVGFpbE1hdGNoZXMoIlVTSU5HIiwgTWF0 Y2hBbnksICJBUyIsIE1hdGNoQW55LCAiT04iLCBNYXRjaEFueSwgIldIRU4iKSB8fAorCQkJIFRh aWxNYXRjaGVzKCJVU0lORyIsIE1hdGNoQW55LCBNYXRjaEFueSwgIk9OIiwgTWF0Y2hBbnksICJX SEVOIikpCisJCUNPTVBMRVRFX1dJVEgoIk1BVENIRUQiLCAiTk9UIE1BVENIRUQiKTsKIAllbHNl IGlmIChUYWlsTWF0Y2hlcygiV0hFTiIsICJNQVRDSEVEIikpCiAJCUNPTVBMRVRFX1dJVEgoIlRI RU4iLCAiQU5EIik7CiAJZWxzZSBpZiAoVGFpbE1hdGNoZXMoIldIRU4iLCAiTk9UIiwgIk1BVENI RUQiKSkKIAkJQ09NUExFVEVfV0lUSCgiVEhFTiIsICJBTkQiKTsKIAllbHNlIGlmIChUYWlsTWF0 Y2hlcygiV0hFTiIsICJNQVRDSEVEIiwgIlRIRU4iKSkKLQkJQ09NUExFVEVfV0lUSCgiVVBEQVRF IiwgIkRFTEVURSIpOworCQlDT01QTEVURV9XSVRIKCJVUERBVEUiLCAiREVMRVRFIiwgIkRPIE5P VEhJTkciKTsKIAllbHNlIGlmIChUYWlsTWF0Y2hlcygiV0hFTiIsICJOT1QiLCAiTUFUQ0hFRCIs ICJUSEVOIikpCiAJCUNPTVBMRVRFX1dJVEgoIklOU0VSVCIsICJETyBOT1RISU5HIik7CiAK --=_a4693f7b287c1975331c32a1c2f40bc7--