MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="=_dc7b0d619cf132b777dc1a3dc3cf4a5d"
Content-Transfer-Encoding: 7bit
Date: Tue, 09 Jul 2024 15:56:34 +0900
From: ikedarintarof <ikedarintarof@oss.nttdata.com>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Jelte Fennema-Nio <postgres@jeltef.nl>, Robert Haas
 <robertmhaas@gmail.com>, pgsql-hackers@postgresql.org
Subject: Re: doc: modify the comment in function libpqrcv_check_conninfo()
In-Reply-To: <2faf37e9-3941-43b5-93e8-f54965b250df@oss.nttdata.com>
References: <6a1ca81b27fec4da0ccdfaaaec787982@oss.nttdata.com>
 <CAGECzQRjJkCQ9AUQA_7kJw8c4iUwVAXPfD_VQu+-DVcd-LCT8A@mail.gmail.com>
 <9c15a4b74d09348d03b02934fc429c94@oss.nttdata.com>
 <CAGECzQQ+bpYVuF6GpVdc9vzHOObs5HJLmj5YohOb2d-ctmCffg@mail.gmail.com>
 <c380192faada009af9aa5bfcd06e140d@oss.nttdata.com>
 <CAGECzQRPygEJr3Ed2p7QsUsBkecUa0mpiE3zMOEh5_NtvAfgRw@mail.gmail.com>
 <202ec279-c307-48b9-9920-730fb1221d27@oss.nttdata.com>
 <d5f5fb21f27c17c400a4dbe386d008a8@oss.nttdata.com>
 <2faf37e9-3941-43b5-93e8-f54965b250df@oss.nttdata.com>
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <7d845121f0ea99e68b4403b9cd6f86ac@oss.nttdata.com>
Archived-At: 
 <https://www.postgresql.org/message-id/7d845121f0ea99e68b4403b9cd6f86ac%40oss.nttdata.com>
Precedence: bulk

--=_dc7b0d619cf132b777dc1a3dc3cf4a5d
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII;
 format=flowed

> - * Validate connection info string, and determine whether it might 
> cause
> - * local filesystem access to be attempted.
> + * The function
> + * 1. validates connection info string and
> + * 2. checks a password is provided if must_use_password is true.
> 
> IMO, "Validate connection info string" is sufficient. The mention of
> must_use_password is redundant since it's explained in the latter part 
> of
> the comment.

That is reasonable for me. I've removed the second one.
The modified patch is attached.

Regards,

Rintaro Ikeda


--=_dc7b0d619cf132b777dc1a3dc3cf4a5d
Content-Transfer-Encoding: base64
Content-Type: text/x-diff;
 name=v4-0001-modify-the-commnet-in-libpqrcv_check_conninfo.patch
Content-Disposition: attachment;
 filename=v4-0001-modify-the-commnet-in-libpqrcv_check_conninfo.patch;
 size=1383

RnJvbSA3YTg4YWQ3ZjMwNjUxOTY0OGFkOThlYWYwM2U1MDFlNjZiYTlkNWVhIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBSaW50YXJvIElrZWRhIDw1MTM5NDc2NityaW5pa2VkYUB1c2Vy
cy5ub3JlcGx5LmdpdGh1Yi5jb20+CkRhdGU6IFRodSwgMjcgSnVuIDIwMjQgMTY6MDQ6MDggKzA5
MDAKU3ViamVjdDogW1BBVENIIHY0XSBtb2RpZnkgdGhlIGNvbW1uZXQgaW4gbGlicHFyY3ZfY2hl
Y2tfY29ubmluZm8oKQoKLS0tCiAuLi4vcmVwbGljYXRpb24vbGlicHF3YWxyZWNlaXZlci9saWJw
cXdhbHJlY2VpdmVyLmMgICAgICAgfCA4ICsrKystLS0tCiAxIGZpbGUgY2hhbmdlZCwgNCBpbnNl
cnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3JlcGxp
Y2F0aW9uL2xpYnBxd2FscmVjZWl2ZXIvbGlicHF3YWxyZWNlaXZlci5jIGIvc3JjL2JhY2tlbmQv
cmVwbGljYXRpb24vbGlicHF3YWxyZWNlaXZlci9saWJwcXdhbHJlY2VpdmVyLmMKaW5kZXggMDJm
MTJmMjkyMS4uNmM0MmMyMDlkMiAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvcmVwbGljYXRpb24v
bGlicHF3YWxyZWNlaXZlci9saWJwcXdhbHJlY2VpdmVyLmMKKysrIGIvc3JjL2JhY2tlbmQvcmVw
bGljYXRpb24vbGlicHF3YWxyZWNlaXZlci9saWJwcXdhbHJlY2VpdmVyLmMKQEAgLTMwNSwxMiAr
MzA1LDEyIEBAIGJhZF9jb25uZWN0aW9uOgogfQogCiAvKgotICogVmFsaWRhdGUgY29ubmVjdGlv
biBpbmZvIHN0cmluZywgYW5kIGRldGVybWluZSB3aGV0aGVyIGl0IG1pZ2h0IGNhdXNlCi0gKiBs
b2NhbCBmaWxlc3lzdGVtIGFjY2VzcyB0byBiZSBhdHRlbXB0ZWQuCisgKiBWYWxpZGF0ZSBjb25u
ZWN0aW9uIGluZm8gc3RyaW5nLgogICoKICAqIElmIHRoZSBjb25uZWN0aW9uIHN0cmluZyBjYW4n
dCBiZSBwYXJzZWQsIHRoaXMgZnVuY3Rpb24gd2lsbCByYWlzZQotICogYW4gZXJyb3IgYW5kIHdp
bGwgbm90IHJldHVybi4gSWYgaXQgY2FuLCBpdCB3aWxsIHJldHVybiB0cnVlIGlmIHRoaXMKLSAq
IGNvbm5lY3Rpb24gc3RyaW5nIHNwZWNpZmllcyBhIHBhc3N3b3JkIGFuZCBmYWxzZSBvdGhlcndp
c2UuCisgKiBhbiBlcnJvci4gSWYgbXVzdF91c2VfcGFzc3dvcmQgaXMgdHJ1ZSwgdGhlIGZ1bmN0
aW9uIHJhaXNlcyBhbiBlcnJvcgorICogaWYgbm8gcGFzc3dvcmQgaXMgcHJvdmlkZWQgaW4gdGhl
IGNvbm5lY3Rpb24gc3RyaW5nLiBJbiBhbnkgb3RoZXIgY2FzZQorICogaXQgc3VjY2Vzc2Z1bGx5
IGNvbXBsZXRlcy4KICAqLwogc3RhdGljIHZvaWQKIGxpYnBxcmN2X2NoZWNrX2Nvbm5pbmZvKGNv
bnN0IGNoYXIgKmNvbm5pbmZvLCBib29sIG11c3RfdXNlX3Bhc3N3b3JkKQotLSAKMi4zOS4zIChB
cHBsZSBHaXQtMTQ2KQoK
--=_dc7b0d619cf132b777dc1a3dc3cf4a5d--