Message-ID: <7de5f33f49a91d7b30b8c01fe46fc280713ebae1.camel@cybertec.at>
Subject: Re: Version 14/15 documentation Section "Alter Default Privileges"
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Michael Banck <mbanck@gmx.net>
Cc: David Burns <david.burns@fedex.com>, pgsql-hackers@lists.postgresql.org
Date: Fri, 27 Oct 2023 17:49:42 +0200
In-Reply-To: <653b841d.a70a0220.17f72.2c12@mx.google.com>
References: 
	<LV2PR12MB5725F7C1B8EB2FC38829F276E7399@LV2PR12MB5725.namprd12.prod.outlook.com>
	 <4a6f157edc4ae38a2050a5893e6729cbb98113bc.camel@cybertec.at>
	 <f898e097dbe5e718ec1a6e977d4dda79a6548abb.camel@cybertec.at>
	 <a6671d5651e64fceff340c68dbdc41a9c5098748.camel@cybertec.at>
	 <653b841d.a70a0220.17f72.2c12@mx.google.com>
Content-Type: multipart/mixed; boundary="=-edSIls78Ms5u1FLHidZt"
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Archived-At: <https://www.postgresql.org/message-id/7de5f33f49a91d7b30b8c01fe46fc280713ebae1.camel%40cybertec.at>
Precedence: bulk

--=-edSIls78Ms5u1FLHidZt
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2023-10-27 at 11:34 +0200, Michael Banck wrote:
> On Fri, Oct 27, 2023 at 09:03:04AM +0200, Laurenz Albe wrote:
> > On Fri, 2022-11-04 at 10:49 +0100, Laurenz Albe wrote:
> > > On Thu, 2022-11-03 at 11:32 +0100, Laurenz Albe wrote:
> > > > On Wed, 2022-11-02 at 19:29 +0000, David Burns wrote:
> > > > > Some additional clarity in the versions 14/15 documentation
> > > > > would be helpful specifically surrounding the "target_role"
> > > > > clause for the ALTER DEFAULT PRIVILEGES command.  To the
> > > > > uninitiated, the current description seems vague.=C2=A0 Maybe
> > > > > something like the following would help:
> > >=20
> > > After some more thinking, I came up with the attached patch.
> >=20
> I think something like this is highly useful because I have also seen
> people very confused why default privileges are not applied.
>=20
> However, maybe it could be made even clearer if also the main
> description is amended, like
>=20
> "You can change default privileges only for objects that will be created
> by yourself or by roles that you are a member of (via target_role)."
>=20
> or something.

True.  I have done that in the attached patch.
In this patch, it is mentioned *twice* that ALTER DEFAULT PRIVILEGES
only affects objects created by the current user.  I thought that
would not harm, but if it is too redundant, I can remove the second
mention.

Yours,
Laurenz Albe

--=-edSIls78Ms5u1FLHidZt
Content-Disposition: attachment;
	filename="0001-Improve-ALTER-DEFAULT-PRIVILEGES-documentation.V2.patch"
Content-Type: text/x-patch;
	name="0001-Improve-ALTER-DEFAULT-PRIVILEGES-documentation.V2.patch";
	charset="UTF-8"
Content-Transfer-Encoding: base64

RnJvbSA2YzYxODU1M2NjMjE2MzllNzc0ZjZmZDEwODQyMzEzNDEzOWJmYzBhIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBMYXVyZW56IEFsYmUgPGxhdXJlbnouYWxiZUBjeWJlcnRlYy5h
dD4KRGF0ZTogRnJpLCAyNyBPY3QgMjAyMyAxNzo0NDoxOSArMDIwMApTdWJqZWN0OiBbUEFUQ0hd
IEltcHJvdmUgQUxURVIgREVGQVVMVCBQUklWSUxFR0VTIGRvY3VtZW50YXRpb24KCkNsYXJpZnkg
dGhhdCBkZWZhdWx0IHByaXZpbGVnZXMgYXJlIG9ubHkgYXBwbGllZCB0byBvYmplY3RzCmNyZWF0
ZWQgYnkgdGhlIHRhcmdldCByb2xlLiAgVGhpcyBoYXMgYmVlbiBhIGZyZXF1ZW50IHNvdXJjZQpv
ZiBtaXN1bmRlcnN0YW5kaW5ncy4KClBlciByZXF1ZXN0IGZyb20gRGF2aWQgQnVybnMuCgpBdXRo
b3I6IExhdXJlbnogQWxiZQpSZXZpZXdlZC1ieTogTWljaGFlbCBCYW5jawpEaXNjdXNzaW9uOiBo
dHRwczovL3Bvc3Rnci5lcy9tL0xWMlBSMTJNQjU3MjVGN0MxQjhFQjJGQzM4ODI5RjI3NkU3Mzk5
JTQwTFYyUFIxMk1CNTcyNS5uYW1wcmQxMi5wcm9kLm91dGxvb2suY29tCi0tLQogZG9jL3NyYy9z
Z21sL3JlZi9hbHRlcl9kZWZhdWx0X3ByaXZpbGVnZXMuc2dtbCB8IDEwICsrKysrKysrKy0KIDEg
ZmlsZSBjaGFuZ2VkLCA5IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQg
YS9kb2Mvc3JjL3NnbWwvcmVmL2FsdGVyX2RlZmF1bHRfcHJpdmlsZWdlcy5zZ21sIGIvZG9jL3Ny
Yy9zZ21sL3JlZi9hbHRlcl9kZWZhdWx0X3ByaXZpbGVnZXMuc2dtbAppbmRleCBmMWQ1NGY1YWEz
Li5jZjBmZmE5YzQ5IDEwMDY0NAotLS0gYS9kb2Mvc3JjL3NnbWwvcmVmL2FsdGVyX2RlZmF1bHRf
cHJpdmlsZWdlcy5zZ21sCisrKyBiL2RvYy9zcmMvc2dtbC9yZWYvYWx0ZXJfZGVmYXVsdF9wcml2
aWxlZ2VzLnNnbWwKQEAgLTkwLDcgKzkwLDEwIEBAIFJFVk9LRSBbIEdSQU5UIE9QVElPTiBGT1Ig
XQogICA8cGFyYT4KICAgIDxjb21tYW5kPkFMVEVSIERFRkFVTFQgUFJJVklMRUdFUzwvY29tbWFu
ZD4gYWxsb3dzIHlvdSB0byBzZXQgdGhlIHByaXZpbGVnZXMKICAgIHRoYXQgd2lsbCBiZSBhcHBs
aWVkIHRvIG9iamVjdHMgY3JlYXRlZCBpbiB0aGUgZnV0dXJlLiAgKEl0IGRvZXMgbm90Ci0gICBh
ZmZlY3QgcHJpdmlsZWdlcyBhc3NpZ25lZCB0byBhbHJlYWR5LWV4aXN0aW5nIG9iamVjdHMuKSAg
Q3VycmVudGx5LAorICAgYWZmZWN0IHByaXZpbGVnZXMgYXNzaWduZWQgdG8gYWxyZWFkeS1leGlz
dGluZyBvYmplY3RzLikgIDxjb21tYW5kPkFMVEVSCisgICBERUZBVUxUIFBSSVZJTEVHRVM8L2Nv
bW1hbmQ+IGNoYW5nZXMgZGVmYXVsdCBwcml2aWxlZ2VzIG9ubHkgZm9yIG9iamVjdHMKKyAgIHRo
YXQgd2lsbCBiZSBjcmVhdGVkIGJ5IHRoZSB1c2VyIHRoYXQgZXhlY3V0ZWQgdGhlIHN0YXRlbWVu
dCAob3IgYnkKKyAgIDxyZXBsYWNlYWJsZT50YXJnZXRfcm9sZTwvcmVwbGFjZWFibGU+LCBpZiBz
cGVjaWZpZWQpLiAgQ3VycmVudGx5LAogICAgb25seSB0aGUgcHJpdmlsZWdlcyBmb3Igc2NoZW1h
cywgdGFibGVzIChpbmNsdWRpbmcgdmlld3MgYW5kIGZvcmVpZ24KICAgIHRhYmxlcyksIHNlcXVl
bmNlcywgZnVuY3Rpb25zLCBhbmQgdHlwZXMgKGluY2x1ZGluZyBkb21haW5zKSBjYW4gYmUKICAg
IGFsdGVyZWQuICBGb3IgdGhpcyBjb21tYW5kLCBmdW5jdGlvbnMgaW5jbHVkZSBhZ2dyZWdhdGVz
IGFuZCBwcm9jZWR1cmVzLgpAQCAtMTM4LDYgKzE0MSwxMSBAQCBSRVZPS0UgWyBHUkFOVCBPUFRJ
T04gRk9SIF0KICAgICAgPHBhcmE+CiAgICAgICBUaGUgbmFtZSBvZiBhbiBleGlzdGluZyByb2xl
IG9mIHdoaWNoIHRoZSBjdXJyZW50IHJvbGUgaXMgYSBtZW1iZXIuCiAgICAgICBJZiA8bGl0ZXJh
bD5GT1IgUk9MRTwvbGl0ZXJhbD4gaXMgb21pdHRlZCwgdGhlIGN1cnJlbnQgcm9sZSBpcyBhc3N1
bWVkLgorICAgICAgRGVmYXVsdCBwcml2aWxlZ2VzIGFyZSBvbmx5IGNoYW5nZWQgZm9yIG5ldyBv
YmplY3RzIGNyZWF0ZWQgYnkgdGhlCisgICAgICA8cmVwbGFjZWFibGU+dGFyZ2V0X3JvbGU8L3Jl
cGxhY2VhYmxlPi4gIFRoZXJlIGlzIG5vIHdheSB0byBzZXQgZGVmYXVsdAorICAgICAgcHJpdmls
ZWdlcyBmb3Igb2JqZWN0cyBjcmVhdGVkIGJ5IGFyYml0cmFyeSByb2xlczsgZm9yIHRoYXQsIHlv
dSdkIGhhdmUKKyAgICAgIHRvIHJ1biA8Y29tbWFuZD5BTFRFUiBERUZBVUxUIFBSSVZJTEVHRVM8
L2NvbW1hbmQ+IGZvciBlYWNoIHJvbGUgdGhhdCBjYW4KKyAgICAgIGNyZWF0ZSBvYmplY3RzLgog
ICAgICA8L3BhcmE+CiAgICAgPC9saXN0aXRlbT4KICAgIDwvdmFybGlzdGVudHJ5PgotLSAKMi40
MS4wCgo=


--=-edSIls78Ms5u1FLHidZt--